Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Exceptions] Use semantic version for manifest version + Scaling Tweaks #73388

Merged
merged 20 commits into from
Jul 29, 2020

Conversation

madirey
Copy link
Contributor

@madirey madirey commented Jul 28, 2020

Summary

  • Updates manifest version so that it's a semantic version (compatible with global artifacts)
  • Allows configuration of task interval for creating artifacts
  • Allows configuration of artifact validation on download
  • Updates validation on download route so that it consumes less memory (it was crashing on download of 5,000+ entry exception list)
  • Removes linux artifact generation (not needed)
  • Modifies UI so that endpoint exceptions are not applied to linux

Checklist

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-response (Team:Endpoint Response)

@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

@madirey madirey requested a review from peluja1012 July 28, 2020 01:42
Copy link

@alexk307 alexk307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:

Tested with 1900 items in the exception list at 50/100/200/400 agents. All configurations looked stable!

image

@madirey
Copy link
Contributor Author

madirey commented Jul 28, 2020

@elasticmachine merge upstream

@@ -233,7 +233,7 @@ export const AddExceptionModal = memo(function AddExceptionModal({
);

const retrieveAlertOsTypes = useCallback(() => {
const osDefaults = ['windows', 'macos', 'linux'];
const osDefaults = ['windows', 'macos'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@peluja1012 peluja1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Madi!

@madirey
Copy link
Contributor Author

madirey commented Jul 28, 2020

@elasticmachine merge upstream

@madirey
Copy link
Contributor Author

madirey commented Jul 29, 2020

@elasticmachine merge upstream

1 similar comment
@madirey
Copy link
Contributor Author

madirey commented Jul 29, 2020

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

expected head sha didn’t match current head ref.

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / persist the deletion of a column.persistent timeline persist the deletion of a column

Link to Jenkins

Stack Trace

AssertionError: expected 'message' to not equal 'message'
    at Context.eval (http://localhost:61141/__cypress/tests?p=cypress/integration/timeline_local_storage.spec.ts:686:40)

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB -8.0B 7.3MB

Saved Objects .kibana field count

id value diff baseline
endpoint:user-artifact-manifest 5 +2 3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@madirey madirey merged commit 5a04909 into elastic:master Jul 29, 2020
@madirey madirey deleted the manifest-fixes-7.9 branch July 29, 2020 02:43
madirey added a commit to madirey/kibana that referenced this pull request Jul 29, 2020
…sion + Scaling Tweaks (elastic#73388)

* Manifest version is semantic version

* Configurable task interval

* Use task interval over scheduled when provided

* Fix crash on download of large artifact

* Don't need to generate linux artifacts

* Configurable artifact validation

* Test fixes

* Test fixes

* Type/test fixes

* Final tweaks

* Remove linux endpoint exception generation from UI

* Fix paging so that we stop before 10k

* Fix pagination

* Fix pagination test

Co-authored-by: Elastic Machine <[email protected]>
spong pushed a commit that referenced this pull request Jul 29, 2020
…sion + Scaling Tweaks (#73388) (#73610)

* Manifest version is semantic version

* Configurable task interval

* Use task interval over scheduled when provided

* Fix crash on download of large artifact

* Don't need to generate linux artifacts

* Configurable artifact validation

* Test fixes

* Test fixes

* Type/test fixes

* Final tweaks

* Remove linux endpoint exception generation from UI

* Fix paging so that we stop before 10k

* Fix pagination

* Fix pagination test

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
madirey added a commit that referenced this pull request Jul 29, 2020
…sion + Scaling Tweaks (#73388) (#73609)

* Manifest version is semantic version

* Configurable task interval

* Use task interval over scheduled when provided

* Fix crash on download of large artifact

* Don't need to generate linux artifacts

* Configurable artifact validation

* Test fixes

* Test fixes

* Type/test fixes

* Final tweaks

* Remove linux endpoint exception generation from UI

* Fix paging so that we stop before 10k

* Fix pagination

* Fix pagination test

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants