Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return EUI CSS to Shareable Runtime #72990

Merged
merged 3 commits into from
Jul 24, 2020
Merged

Return EUI CSS to Shareable Runtime #72990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73840f2
Add Canvas Styles
clintandrewhall Jul 22, 2020
b42a64c
Tree-shaking in EUI omits CSS in the runtime
clintandrewhall Jul 23, 2020
6fcc9e1
Merge branch 'master' into shareable_styles
elasticmachine Jul 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/canvas/shareable_runtime/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ There are a number of options for the build script:

### Prerequisite

Before testing or running this PR locally, you **must** run `node scripts/runtime` from `/canvas` _after_ `yarn kbn bootstrap` and _before_ starting Kibana. It is only built automatically when Kibana is built to avoid slowing down other development activities.
Before testing or running this PR locally, you **must** run `node scripts/shareable_runtime` from `/canvas` _after_ `yarn kbn bootstrap` and _before_ starting Kibana. It is only built automatically when Kibana is built to avoid slowing down other development activities.

### Webpack Dev Server

Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/canvas/shareable_runtime/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ module.exports = {
options: {
presets: [require.resolve('@kbn/babel-preset/webpack_preset')],
},
sideEffects: false,
},
{
test: /\.tsx?$/,
Expand Down Expand Up @@ -92,6 +91,7 @@ module.exports = {
},
},
],
sideEffects: true,
},
{
test: /\.module\.s(a|c)ss$/,
Expand Down