Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CANVAS] Exclude variables from rendered workpad #72970

Merged
merged 1 commit into from
Jul 23, 2020
Merged

[CANVAS] Exclude variables from rendered workpad #72970

merged 1 commit into from
Jul 23, 2020

Conversation

crob611
Copy link
Contributor

@crob611 crob611 commented Jul 22, 2020 •
edited
Loading

Fixes #72961

Summary

Exclude the variables from the renderedWorkpad type. This stops them from being passed and fixes the route validation error.

@crob611 crob611 requested a review from a team as a code owner July 22, 2020 21:03
@crob611 crob611 added bug Fixes for quality problems that affect the customer experience loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.9.0 v8.0.0 labels Jul 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

poffdeluxe
poffdeluxe approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
canvas 1.5MB +40.0B 1.5MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@wylieconlon
Copy link
Contributor

@crob611 I think you've linked the wrong issue for closing

@crob611
Copy link
Contributor Author

crob611 commented Jul 23, 2020

@wylieconlon Thanks...fixed

@crob611 crob611 merged commit f5a81de into elastic:master Jul 23, 2020
This was referenced Jul 24, 2020
Merged
Merged
crob611 pushed a commit to crob611/kibana that referenced this pull request Jul 24, 2020
Exclude variables from rendered workpad (elastic#72970)
73d8324
crob611 pushed a commit to crob611/kibana that referenced this pull request Jul 24, 2020
Exclude variables from rendered workpad (elastic#72970)
c3d62f0
crob611 pushed a commit that referenced this pull request Jul 24, 2020
Exclude variables from rendered workpad (#72970) (#73207)
055d3f2
crob611 pushed a commit that referenced this pull request Jul 24, 2020
Exclude variables from rendered workpad (#72970) (#73206)
5917b57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poffdeluxe poffdeluxe poffdeluxe approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Canvas] Route validation failure downloading Shareable .zip
5 participants
@crob611 @elasticmachine @kibanamachine @wylieconlon @poffdeluxe