[kbn/test/failed_test_reporter] handle cypress junit better #72968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
spalger
added
release_note:skip
|
Pinging @elastic/kibana-operations (Team:Operations) |
brianseeders
approved these changes
Jul 23, 2020
This was referenced Jul 23, 2020
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jul 23, 2020
…72968) Co-authored-by: spalger <[email protected]>
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jul 23, 2020
…72968) Co-authored-by: spalger <[email protected]>
spalger
added a commit
that referenced
this pull request
Jul 23, 2020
…2968) (#73084) Co-authored-by: spalger <[email protected]> Co-authored-by: spalger <[email protected]>
spalger
added a commit
that referenced
this pull request
Jul 23, 2020
…2968) (#73083) Co-authored-by: spalger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed recently that cypress failures reported by SIEM don't include the "Failed Test Reporter" messages, including the number of occurrences of a test. This means that we can't get the link to Github right out of Jenkins and instead have to search the issues which throws a major kink in the workflow that I follow when triaging CI failures.
This PR changes the way that we augment the cypress junit output as it seems that Jenkins doesn't render stdout when a
<testcase><failure>has a message property. In that case the message property and the contents of the<failure>are rendered in the Jenkins UI. We instead prefix the<failure>when the message property exists.Example of test failures enhanced by changes in this PR https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/63800/testReport/