Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Fix config rollout move to limit concurrent config change instead of config per second #72931

Merged

Conversation

nchaulet
Copy link
Member

Description

Resolve #72072

This PR fix the configuration of agent config rollout, also we moved from a rate limit per second to a number of concurrent config upgrade.

Add a new config variable xpack.ingestManager.fleet.agentConfigRolloutConcurrency (by default set to 10)

Benchmark

I enrolled 2000 agents and triggered a config change

Before that change

86636922-deb17380-bfa2-11ea-9b6f-e363f2d1aacf

After the change with different concurency setup

Screen Shot 2020-07-22 at 11 17 47 AM

Screen Shot 2020-07-22 at 1 43 23 PM

Screen Shot 2020-07-22 at 1 20 32 PM

@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.9.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 22, 2020
@nchaulet nchaulet requested a review from a team July 22, 2020 18:03
@nchaulet nchaulet self-assigned this Jul 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, let's make sure to send out an email about the config key changes when this gets merged and backported.

Copy link
Contributor

@jfsiii jfsiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some comments but 👍 to 🚀

Can we add tests for this behavior?

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nchaulet nchaulet merged commit 06f142d into elastic:master Jul 23, 2020
@nchaulet nchaulet deleted the fix-fleet-config-rollout-configuration branch July 23, 2020 12:07
nchaulet added a commit to nchaulet/kibana that referenced this pull request Jul 23, 2020
nchaulet added a commit to nchaulet/kibana that referenced this pull request Jul 23, 2020
nchaulet added a commit that referenced this pull request Jul 23, 2020
nchaulet added a commit that referenced this pull request Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ingest Manager] Better naming of Fleet configuration for agent config rollout
5 participants