-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest Manager] Fix config rollout move to limit concurrent config change instead of config per second #72931
[Ingest Manager] Fix config rollout move to limit concurrent config change instead of config per second #72931
Conversation
…hange instead of config per second
Pinging @elastic/ingest-management (Team:Ingest Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, let's make sure to send out an email about the config key changes when this gets merged and backported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left some comments but 👍 to 🚀
Can we add tests for this behavior?
x-pack/plugins/ingest_manager/server/services/agents/checkin/state_new_actions.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/ingest_manager/server/services/agents/checkin/state_new_actions.ts
Outdated
Show resolved
Hide resolved
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
…hange instead of config per second (elastic#72931)
…hange instead of config per second (elastic#72931)
Description
Resolve #72072
This PR fix the configuration of agent config rollout, also we moved from a rate limit per second to a number of concurrent config upgrade.
Add a new config variable
xpack.ingestManager.fleet.agentConfigRolloutConcurrency
(by default set to 10)Benchmark
I enrolled 2000 agents and triggered a config change
Before that change
After the change with different concurency setup