-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIEM][Detection Engine][Lists] Adds version and immutability data structures #72730
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ | |
|
||
import * as t from 'io-ts'; | ||
|
||
import { _version, description, id, meta, name } from '../common/schemas'; | ||
import { _version, description, id, meta, name, version } from '../common/schemas'; | ||
import { RequiredKeepUndefined } from '../../types'; | ||
|
||
export const patchListSchema = t.intersection([ | ||
|
@@ -17,7 +17,15 @@ export const patchListSchema = t.intersection([ | |
id, | ||
}) | ||
), | ||
t.exact(t.partial({ _version, description, meta, name })), | ||
t.exact( | ||
t.partial({ | ||
_version, // is undefined if not set during decode | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The The So the UI submits |
||
description, // is undefined if not set during decode | ||
meta, // is undefined if not set during decode | ||
name, // is undefined if not set during decode | ||
version, // is undefined if not set during decode | ||
}) | ||
), | ||
]); | ||
|
||
export type PatchListSchema = t.OutputOf<typeof patchListSchema>; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These comments have been super helpful throughout the lists api fyi - thank you!