Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] fix zoom in/zoom out buttons are not visible in dark mode #72699

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jul 21, 2020

Fixes #72667

Zoom in/zoom out button styles were improved over a year ago in #36837. Mapbox has been updated several times. Mapbox 1.6 caused the DOM structure to change so the CSS rule was no longer getting applied, mapbox/mapbox-gl-js#8874. This PR updates the CSS selector for the new DOM structure.

@nreese nreese requested a review from kindsun July 21, 2020 17:37
@nreese nreese requested a review from a team as a code owner July 21, 2020 17:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Contributor Author

nreese commented Jul 21, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
maps 284.1KB +272.0B 283.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elizabetdev elizabetdev self-requested a review July 22, 2020 13:49
Copy link
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better and works as expected. lgtm!
image

  • code review
  • tested locally in chrome

Copy link
Contributor

@elizabetdev elizabetdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! 🎉

@nreese nreese merged commit fa11161 into elastic:master Jul 22, 2020
nreese added a commit to nreese/kibana that referenced this pull request Jul 22, 2020
nreese added a commit to nreese/kibana that referenced this pull request Jul 22, 2020
nreese added a commit that referenced this pull request Jul 22, 2020
nreese added a commit that referenced this pull request Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zoom in/zoom out buttons are not visible(look disabled) in dark mode on maps
5 participants