[ML] DF Analytics results: add index-pattern management link to 'click here' error prompt #72470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
release_note:fix
:ml
Feature:Data Frame Analytics
qn895
approved these changes
Jul 20, 2020
|
Tested and LGTM. Although I'm wondering if we should bring it up with the team about the error message in the future. Even with the hyperlink I think the message doesn't look consistent with the rest of Kibana. |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Jul 20, 2020
alvarezmelissa87
added a commit
that referenced
this pull request
Jul 20, 2020
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Jul 20, 2020
alvarezmelissa87
added a commit
that referenced
this pull request
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR checks for the
click here to recreate itprompt returned in the error message when an index pattern cannot be found. If that prompt is present, the message is converted into a link to allow the user to click on the message and move to index management.Before (user unable to interact with click prompt):
After:
NOTE:
For some context, that
click herebit is part of theSavedObjectNotFoundkibana error class (src/plugins/kibana_utils/common/errors/errors.ts). I'm not sure as to why we've got a click prompt in the returned error message but will get some info - for now, this change should solve the immediate issue.Before:
Checklist
Delete any items that are not applicable to this PR.