Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Improve language for mvt card #71947

Merged
merged 2 commits into from
Jul 16, 2020
Merged

[Maps] Improve language for mvt card #71947

merged 2 commits into from
Jul 16, 2020

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Jul 15, 2020 •
edited
Loading

Improve language in the layer-wizard.

  • .pbf vector tiles -> Vector tiles

Improve language in the source-settings.

  • Tiile layer -> Source layer

@thomasneirynck thomasneirynck added chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.9.0 labels Jul 15, 2020
@thomasneirynck thomasneirynck requested a review from a team as a code owner July 15, 2020 20:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

thomasneirynck
thomasneirynck commented Jul 15, 2020
View reviewed changes
...s/public/classes/sources/mvt_single_layer_vector_source/mvt_single_layer_source_settings.tsx
@@ -133,7 +133,7 @@ export class MVTSingleLayerSourceSettings extends Component<Props, State> {
label={i18n.translate(
'xpack.maps.source.MVTSingleLayerVectorSourceEditor.layerNameMessage',
{
defaultMessage: 'Tile layer',
defaultMessage: 'Source layer',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source layer matches the source-layer naming in the TileJson-spec and it's corresponding use in the mapbox-gl spec.

nreese
nreese reviewed Jul 15, 2020
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also clean up the description? "Data service implementing the Mapbox vector tile specification" is a little wordy. How about "Mapbox vector tile service" or something like that?

@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Jul 15, 2020 •
edited
Loading

Mapbox vector tile service

The only thing that worries me about this is that it would imply that it needs to be a service hosted by mapbox created from their Cloud product

It works with any service (e.g. geoserver, arcgis server, ...)

nreese
nreese approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review

kmartastic
kmartastic reviewed Jul 15, 2020
View reviewed changes
...aps/public/classes/sources/mvt_single_layer_vector_source/mvt_single_layer_vector_source.tsx
@@ -32,7 +32,7 @@ import { ITooltipProperty, TooltipProperty } from '../../tooltips/tooltip_proper
export const sourceTitle = i18n.translate(
'xpack.maps.source.MVTSingleLayerVectorSource.sourceTitle',
{
defaultMessage: '.pbf vector tiles',
defaultMessage: 'Vector tiles',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this text.

@thomasneirynck thomasneirynck added the bug Fixes for quality problems that affect the customer experience label Jul 15, 2020
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / kibana-xpack-agent / X-Pack Endpoint Functional Tests.x-pack/test/security_solution_endpoint/apps/endpoint/policy_list·ts.endpoint When on the Endpoint Policy List and user clicks on page header create button should redirect to ingest management integrations add package config

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/71951

[00:00:00]       │
[00:00:00]         └-: endpoint
[00:00:00]           └-> "before all" hook
[00:00:00]           └-> "before all" hook
[00:00:00]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] [logs-index_pattern_placeholder] creating index, cause [api], templates [], shards [1]/[1]
[00:00:00]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] [metrics-index_pattern_placeholder] creating index, cause [api], templates [], shards [1]/[1]
[00:00:00]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] [events-index_pattern_placeholder] creating index, cause [api], templates [], shards [1]/[1]
[00:00:02]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] [.kibana_1/qWua8B2uTpKwampFQm_x1g] update_mapping [_doc]
[00:00:02]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] [.kibana_1/qWua8B2uTpKwampFQm_x1g] update_mapping [_doc]
[00:00:02]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] [.kibana_1/qWua8B2uTpKwampFQm_x1g] update_mapping [_doc]
[00:00:03]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] [.kibana_1/qWua8B2uTpKwampFQm_x1g] update_mapping [_doc]
[00:00:03]             │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] adding component template [metrics-endpoint.metadata-mappings]
[00:00:03]             │ proc [kibana]  error  [22:44:28.766] [warning][process] UnhandledPromiseRejectionWarning: Error: [epm-packages:system]: version conflict, required seqNo [91], primary term [1]. current document has seqNo [97] and primary term [1]: [version_conflict_engine_exception] [epm-packages:system]: version conflict, required seqNo [91], primary term [1]. current document has seqNo [97] and primary term [1], with { index_uuid="qWua8B2uTpKwampFQm_x1g" & shard="0" & index=".kibana_1" }
[00:00:03]             │ proc [kibana]     at respond (/dev/shm/workspace/install/kibana-8/node_modules/elasticsearch/src/lib/transport.js:349:15)
[00:00:03]             │ proc [kibana]     at checkRespForFailure (/dev/shm/workspace/install/kibana-8/node_modules/elasticsearch/src/lib/transport.js:306:7)
[00:00:03]             │ proc [kibana]     at HttpConnector.<anonymous> (/dev/shm/workspace/install/kibana-8/node_modules/elasticsearch/src/lib/connectors/http.js:173:7)
[00:00:03]             │ proc [kibana]     at IncomingMessage.wrapper (/dev/shm/workspace/install/kibana-8/node_modules/lodash/lodash.js:4929:19)
[00:00:03]             │ proc [kibana]     at IncomingMessage.emit (events.js:203:15)
[00:00:03]             │ proc [kibana]     at endReadableNT (_stream_readable.js:1145:12)
[00:00:03]             │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:63:19)
[00:00:03]             │ proc [kibana]     at emitWarning (internal/process/promises.js:97:15)
[00:00:03]             │ proc [kibana]     at emitPromiseRejectionWarnings (internal/process/promises.js:143:7)
[00:00:03]             │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:69:34)
[00:00:03]             │ proc [kibana]  error  [22:44:28.768] [warning][process] Error: [epm-packages:system]: version conflict, required seqNo [91], primary term [1]. current document has seqNo [97] and primary term [1]: [version_conflict_engine_exception] [epm-packages:system]: version conflict, required seqNo [91], primary term [1]. current document has seqNo [97] and primary term [1], with { index_uuid="qWua8B2uTpKwampFQm_x1g" & shard="0" & index=".kibana_1" }
[00:00:03]             │ proc [kibana]     at respond (/dev/shm/workspace/install/kibana-8/node_modules/elasticsearch/src/lib/transport.js:349:15)
[00:00:03]             │ proc [kibana]     at checkRespForFailure (/dev/shm/workspace/install/kibana-8/node_modules/elasticsearch/src/lib/transport.js:306:7)
[00:00:03]             │ proc [kibana]     at HttpConnector.<anonymous> (/dev/shm/workspace/install/kibana-8/node_modules/elasticsearch/src/lib/connectors/http.js:173:7)
[00:00:03]             │ proc [kibana]     at IncomingMessage.wrapper (/dev/shm/workspace/install/kibana-8/node_modules/lodash/lodash.js:4929:19)
[00:00:03]             │ proc [kibana]     at IncomingMessage.emit (events.js:203:15)
[00:00:03]             │ proc [kibana]     at endReadableNT (_stream_readable.js:1145:12)
[00:00:03]             │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:63:19)
[00:00:03]             │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] adding component template [logs-endpoint.events.library-mappings]
[00:00:03]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] added role [fleet_enroll]
[00:00:03]             │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] adding component template [logs-endpoint.alerts-mappings]
[00:00:03]             │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] adding component template [logs-endpoint.events.file-mappings]
[00:00:03]             │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] adding component template [logs-endpoint.events.network-mappings]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] added user [fleet_enroll]
[00:00:03]             │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] adding component template [logs-endpoint.events.security-mappings]
[00:00:03]             │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] adding component template [metrics-endpoint.telemetry-mappings]
[00:00:03]             │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] adding component template [metrics-endpoint.policy-mappings]
[00:00:03]             │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] adding component template [logs-endpoint.events.registry-mappings]
[00:00:03]             │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] adding component template [logs-endpoint.events.process-mappings]
[00:00:03]             │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] adding index template [metrics-endpoint.metadata] for index patterns [metrics-endpoint.metadata-*]
[00:00:03]             │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] adding index template [logs-endpoint.events.library] for index patterns [logs-endpoint.events.library-*]
[00:00:03]             │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] adding index template [logs-endpoint.alerts] for index patterns [logs-endpoint.alerts-*]
[00:00:03]             │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] adding index template [logs-endpoint.events.file] for index patterns [logs-endpoint.events.file-*]
[00:00:03]             │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] adding index template [logs-endpoint.events.network] for index patterns [logs-endpoint.events.network-*]
[00:00:03]             │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] adding index template [logs-endpoint.events.security] for index patterns [logs-endpoint.events.security-*]
[00:00:03]             │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] adding index template [metrics-endpoint.telemetry] for index patterns [metrics-endpoint.telemetry-*]
[00:00:04]             │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] adding index template [metrics-endpoint.policy] for index patterns [metrics-endpoint.policy-*]
[00:00:04]             │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] adding index template [logs-endpoint.events.registry] for index patterns [logs-endpoint.events.registry-*]
[00:00:04]             │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1594847747057388557] adding index template [logs-endpoint.events.process] for index patterns [logs-endpoint.events.process-*]
[00:00:23]           └-: When on the Endpoint Policy List
[00:00:23]             └-> "before all" hook
[00:00:23]             └-> "before all" hook
[00:00:23]               │ debg navigateToActualUrl http://localhost:6181/app/security/administration/policy
[00:00:23]               │ debg browser[INFO] http://localhost:6181/app/security/administration/policy?_t=1594853088483 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:23]               │
[00:00:23]               │ debg browser[INFO] http://localhost:6181/bundles/app/core/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:23]               │ debg currentUrl = http://localhost:6181/app/security/administration/policy
[00:00:23]               │          appUrl = http://localhost:6181/app/security/administration/policy
[00:00:23]               │ debg TestSubjects.find(kibanaChrome)
[00:00:23]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:00:25]               │ debg isGlobalLoadingIndicatorVisible
[00:00:25]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:00:25]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:00:25]               │ debg browser[INFO] http://localhost:6181/34786/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 452:106112 "INFO: 2020-07-15T22:44:49Z
[00:00:25]               │        Adding connection to http://localhost:6181/elasticsearch
[00:00:25]               │
[00:00:25]               │      "
[00:00:25]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:00:25]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:00:25]               │ERROR browser[SEVERE] http://localhost:6181/api/detection_engine/index - Failed to load resource: the server responded with a status of 404 (Not Found)
[00:00:25]             └-> loads the Policy List Page
[00:00:25]               └-> "before each" hook: global before each
[00:00:25]               │ debg TestSubjects.exists(policyListPage)
[00:00:25]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="policyListPage"]') with timeout=120000
[00:00:25]               └- ✓ pass  (32ms) "endpoint When on the Endpoint Policy List loads the Policy List Page"
[00:00:25]             └-> displays page title
[00:00:25]               └-> "before each" hook: global before each
[00:00:25]               │ debg TestSubjects.getVisibleText(pageViewHeaderLeftTitle)
[00:00:25]               │ debg TestSubjects.find(pageViewHeaderLeftTitle)
[00:00:25]               │ debg Find.findByCssSelector('[data-test-subj="pageViewHeaderLeftTitle"]') with timeout=10000
[00:00:25]               └- ✓ pass  (26ms) "endpoint When on the Endpoint Policy List displays page title"
[00:00:25]             └-> shows header create policy button
[00:00:25]               └-> "before each" hook: global before each
[00:00:25]               │ debg TestSubjects.getVisibleText(headerCreateNewPolicyButton)
[00:00:25]               │ debg TestSubjects.find(headerCreateNewPolicyButton)
[00:00:25]               │ debg Find.findByCssSelector('[data-test-subj="headerCreateNewPolicyButton"]') with timeout=10000
[00:00:25]               └- ✓ pass  (34ms) "endpoint When on the Endpoint Policy List shows header create policy button"
[00:00:25]             └-> shows empty state
[00:00:25]               └-> "before each" hook: global before each
[00:00:25]               │ debg TestSubjects.exists(emptyPolicyTable)
[00:00:25]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="emptyPolicyTable"]') with timeout=120000
[00:00:26]               └- ✓ pass  (28ms) "endpoint When on the Endpoint Policy List shows empty state"
[00:00:26]             └-: and policies exists
[00:00:26]               └-> "before all" hook
[00:00:26]               └-> "before all" hook
[00:00:27]                 │ info Setting up call to retrieve Endpoint package from /api/ingest_manager/epm/packages?category=security
[00:00:31]                 │ proc [kibana]   log   [22:44:56.799] [info][plugins][plugins][securitySolution][securitySolution] Committed manifest WzAsMF0=
[00:00:33]                 │ debg navigateToActualUrl http://localhost:6181/app/security/administration/policy
[00:00:33]                 │ debg browser[INFO] http://localhost:6181/app/security/administration/policy?_t=1594853098857 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:33]                 │
[00:00:33]                 │ debg browser[INFO] http://localhost:6181/bundles/app/core/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:33]                 │ debg currentUrl = http://localhost:6181/app/security/administration/policy
[00:00:33]                 │          appUrl = http://localhost:6181/app/security/administration/policy
[00:00:33]                 │ debg TestSubjects.find(kibanaChrome)
[00:00:33]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:00:35]                 │ debg isGlobalLoadingIndicatorVisible
[00:00:35]                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:00:35]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:00:35]                 │ debg browser[INFO] http://localhost:6181/34786/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 452:106112 "INFO: 2020-07-15T22:45:00Z
[00:00:35]                 │        Adding connection to http://localhost:6181/elasticsearch
[00:00:35]                 │
[00:00:35]                 │      "
[00:00:35]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:00:35]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:00:36]                 │ERROR browser[SEVERE] http://localhost:6181/api/detection_engine/index - Failed to load resource: the server responded with a status of 404 (Not Found)
[00:00:36]                 │ debg Waiting up to 2000ms for table to have data...
[00:00:36]                 │ debg TestSubjects.exists(policyTable)
[00:00:36]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="policyTable"]') with timeout=2500
[00:00:36]                 │ debg TestSubjects.find(policyTable)
[00:00:36]                 │ debg Find.findByCssSelector('[data-test-subj="policyTable"]') with timeout=10000
[00:00:43]             └-: and user clicks on page header create button
[00:00:43]               └-> "before all" hook
[00:00:43]               └-> should redirect to ingest management integrations add package config
[00:00:43]                 └-> "before each" hook: global before each
[00:00:43]                 └-> "before each" hook
[00:00:43]                   │ debg navigateToActualUrl http://localhost:6181/app/security/administration/policy
[00:00:43]                   │ debg browser[INFO] http://localhost:6181/app/security/administration/policy?_t=1594853109044 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:43]                   │
[00:00:43]                   │ debg browser[INFO] http://localhost:6181/bundles/app/core/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:43]                   │ debg currentUrl = http://localhost:6181/app/security/administration/policy
[00:00:43]                   │          appUrl = http://localhost:6181/app/security/administration/policy
[00:00:43]                   │ debg TestSubjects.find(kibanaChrome)
[00:00:43]                   │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:00:45]                   │ debg isGlobalLoadingIndicatorVisible
[00:00:45]                   │ debg TestSubjects.exists(globalLoadingIndicator)
[00:00:45]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:00:45]                   │ debg browser[INFO] http://localhost:6181/34786/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 452:106112 "INFO: 2020-07-15T22:45:10Z
[00:00:45]                   │        Adding connection to http://localhost:6181/elasticsearch
[00:00:45]                   │
[00:00:45]                   │      "
[00:00:45]                   │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:00:45]                   │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:00:46]                   │ERROR browser[SEVERE] http://localhost:6181/api/detection_engine/index - Failed to load resource: the server responded with a status of 404 (Not Found)
[00:00:46]                   │ debg TestSubjects.find(headerCreateNewPolicyButton)
[00:00:46]                   │ debg Find.findByCssSelector('[data-test-subj="headerCreateNewPolicyButton"]') with timeout=10000
[00:00:46]                   │ debg TestSubjects.find(headerCreateNewPolicyButton)
[00:00:46]                   │ debg Find.findByCssSelector('[data-test-subj="headerCreateNewPolicyButton"]') with timeout=10000
[00:00:46]                 │ debg TestSubjects.exists(createPackageConfig_header)
[00:00:46]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="createPackageConfig_header"]') with timeout=120000
[00:00:46]                 │ proc [kibana]   log   [22:45:11.941] [error][ingestManager][plugins] [epm-packages:system]: version conflict, required seqNo [91], primary term [1]. current document has seqNo [97] and primary term [1]: [version_conflict_engine_exception] [epm-packages:system]: version conflict, required seqNo [91], primary term [1]. current document has seqNo [97] and primary term [1], with { index_uuid="qWua8B2uTpKwampFQm_x1g" & shard="0" & index=".kibana_1" }
[00:00:46]                 │ proc [kibana]  error  [22:45:11.962] [warning][process] PromiseRejectionHandledWarning: Promise rejection was handled asynchronously (rejection id: 1)
[00:00:46]                 │ proc [kibana]     at handledRejection (internal/process/promises.js:71:23)
[00:00:46]                 │ proc [kibana]     at promiseRejectHandler (internal/process/promises.js:36:14)
[00:00:46]                 │ proc [kibana]     at Promise.then (<anonymous>)
[00:00:46]                 │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:68:7)
[00:00:48]                 │ERROR browser[SEVERE] http://localhost:6181/api/ingest_manager/setup - Failed to load resource: the server responded with a status of 409 (Conflict)
[00:00:48]                 │ debg --- retry.tryForTime error: [data-test-subj="createPackageConfig_header"] is not displayed
[00:00:51]                 │ debg --- retry.tryForTime failed again with the same message...
[00:00:54]                 │ debg --- retry.tryForTime failed again with the same message...
[00:00:58]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:01]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:04]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:07]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:10]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:13]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:16]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:19]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:22]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:25]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:28]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:31]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:34]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:37]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:40]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:43]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:46]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:49]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:52]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:55]                 │ debg --- retry.tryForTime failed again with the same message...
[00:01:58]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:01]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:04]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:08]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:11]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:14]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:17]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:20]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:23]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:26]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:29]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:32]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:35]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:38]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:41]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:44]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:47]                 │ debg --- retry.tryForTime failed again with the same message...
[00:02:48]                 │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/endpoint When on the Endpoint Policy List and user clicks on page header create button should redirect to ingest management integrations add package config.png"
[00:02:48]                 │ info Current URL is: http://localhost:6181/app/ingestManager#/integrations/endpoint-0.9.0/add-integration
[00:02:48]                 │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/endpoint When on the Endpoint Policy List and user clicks on page header create button should redirect to ingest management integrations add package config.html
[00:02:48]                 └- ✖ fail: endpoint When on the Endpoint Policy List and user clicks on page header create button should redirect to ingest management integrations add package config
[00:02:48]                 │      Error: expected testSubject(createPackageConfig_header) to exist
[00:02:48]                 │       at TestSubjects.existOrFail (/dev/shm/workspace/kibana/test/functional/services/common/test_subjects.ts:62:15)
[00:02:48]                 │ 
[00:02:48]                 │

Stack Trace

Error: expected testSubject(createPackageConfig_header) to exist
    at TestSubjects.existOrFail (/dev/shm/workspace/kibana/test/functional/services/common/test_subjects.ts:62:15)

Build metrics

async chunks size

id value diff baseline
maps 5.2MB +200.0B 5.2MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomasneirynck thomasneirynck merged commit 06355e8 into elastic:master Jul 16, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 16, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
a6989b5 
* master: (37 commits)
  [Lens] Handle failing existence check (elastic#70718)
  [Security Solution]Fix in-app links and popup window text (elastic#71403)
  [esArchiver] automatically retry if alias creation fails (elastic#71910)
  Move data stream index pattern creation test to xpack (elastic#71511)
  [Maps] Improve language for mvt card (elastic#71947)
  [Security][Detections] Unskip failing modal tests (elastic#71969)
  skip flaky suite (elastic#71987)
  skip flaky suite (elastic#71979)
  [Security Solution] [Detections] Revert "[Security Solution] [Detections] Fixes bug for determining when we hit max signals after filtering with lists (elastic#71768)" (elastic#71956)
  rename ilm policy to remove -default (elastic#71952)
  Adjust ordering of Management category apps to make Ingest Manager higher (elastic#71948)
  skip flaky suite (elastic#71971)
  skip flaky suite (elastic#71951)
  [kbn/optimizer] ignore compressed files when reporting stats (elastic#71940)
  skip flaky suite (elastic#71867)
  [ML] Fix new job with must_not saved search (elastic#71831)
  [Resolver] Fix bug where process detail panel doesn't show up (elastic#71754)
  Cleanup (elastic#71849)
  [Resolver] aria-level and aria-flowto support enhancements (elastic#71887)
  skip flaky suite (elastic#71304)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 16, 2020
@gmmorris
Merge branch 'alerting/consumer-based-rbac' into alerting/management-…
47a4b93 
…feature-privileges

* alerting/consumer-based-rbac: (491 commits)
  [Lens] Handle failing existence check (elastic#70718)
  [Security Solution]Fix in-app links and popup window text (elastic#71403)
  [esArchiver] automatically retry if alias creation fails (elastic#71910)
  Move data stream index pattern creation test to xpack (elastic#71511)
  [Maps] Improve language for mvt card (elastic#71947)
  [Security][Detections] Unskip failing modal tests (elastic#71969)
  skip flaky suite (elastic#71987)
  skip flaky suite (elastic#71979)
  [Security Solution] [Detections] Revert "[Security Solution] [Detections] Fixes bug for determining when we hit max signals after filtering with lists (elastic#71768)" (elastic#71956)
  rename ilm policy to remove -default (elastic#71952)
  Adjust ordering of Management category apps to make Ingest Manager higher (elastic#71948)
  skip flaky suite (elastic#71971)
  skip flaky suite (elastic#71951)
  [kbn/optimizer] ignore compressed files when reporting stats (elastic#71940)
  skip flaky suite (elastic#71867)
  [ML] Fix new job with must_not saved search (elastic#71831)
  [Resolver] Fix bug where process detail panel doesn't show up (elastic#71754)
  Cleanup (elastic#71849)
  [Resolver] aria-level and aria-flowto support enhancements (elastic#71887)
  skip flaky suite (elastic#71304)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 20, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 71947 or prevent reminders by adding the backport:skip label.

5 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 71947 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 71947 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 71947 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 71947 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 71947 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 71947 or prevent reminders by adding the backport:skip label.

4 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 71947 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 71947 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 71947 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 71947 or prevent reminders by adding the backport:skip label.

This was referenced Aug 3, 2020
Merged
Merged
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Aug 3, 2020
@thomasneirynck
[Maps] Improve language for mvt card (elastic#71947)
697c66b 
This reduces ambiguity about the source type.
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Aug 3, 2020
@thomasneirynck
[Maps] Improve language for mvt card (elastic#71947)
1e831a5 
This reduces ambiguity about the source type.
thomasneirynck added a commit that referenced this pull request Aug 3, 2020
@thomasneirynck
[Maps] Improve language for mvt card (#71947) (#74080)
a761694 
This reduces ambiguity about the source type.
thomasneirynck added a commit that referenced this pull request Aug 3, 2020
@thomasneirynck
[Maps] Improve language for mvt card (#71947) (#74081)
f20a21a 
This reduces ambiguity about the source type.
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmartastic kmartastic kmartastic left review comments

@nreese nreese nreese approved these changes

@kindsun kindsun Awaiting requested review from kindsun

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thomasneirynck @elasticmachine @kibanamachine @nreese @kmartastic