[Security Solution][Detections] Associate Endpoint Exceptions List to Rule during rule creation/update #71794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works on creation, now we need edit.
EuiText generates a div, but this is inside of an EuiCard which is a paragraph. Defines a span with equivalent styles, instead.
rylnd
changed the title
|
@benskelker this adds the "Associate Global Endpoint Exception List" option to rule creation/update. |
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/siem (Team:SIEM) |
spong
reviewed
Jul 15, 2020
| @@ -83,7 +83,7 @@ const NO_LEGEND_DATA: LegendItem[] = []; | |||
| export const AlertsHistogramPanel = memo<AlertsHistogramPanelProps>( | |||
| ({ | |||
| chartHeight, | |||
| defaultStackByOption = alertsHistogramOptions[0], | |||
| defaultStackByOption = alertsHistogramOptions[8], // signal.rule.name | |||
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 15, 2020
* master: (82 commits) Fixed the spacing of child accordion items for policy response dialog. (elastic#71677) [SECURITY] Timeline bug 7.9 (elastic#71748) use fixed isChromeVisible method (elastic#71813) [SIEM][Detection Engine][Lists] Adds specific endpoint_list REST API and API for abilities to auto-create the endpoint_list if it gets deleted (elastic#71792) [test] Skips flaky Saved Objects Management test [APM] Remove watcher integration (elastic#71655) [APM] Increase `xpack.apm.ui.transactionGroupBucketSize` (elastic#71661) [test] Skips Ingest Manager test preventing ES promotion [test] Skips flaky detection engine tests Revert "re-fix navigate path for master add SAML login to login_page (elastic#71337)" [tests] Temporarily skipped Fleet tests [test] Skipped monitoring test [Security Solution][Detections] Associate Endpoint Exceptions List to Rule during rule creation/update (elastic#71794) Add endpoint exception creation API validation (elastic#71791) Skip jest tests that timeout waiting for react (elastic#71801) [Security Solution][Exceptions] - Adds filtering to endpoint index patterns by exceptional fields (elastic#71757) [Reporting] Re-delete a file (elastic#71730) [Security Solution] [Detections] Fixes bug for determining when we hit max signals after filtering with lists (elastic#71768) [Ingest Manager] Better display of Fleet requirements (elastic#71686) [tests] Temporarily skipped to promote snapshot ...
cnasikas
pushed a commit
that referenced
this pull request
Jul 15, 2020
…ist to Rule during rule creation/update (#71794) (#71806) Co-authored-by: Elastic Machine <[email protected]>
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the following:
signal.rule.nameTODO
Followup Actions:
'endpoint_list') with common constant from [SIEM][Detection Engine][Lists] Adds specific endpoint_list REST API and API for abilities to auto-create the endpoint_list if it gets deleted #71792For maintainers