[DOCS] Fixes to API docs #71678
Merged
[DOCS] Fixes to API docs #71678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KOTungseth
added
Team:Docs
release_note:skip
|
Pinging @elastic/kibana-docs (Team:Docs) |
bmorelli25
requested changes
Jul 14, 2020
There was a problem hiding this comment.
Most of these look good. The using-api with USER/PASS specified doesn't work for me though. For reference, I have the following set:
Kibana URL: http://localhost:5601
Kibana host: localhost:5601
Kibana user: admin
When I hit the copy as CURL button on this page https://kibana_71678.docs-preview.app.elstc.co/guide/en/kibana/master/using-api.html, it creates this:
curl -X POST -u admin:$KIBANAPASS "localhost:5601/-u api/kibana/dashboards/export?dashboard=942dcef0-b2cd-11e8-ad8e-85441f0c2e5c" -H 'kbn-xsrf: true'
There's a weird -u floating in the middle of the endpoint URL
KOTungseth
added a commit
to KOTungseth/kibana
that referenced
this pull request
Jul 14, 2020
* [DOCS] Fixes to API docs * Fixes rogue -u
KOTungseth
added a commit
to KOTungseth/kibana
that referenced
this pull request
Jul 14, 2020
* [DOCS] Fixes to API docs * Fixes rogue -u
KOTungseth
added a commit
to KOTungseth/kibana
that referenced
this pull request
Jul 14, 2020
* [DOCS] Fixes to API docs * Fixes rogue -u # Conflicts: # docs/api/saved-objects/create.asciidoc # docs/api/saved-objects/export.asciidoc
KOTungseth
added a commit
to KOTungseth/kibana
that referenced
this pull request
Jul 14, 2020
* [DOCS] Fixes to API docs * Fixes rogue -u # Conflicts: # docs/api/saved-objects/create.asciidoc # docs/api/saved-objects/export.asciidoc # docs/api/upgrade-assistant/batch_reindexing.asciidoc
KOTungseth
added a commit
to KOTungseth/kibana
that referenced
this pull request
Jul 14, 2020
* [DOCS] Fixes to API docs * Fixes rogue -u # Conflicts: # docs/api/saved-objects/create.asciidoc # docs/api/saved-objects/export.asciidoc # docs/api/upgrade-assistant/batch_reindexing.asciidoc
KOTungseth
added a commit
that referenced
this pull request
Jul 14, 2020
KOTungseth
added a commit
that referenced
this pull request
Jul 14, 2020
KOTungseth
added a commit
that referenced
this pull request
Jul 14, 2020
KOTungseth
added a commit
that referenced
this pull request
Jul 14, 2020
KOTungseth
added a commit
that referenced
this pull request
Jul 14, 2020
* [DOCS] Fixes to API docs * Fixes rogue -u # Conflicts: # docs/api/saved-objects/create.asciidoc # docs/api/saved-objects/export.asciidoc # docs/api/upgrade-assistant/batch_reindexing.asciidoc Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Docs preview
Closes #71200
Closes #69792
Closes #67107
Checklist