[Security Solution][Detections] Update telemetry to use ML contract #71665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This interface recently changed and we're now able to use the ML contract to retrieve these values. A few unnecessary arguments are stubbed as we're in a non-user, non-request context.
rylnd
added
Team:SIEM
v8.0.0
release_note:skip
Conflicts: x-pack/plugins/ml/server/shared_services/providers/modules.ts x-pack/plugins/security_solution/server/usage/detections/detections_helpers.ts
|
Pinging @elastic/siem (Team:SIEM) |
This is more legible but still gets the point across; the intermediate variable was explicit but ultimately unnnecessary.
We're not calling different methods, so our mocks need to change slightly.
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
| @@ -40,8 +41,14 @@ export function getModulesProvider({ | |||
| request: KibanaRequest, | |||
| savedObjectsClient: SavedObjectsClientContract | |||
| ) { | |||
| const hasMlCapabilities = getHasMlCapabilities(request); | |||
| let hasMlCapabilities: HasMlCapabilities; | |||
| if (request.params === 'DummyKibanaRequest') { | |||
There was a problem hiding this comment.
I would just make DummyKibanaRequest a shared constant somewhere so someone doesn't accidentally break this in the future 😂
There was a problem hiding this comment.
Yeah... uptime is doing something similar as well. We want to be consistent while discouraging this temporary workaround... if it's used in a third place maybe we move it upstream into getHasMlCapabilities.
michaelolo24
approved these changes
Jul 14, 2020
rylnd
added a commit
to rylnd/kibana
that referenced
this pull request
Jul 14, 2020
…lastic#71665) * Update security solution telemetry to use ML providers This interface recently changed and we're now able to use the ML contract to retrieve these values. A few unnecessary arguments are stubbed as we're in a non-user, non-request context. * Simplify our capabilities stub assignment This is more legible but still gets the point across; the intermediate variable was explicit but ultimately unnnecessary. * Update tests following telemetry refactor We're not calling different methods, so our mocks need to change slightly.
rylnd
added a commit
that referenced
this pull request
Jul 14, 2020
…71665) (#71733) * Update security solution telemetry to use ML providers This interface recently changed and we're now able to use the ML contract to retrieve these values. A few unnecessary arguments are stubbed as we're in a non-user, non-request context. * Simplify our capabilities stub assignment This is more legible but still gets the point across; the intermediate variable was explicit but ultimately unnnecessary. * Update tests following telemetry refactor We're not calling different methods, so our mocks need to change slightly.
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This interface recently changed and we're now able to use the ML contract to retrieve these values. A few unnecessary arguments are stubbed as we're in a non-user, non-request context.
For maintainers