Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY_SOLUTION] add onboarding logo #71471

Merged
merged 4 commits into from
Jul 13, 2020

Conversation

kevinlog
Copy link
Contributor

@kevinlog kevinlog commented Jul 13, 2020

Summary

Adds the onboarding logo to the experience.

Also, update text in Onboarding and Announcement banner

image

image

Checklist

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-management (Team:Endpoint Management)

@kevinlog kevinlog added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0 labels Jul 13, 2020
Copy link
Member

@pzl pzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paul-tavares
Copy link
Contributor

@kevinlog If you get a chance, can you post a screen capture of what it looks like in a narrower screen? I assume (based on the code) that the image move to be under the get started instructions - right?

@kevinlog
Copy link
Contributor Author

If you get a chance, can you post a screen capture of what it looks like in a narrower screen? I assume (based on the code) that the image move to be under the get started instructions - right?

@paul-tavares that is correct.

here's what it looks like

image

image

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
securitySolution 823 +1 822

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kevinlog kevinlog merged commit 00f03fb into elastic:master Jul 13, 2020
@kevinlog kevinlog deleted the task/add-onboarding-logo branch July 13, 2020 23:36
kevinlog added a commit to kevinlog/kibana that referenced this pull request Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants