Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds structured inputs for editable filters #7114

Conversation

tylersmalley
Copy link
Contributor

screenshot 2016-05-02 14 01 20

@tylersmalley tylersmalley self-assigned this May 2, 2016
@tylersmalley tylersmalley force-pushed the 5249-editable-filters-vertical branch 2 times, most recently from 12ed94b to 073ef9e Compare May 2, 2016 23:15
@tylersmalley tylersmalley force-pushed the 5249-editable-filters-vertical branch from 073ef9e to 11af8d0 Compare May 2, 2016 23:16
@tylersmalley tylersmalley changed the title WIP: Adds structured inputs for editable filters Adds structured inputs for editable filters May 2, 2016
@tylersmalley
Copy link
Contributor Author

tylersmalley commented May 2, 2016

This PR addresses #5249 and #1583

@tylersmalley
Copy link
Contributor Author

Interested in feedback regarding the UI. Especially around the experience for users not familiar with the ES API.

@alt74
Copy link

alt74 commented May 3, 2016

cool! @tylersmalley let's look at the tab styling together and fine tune things as you go...

@rashidkpc
Copy link
Contributor

This is a good phase 1, but I think we need to work through the user experience and technical consideration before we put it into a release. The JSONification of the filter display after editing isn't ideal and I'd personally like to move this further away from the Elasticsearch API.

Currently our filters, which we persist, are really closely bound to the ES API. This becomes a big problem when ES changes the API. I think we need to design a layer that exists at a higher level that we can translate to ES filters at request time.

We might also need to look at examples of other systems for visual search request building. The must, must_not, should thing is confusing for anything aside from traditional search scoring. For example simple things like

(foo AND bar) OR (baz and bees)

don't fit the must, must_not, should without creating more levels to the filter.

@rashidkpc
Copy link
Contributor

@tbragin can I get your opinion on this? I think we should look at some other interactions here. Maybe we can look at some of the demo systems you've setup?

@rashidkpc rashidkpc assigned tbragin and unassigned rashidkpc May 9, 2016
@epixa
Copy link
Contributor

epixa commented May 10, 2016

We should be careful about the differences between UX improvements on the feature itself and fundamental problems in Kibana that are true regardless of whether structured filters are in place. Both are important, but unless our structured filters approach actually puts us further away from redoing how we handle filters as a whole, we should treat them as separate problems.

@epixa epixa added v5.0.0 and removed v5.0.0-beta1 labels May 18, 2016
@epixa epixa assigned tylersmalley and unassigned tbragin Aug 20, 2016
@epixa
Copy link
Contributor

epixa commented Aug 20, 2016

@tylersmalley Do you have time to take this back up as bit of a secondary project? If not, I'd like to put an adoptme label on it and have someone else jump on it.

@epixa epixa removed the v5.0.0 label Aug 20, 2016
@epixa epixa added the help wanted adoptme label Oct 8, 2016
@epixa
Copy link
Contributor

epixa commented Oct 8, 2016

@tylersmalley I unassigned you and am throwing an adoptme label on this in case someone else wants to/has time to pull it over the line.

@lukasolson lukasolson self-assigned this Nov 4, 2016
@lukasolson
Copy link
Member

From what I can tell, this seems to still be functioning after merging with master. I don't see any concrete feedback except that we need to discuss what should be updated. I've decided to take this on, and I'm wondering what exactly we think needs to change on this before releasing it.

@lukasolson lukasolson added WIP Work in progress and removed help wanted adoptme labels Nov 16, 2016
@lukasolson
Copy link
Member

Superseded by #9509.

@lukasolson lukasolson closed this Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
updates_needed WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants