-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds structured inputs for editable filters #7114
Adds structured inputs for editable filters #7114
Conversation
tylersmalley
commented
May 2, 2016
12ed94b
to
073ef9e
Compare
Signed-off-by: Tyler Smalley <[email protected]>
073ef9e
to
11af8d0
Compare
Interested in feedback regarding the UI. Especially around the experience for users not familiar with the ES API. |
cool! @tylersmalley let's look at the tab styling together and fine tune things as you go... |
This is a good phase 1, but I think we need to work through the user experience and technical consideration before we put it into a release. The JSONification of the filter display after editing isn't ideal and I'd personally like to move this further away from the Elasticsearch API. Currently our filters, which we persist, are really closely bound to the ES API. This becomes a big problem when ES changes the API. I think we need to design a layer that exists at a higher level that we can translate to ES filters at request time. We might also need to look at examples of other systems for visual search request building. The
don't fit the |
@tbragin can I get your opinion on this? I think we should look at some other interactions here. Maybe we can look at some of the demo systems you've setup? |
We should be careful about the differences between UX improvements on the feature itself and fundamental problems in Kibana that are true regardless of whether structured filters are in place. Both are important, but unless our structured filters approach actually puts us further away from redoing how we handle filters as a whole, we should treat them as separate problems. |
@tylersmalley Do you have time to take this back up as bit of a secondary project? If not, I'd like to put an adoptme label on it and have someone else jump on it. |
@tylersmalley I unassigned you and am throwing an adoptme label on this in case someone else wants to/has time to pull it over the line. |
From what I can tell, this seems to still be functioning after merging with master. I don't see any concrete feedback except that we need to discuss what should be updated. I've decided to take this on, and I'm wondering what exactly we think needs to change on this before releasing it. |
Superseded by #9509. |