Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate service settings test to jest #70992

Merged

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Jul 7, 2020

Migrates the service_settings test to jest. The original Karma test is not being run.

cf. see meta-issue #71002

@thomasneirynck thomasneirynck added the [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation label Jul 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck thomasneirynck requested a review from kindsun July 7, 2020 17:43
@thomasneirynck thomasneirynck added chore release_note:skip Skip the PR/issue when compiling release notes bug Fixes for quality problems that affect the customer experience v6.8.12 v7.8.1 v7.9.0 v8.0.0 v7.8.2 and removed v7.8.1 labels Jul 7, 2020
@thomasneirynck
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Nice swap out karma -> jest. Even better since this will actually run 🤦

  • code review
  • test run locally on command line

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Firefox UI Functional Tests.test/functional/apps/visualize/_tsvb_chart·ts.visualize app visual builder "before each" hook for "should verify gauge label and count display"

Link to Jenkins

Standard Out

[00:00:00]       │
[00:12:13]         └-: visualize app
[00:12:13]           └-> "before all" hook
[00:12:13]           └-> "before all" hook
[00:12:13]             │ debg Starting visualize before method
[00:12:13]             │ info [logstash_functional] Loading "mappings.json"
[00:12:13]             │ info [logstash_functional] Loading "data.json.gz"
[00:12:13]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1594155226860073471] [logstash-2015.09.22] creating index, cause [api], templates [], shards [1]/[0]
[00:12:13]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1594155226860073471] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.22][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.22][0]]"
[00:12:13]             │ info [logstash_functional] Created index "logstash-2015.09.22"
[00:12:13]             │ debg [logstash_functional] "logstash-2015.09.22" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:12:13]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1594155226860073471] [logstash-2015.09.20] creating index, cause [api], templates [], shards [1]/[0]
[00:12:13]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1594155226860073471] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.20][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.20][0]]"
[00:12:13]             │ info [logstash_functional] Created index "logstash-2015.09.20"
[00:12:13]             │ debg [logstash_functional] "logstash-2015.09.20" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:12:13]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1594155226860073471] [logstash-2015.09.21] creating index, cause [api], templates [], shards [1]/[0]
[00:12:13]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1594155226860073471] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.21][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.21][0]]"
[00:12:13]             │ info [logstash_functional] Created index "logstash-2015.09.21"
[00:12:13]             │ debg [logstash_functional] "logstash-2015.09.21" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:12:23]             │ info [logstash_functional] Indexed 4633 docs into "logstash-2015.09.22"
[00:12:23]             │ info [logstash_functional] Indexed 4757 docs into "logstash-2015.09.20"
[00:12:23]             │ info [logstash_functional] Indexed 4614 docs into "logstash-2015.09.21"
[00:12:23]             │ info [long_window_logstash] Loading "mappings.json"
[00:12:23]             │ info [long_window_logstash] Loading "data.json.gz"
[00:12:23]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1594155226860073471] [long-window-logstash-0] creating index, cause [api], templates [], shards [1]/[0]
[00:12:23]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1594155226860073471] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[long-window-logstash-0][0]]])." previous.health="YELLOW" reason="shards started [[long-window-logstash-0][0]]"
[00:12:23]             │ info [long_window_logstash] Created index "long-window-logstash-0"
[00:12:23]             │ debg [long_window_logstash] "long-window-logstash-0" settings {"index":{"analysis":{"analyzer":{"makelogs_url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:12:33]             │ info progress: 12041
[00:12:35]             │ info [long_window_logstash] Indexed 14005 docs into "long-window-logstash-0"
[00:12:35]             │ info [visualize] Loading "mappings.json"
[00:12:35]             │ info [visualize] Loading "data.json"
[00:12:35]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1594155226860073471] [.kibana_2/NFjkIY30Tya2m3WM5-TwRg] deleting index
[00:12:35]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1594155226860073471] [.kibana_1/pTflErtkThiBdK299C-yMA] deleting index
[00:12:35]             │ info [visualize] Deleted existing index [".kibana_2",".kibana_1"]
[00:12:35]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1594155226860073471] [.kibana] creating index, cause [api], templates [], shards [1]/[1]
[00:12:35]             │ info [visualize] Created index ".kibana"
[00:12:35]             │ debg [visualize] ".kibana" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:12:35]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1594155226860073471] [.kibana/RWSfHItBRH6weKrXoWTX0g] update_mapping [_doc]
[00:12:35]             │ info [visualize] Indexed 12 docs into ".kibana"
[00:12:35]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1594155226860073471] [.kibana/RWSfHItBRH6weKrXoWTX0g] update_mapping [_doc]
[00:12:35]             │ debg Migrating saved objects
[00:12:35]             │ proc [kibana]   log   [21:28:26.747] [info][savedobjects-service] Creating index .kibana_2.
[00:12:35]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1594155226860073471] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1]
[00:12:35]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1594155226860073471] updating number_of_replicas to [0] for indices [.kibana_2]
[00:12:35]             │ proc [kibana]   log   [21:28:26.801] [info][savedobjects-service] Reindexing .kibana to .kibana_1
[00:12:35]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1594155226860073471] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1]
[00:12:35]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1594155226860073471] updating number_of_replicas to [0] for indices [.kibana_1]
[00:12:35]             │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-ubuntu-18-tests-xxl-1594155226860073471] 9057 finished with response BulkByScrollResponse[took=47.5ms,timed_out=false,sliceId=null,updated=0,created=12,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:12:36]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1594155226860073471] [.kibana/RWSfHItBRH6weKrXoWTX0g] deleting index
[00:12:36]             │ proc [kibana]   log   [21:28:27.151] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:12:36]             │ proc [kibana]   log   [21:28:27.161] [error][savedobjects-service] Error: Unable to migrate the corrupt Saved Object document index-pattern:test_index*. To prevent Kibana from performing a migration on every restart, please delete or fix this document by ensuring that the namespace and type in the document's id matches the values in the namespace and type fields.
[00:12:36]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1594155226860073471] [.kibana_2/bjNk8a60TIuFv3Ft2vEeJQ] update_mapping [_doc]
[00:12:36]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1594155226860073471] [.kibana_2/bjNk8a60TIuFv3Ft2vEeJQ] update_mapping [_doc]
[00:12:36]             │ proc [kibana]   log   [21:28:27.242] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:12:36]             │ proc [kibana]   log   [21:28:27.286] [info][savedobjects-service] Finished in 541ms.
[00:12:36]             │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:12:36]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1594155226860073471] [.kibana_2/bjNk8a60TIuFv3Ft2vEeJQ] update_mapping [_doc]
[00:12:37]             │ debg replacing kibana config doc: {"defaultIndex":"logstash-*","format:bytes:defaultPattern":"0,0.[000]b"}
[00:13:12]           └-: 
[00:13:12]             └-> "before all" hook
[00:13:12]             └-: visual builder
[00:13:12]               └-> "before all" hook

Stack Trace

Error: retry.try timeout: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="createVisualizationPromptButton"])
Wait timed out after 10011ms
    at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at onFailure (test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (test/common/services/retry/retry_for_success.ts:68:13)
    at onFailure (test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (test/common/services/retry/retry_for_success.ts:68:13)

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomasneirynck thomasneirynck merged commit 7bded17 into elastic:master Jul 8, 2020
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Jul 8, 2020
Karma tests were no longer being run after NP-migration.
thomasneirynck added a commit that referenced this pull request Jul 8, 2020
Karma tests were no longer being run after NP-migration.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 8, 2020
* master: (36 commits)
  fixed api url in example plugin (elastic#70934)
  [data.search.aggs]: Remove remaining client dependencies (elastic#70251)
  [Security Solution][Endpoint] Fix base64 download bug and adopt new user artifact/manifest format (elastic#70998)
  [Security Solution][Exceptions] - Exception Modal Part I (elastic#70639)
  [SIEM][Detection Engine][Lists] Adds additional data types to value based lists
  [SIEM][Detection Engine][Lists] Removes feature flag for lists
  [APM] Show license callout in ML settings (elastic#70959)
  Migrate service settings test to jest (elastic#70992)
  [APM] Add cloud attributes to data telemetry (elastic#71008)
  Fix breadcrumb on panels for visibility / round corners (elastic#71010)
  Improve search typescript (elastic#69333)
  [savedObjects field count] run in baseline job (elastic#70999)
  [Security Solution] [Timeline] Timeline manager tweaks (elastic#69988)
  [Endpoint] Support redirect from Policy Details to Ingest when user initiates Edit Policy from Datasource Edit page (elastic#70874)
  [APM] Add API tests (elastic#70740)
  [Security Solution][Exceptions] - Tie server and client code together (elastic#70918)
  [Audit Logging] Add AuditTrail service (elastic#69278)
  [Usage Collection] Ensure no type duplicates (elastic#70946)
  [Security Solution] [Timeline] Bugfix for timeline row actions disappear sometimes (elastic#70958)
  [CI] Add pipeline task queue framework and merge workers into one (elastic#64011)
  ...
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Jul 8, 2020
Karma tests were no longer being run after NP-migration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v6.8.12 v7.8.2 v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants