Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kbn/optimizer] implement "requiredBundles" property of KP plugins #70910

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jul 7, 2020

Closes #69458

This PR requires that plugin define the bundles which they import from, so that when the bundle for that plugin is loaded we can be certain that the imported-from bundles are loaded even when those plugins are disabled.

When a plugin tries to import from another bundle but the bundle is not mentioned in the kibana.json file the following error will be logged:

import [../../../../../src/plugins/kibana_react/public] references a public export of the [kibanaReact] bundle, but that bundle is not in the "requiredPlugins" or "requiredBundles" list in the plugin manifest [{path to}/kibana.json]

When users fix this problem while running in --watch mode, webpack will notice the change to the kibana.json and rebuild, adapting to changes in kibana.json at runtime without needing to restart the optimizer.

@spalger spalger requested review from a team as code owners July 7, 2020 01:56
@spalger spalger requested a review from a team July 7, 2020 01:56
@spalger spalger requested review from a team as code owners July 7, 2020 01:56
@spalger spalger requested a review from a team July 7, 2020 01:56
@spalger spalger requested review from a team as code owners July 7, 2020 01:56
@spalger spalger requested a review from a team July 7, 2020 01:56
@spalger spalger requested a review from a team as a code owner July 7, 2020 01:56
@botelastic botelastic bot added Feature:Embedding Embedding content via iFrame Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jul 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@spalger spalger closed this Jul 7, 2020
@spalger
Copy link
Contributor Author

spalger commented Jul 7, 2020

Oops, hit cmd+enter :)

@kibanamachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

Build metrics

‼️ metrics were not reported for [#70910@fc44e2b]

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Embedding Embedding content via iFrame Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kbn/optimizer] Only allow refs to bundles described in kibana.json
3 participants