Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] Process long running requests in logs overview #70791

Merged
merged 3 commits into from
Jul 7, 2020

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Jul 6, 2020

Summary

Process long running requests in logs overview when using the data plugin.

@afgomez afgomez requested a review from a team as a code owner July 6, 2020 12:22
@afgomez afgomez added Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 labels Jul 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@jasonrhodes jasonrhodes added this to the Logs UI 7.9 milestone Jul 6, 2020
Copy link
Member

@jasonrhodes jasonrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test this today, thanks for updating!

Copy link
Member

@jasonrhodes jasonrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really test this because I'm not sure how to trigger multiple calls to that initial subscribe callback parameter. No matter how far back I go, I only trigger one call to that method. I've asked @elastic/kibana-app-arch for some guidance in testing this.

UPDATE: We tested this in a zoom call together by using the right combination of a long date range and a 1hr bucket size to avoid the 500 too many buckets error.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@jasonrhodes jasonrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works great.

@afgomez afgomez merged commit e41692e into elastic:master Jul 7, 2020
@afgomez afgomez deleted the log-overview-long-requests branch July 7, 2020 15:42
afgomez pushed a commit to afgomez/kibana that referenced this pull request Jul 9, 2020
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 9, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 10, 2020
afgomez pushed a commit that referenced this pull request Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants