Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Unskips and fixes 'export rule' test #70699

Merged
merged 3 commits into from
Jul 6, 2020
Merged

[SIEM] Unskips and fixes 'export rule' test #70699

merged 3 commits into from
Jul 6, 2020

Conversation

MadameSheema
Copy link
Member

Summary

Unskips and fixes 'export rule' test.

@MadameSheema MadameSheema added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 3, 2020
@MadameSheema MadameSheema requested review from a team as code owners July 3, 2020 10:56
@MadameSheema MadameSheema self-assigned this Jul 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@MadameSheema
Copy link
Member Author

@elasticmachine merge upstream

@MadameSheema
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

rylnd
rylnd approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as the tests are now green, but for posterity: what was the fix, here? What is the difference between these two archives?

@MadameSheema MadameSheema merged commit cd50899 into elastic:master Jul 6, 2020
@MadameSheema MadameSheema deleted the fixes-export-test branch July 6, 2020 19:26
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Jul 7, 2020
@MadameSheema @elasticmachine
fixes and unskips 'export rule' test (elastic#70699)
888cff5 
Co-authored-by: Elastic Machine <[email protected]>
@MadameSheema MadameSheema mentioned this pull request Jul 7, 2020
Merged
MadameSheema added a commit that referenced this pull request Jul 7, 2020
@MadameSheema @elasticmachine
fixes and unskips 'export rule' test (#70699) (#70927)
c42b204 
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylnd rylnd rylnd approved these changes

Assignees

@MadameSheema MadameSheema

Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MadameSheema @elasticmachine @kibanamachine @rylnd @MindyRS