Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] fix unable to edit heatmap metric #70606

Merged
merged 3 commits into from
Jul 2, 2020
Merged

[Maps] fix unable to edit heatmap metric #70606

merged 3 commits into from
Jul 2, 2020

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jul 2, 2020

Fixes #70399

@nreese nreese added release_note:fix [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.9.0 v7.8.1 labels Jul 2, 2020
@nreese nreese requested a review from thomasneirynck July 2, 2020 14:40
@nreese nreese requested a review from a team as a code owner July 2, 2020 14:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

thomasneirynck
thomasneirynck approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

would you mind adding a little comment here, why this normalization is still required

kibana/x-pack/plugins/maps/public/classes/sources/es_agg_source/es_agg_source.js

Lines 51 to 56 in 238e3b4

getMetricFields() {
const metrics = this._metricFields.filter((esAggField) => esAggField.isValid());
return metrics.length === 0
? esAggFieldsFactory({ type: AGG_TYPE.COUNT }, this, this.getOriginForField())
: metrics;
}
?

Since we're fixing this in the descriptor, it might not be clear why that little stub still needs to address two edge-cases:

  • older saved objects that have no metrics configured
  • invalid saved objects that only have invalid metrics

-> we don't want to get into case that Maps issues agg-requests to ES, without a configured metric, so we resolve that on-the-fly there.

@nreese
Copy link
Contributor Author

nreese commented Jul 2, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit e774921 into elastic:master Jul 2, 2020
nreese added a commit to nreese/kibana that referenced this pull request Jul 2, 2020
@nreese @elasticmachine
[Maps] fix unable to edit heatmap metric (elastic#70606)
c50a3bf 
* [Maps] fix unable to edit heatmap metric

* add comment

Co-authored-by: Elastic Machine <[email protected]>
This was referenced Jul 2, 2020
Merged
Merged
nreese added a commit to nreese/kibana that referenced this pull request Jul 2, 2020
@nreese
[Maps] fix unable to edit heatmap metric (elastic#70606)
d201b67 
* [Maps] fix unable to edit heatmap metric

* add comment

Co-authored-by: Elastic Machine <[email protected]>
# Conflicts:
#	x-pack/plugins/maps/public/classes/sources/es_geo_grid_source/es_geo_grid_source.js
#	x-pack/plugins/maps/public/classes/sources/es_pew_pew_source/es_pew_pew_source.js
nreese added a commit that referenced this pull request Jul 3, 2020
@nreese
[7.8] [Maps] fix unable to edit heatmap metric (#70606) (#70660)
3bf5d95 
* [Maps] fix unable to edit heatmap metric (#70606)

* [Maps] fix unable to edit heatmap metric

* add comment

Co-authored-by: Elastic Machine <[email protected]>
# Conflicts:
#	x-pack/plugins/maps/public/classes/sources/es_geo_grid_source/es_geo_grid_source.js
#	x-pack/plugins/maps/public/classes/sources/es_pew_pew_source/es_pew_pew_source.js

* fix import
nreese added a commit that referenced this pull request Jul 3, 2020
@nreese @elasticmachine
[Maps] fix unable to edit heatmap metric (#70606) (#70658)
8488b57 
* [Maps] fix unable to edit heatmap metric

* add comment

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 3, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
e4a16c7 
* master: (32 commits)
  [Ingest Pipelines] Load from json (elastic#70297)
  [Rum Dashbaord] Rum selected service view (elastic#70579)
  [Uptime] Prevent duplicate requests on load for index status (elastic#70585)
  [ML] Changing shared module setup function parameters (elastic#70589)
  [Ingest Manager] Add ability to sort to agent configs and package configs (elastic#70676)
  [Alerting] document requirements for developing new action types (elastic#69164)
  Fixed adding an extra space character on selecting alert variable in action text fields (elastic#70028)
  [Maps] show vector tile labels on top (elastic#69444)
  chore(NA): upgrade to lodash@4 (elastic#69868)
  Add Snapshot Restore README with quick-testing steps. (elastic#70494)
  [EPM] Use higher priority than default templates (elastic#70640)
  [Maps] Fix cannot select Solid fill-color when removing fields (elastic#70621)
  [kbn/optimizer] only build specified themes (elastic#70389)
  Fix saved query modal overlay (elastic#68826)
  Update component templates list to render empty prompt inside of content container. Show detail panel when deep-linked, even if there are no component templates. (elastic#70633)
  [Security Solution] Renames the `Investigate in Resolver` Timeline action (elastic#70634)
  fix 400 error on initial signals search (elastic#70618)
  [Maps] fix unable to edit heatmap metric (elastic#70606)
  Update network idle timeout (elastic#70629)
  [APM] Disable flaky useFetcher test (elastic#70638)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:fix v7.8.1 v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maps] Heatmap layer has no metrics
4 participants
@nreese @elasticmachine @kibanamachine @thomasneirynck