Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics UI] Register function for Observability homepage #70529

Conversation

simianhacker
Copy link
Member

Summary

This PR closes #68532 by creating and registering a functions for the Observability Homepage. The one notable change to the response for fetchData is that I removed the disk stats since we don't have a reliable way to summarize that data.

Checklist

Delete any items that are not applicable to this PR.

@simianhacker simianhacker added Feature:Metrics UI Metrics UI feature Feature:Observability Landing - Milestone 1 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v8.0.0 labels Jul 1, 2020
@simianhacker simianhacker added this to the Metrics UI 7.9 milestone Jul 1, 2020
@simianhacker simianhacker force-pushed the issue-68532-obs-homepage-fn-for-metrics branch from 54dd0c0 to 900f48c Compare July 1, 2020 22:44
@simianhacker simianhacker marked this pull request as ready for review July 2, 2020 01:28
@simianhacker simianhacker requested a review from a team as a code owner July 2, 2020 01:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

Copy link
Member

@jasonrhodes jasonrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested hasData and fetchData both, they work as expected. Tests look good too, nice addition.

@simianhacker
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@simianhacker simianhacker merged commit a3e9f39 into elastic:master Jul 2, 2020
simianhacker added a commit to simianhacker/kibana that referenced this pull request Jul 2, 2020
)

* [Metrics UI] Register function for Observability homepage

* Updating types; removing relative path from appLink

Co-authored-by: Elastic Machine <[email protected]>
simianhacker added a commit that referenced this pull request Jul 2, 2020
…70647)

* [Metrics UI] Register function for Observability homepage

* Updating types; removing relative path from appLink

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
@simianhacker simianhacker deleted the issue-68532-obs-homepage-fn-for-metrics branch April 17, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Metrics UI Metrics UI feature Feature:Observability Landing - Milestone 1 release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metrics UI] Register function(s) for homepage data retrieval
6 participants