-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics UI] Register function for Observability homepage #70529
Merged
simianhacker
merged 3 commits into
elastic:master
from
simianhacker:issue-68532-obs-homepage-fn-for-metrics
Jul 2, 2020
Merged
[Metrics UI] Register function for Observability homepage #70529
simianhacker
merged 3 commits into
elastic:master
from
simianhacker:issue-68532-obs-homepage-fn-for-metrics
Jul 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
added
Feature:Metrics UI
Metrics UI feature
Feature:Observability Landing - Milestone 1
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
v7.9.0
v8.0.0
labels
Jul 1, 2020
simianhacker
force-pushed
the
issue-68532-obs-homepage-fn-for-metrics
branch
from
July 1, 2020 22:44
54dd0c0
to
900f48c
Compare
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
2 tasks
jasonrhodes
approved these changes
Jul 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested hasData and fetchData both, they work as expected. Tests look good too, nice addition.
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Jul 2, 2020
) * [Metrics UI] Register function for Observability homepage * Updating types; removing relative path from appLink Co-authored-by: Elastic Machine <[email protected]>
simianhacker
added a commit
that referenced
this pull request
Jul 2, 2020
…70647) * [Metrics UI] Register function for Observability homepage * Updating types; removing relative path from appLink Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Metrics UI
Metrics UI feature
Feature:Observability Landing - Milestone 1
release_note:enhancement
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
v7.9.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes #68532 by creating and registering a functions for the Observability Homepage. The one notable change to the response for
fetchData
is that I removed thedisk
stats since we don't have a reliable way to summarize that data.Checklist
Delete any items that are not applicable to this PR.