[QA] [Code Coverage] Add Three Dot Compare Url #70525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pass it through to the ingestion, and process it in the itemizeVcs fn.
wayneseymour
added
v8.0.0
release_note:skip
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
brianseeders
approved these changes
Jul 2, 2020
|
|
||
| ''', title) | ||
|
|
||
| def previous = sh(script: 'cat downloaded_previous.txt', label: '### Capture Previous Sha', returnStdout: true).trim() |
There was a problem hiding this comment.
You can just do def previous = readFile(file: 'downloaded_previous.txt'). Shelling out to cat works too, but there's a built-in step for this
There was a problem hiding this comment.
I knew you'd have an insight on this! Thanks B!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Grab the previous sha from the downloadPrevious fn,
pass it through to the ingestion,
and process it in the itemizeVcs fn.
In order to provide the three dot compare url,
this pr uploads the last sha to gcp.
Then on subsequent ci runs, it downloads the "old" previous
and uses in the three dot url.