Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Increase xpack.apm.ui.transactionGroupBucketSize #70516

Closed
wants to merge 3 commits into from

Conversation

sorenlouv
Copy link
Member

Follow-up to #67273 which reduced xpack.apm.ui.transactionGroupBucketSize to 100.

This increases the limit to 1000 which means fewer people will see a warning.

@sorenlouv sorenlouv requested a review from a team as a code owner July 1, 2020 21:35
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jul 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 1, 2020
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sorenlouv
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps


Test Failures

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/apm/server/lib/transaction_groups.transactionGroupsFetcher type: top_traces should call client.search with correct query

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: expect(received).toMatchSnapshot()

Snapshot name: `transactionGroupsFetcher type: top_traces should call client.search with correct query 1`

- Snapshot  - 1
+ Received  + 1

@@ -41,11 +41,11 @@
                    "field": "transaction.duration.us",
                  },
                },
              },
              "composite": Object {
-               "size": 101,
+               "size": 10000,
                "sources": Array [
                  Object {
                    "service": Object {
                      "terms": Object {
                        "field": "service.name",
    at Object.it (/dev/shm/workspace/kibana/x-pack/plugins/apm/server/lib/transaction_groups/fetcher.test.ts:44:46)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/security_solution/public/detections/components/value_lists_management_modal.ValueListsModal renders modal if showModal is true

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: thrown: "Exceeded timeout of 5000ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."
    at Object.<anonymous>.describe (/dev/shm/workspace/kibana/x-pack/plugins/security_solution/public/detections/components/value_lists_management_modal/modal.test.tsx:25:3)
    at _dispatchDescribe (/dev/shm/workspace/kibana/node_modules/jest-circus/build/index.js:67:26)
    at describe (/dev/shm/workspace/kibana/node_modules/jest-circus/build/index.js:30:5)
    at Object.<anonymous> (/dev/shm/workspace/kibana/x-pack/plugins/security_solution/public/detections/components/value_lists_management_modal/modal.test.tsx:14:1)
    at Runtime._execModule (/dev/shm/workspace/kibana/node_modules/jest-runtime/build/index.js:1205:24)
    at Runtime._loadModule (/dev/shm/workspace/kibana/node_modules/jest-runtime/build/index.js:805:12)
    at Runtime.requireModule (/dev/shm/workspace/kibana/node_modules/jest-runtime/build/index.js:662:10)
    at jestAdapter (/dev/shm/workspace/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:145:13)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/security_solution/public/detections/components/value_lists_management_modal.ValueListsModal calls onClose when modal is closed

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: Method “simulate” is meant to be run on 1 node. 0 found instead.
    at ReactWrapper.single (/dev/shm/workspace/kibana/node_modules/enzyme/src/ReactWrapper.js:1168:13)
    at ReactWrapper.simulate (/dev/shm/workspace/kibana/node_modules/enzyme/src/ReactWrapper.js:665:17)
    at Object.it (/dev/shm/workspace/kibana/x-pack/plugins/security_solution/public/detections/components/value_lists_management_modal/modal.test.tsx:44:79)
    at Promise (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:198:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/dev/shm/workspace/kibana/node_modules/jest-circus/build/utils.js:162:10)
    at _callCircusTest (/dev/shm/workspace/kibana/node_modules/jest-circus/build/run.js:205:40)

and 3 more failures, only showing the first 3.

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv
Copy link
Member Author

Replaced by #71661

@sorenlouv sorenlouv closed this Jul 14, 2020
@sorenlouv sorenlouv deleted the increase-transactionGroupBucketSize branch July 14, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants