-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest Manager ] prepend kibana asset ids with package name #70502
[Ingest Manager ] prepend kibana asset ids with package name #70502
Conversation
Pinging @elastic/ingest-management (Team:Ingest Management) |
@elasticmachine merge upstream |
@neptunian Please make sure to test at least the dashboards of the system package that they still work. We have also some links in this dashboard which might break (I'm pretty sure they will). But for these we should update the package. Please have a conversation with @fearful-symmetry about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't run this locally or thought about all the interactions, but the code LGTM.
I appreciate pulling the related code into a new file.
x-pack/plugins/ingest_manager/server/services/epm/kibana/assets/install.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/ingest_manager/server/services/epm/kibana/assets/install.ts
Outdated
Show resolved
Hide resolved
Things seem to be working right but I missed that the links don't work. The links are in these markdown visualizations: https://github.com/elastic/integrations/blob/master/packages/nginx/kibana/visualization/97109780-a2a5-11e7-928f-5dbe6f6f5519-ecs.json#L14 |
@neptunian We should not handle the links on the Ingest Management side as these are basically a hack and hopefully going away in the future. |
Okay. Looks like they exist in netflow, nginx, and system packages. |
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
@jfsiii I made those changes you asked for. Can you look again? Thanks! |
…#70502) * prepend asset ids with package name * fix type * cleanup Co-authored-by: Elastic Machine <[email protected]>
…#70866) * prepend asset ids with package name * fix type * cleanup Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
…lastic#70502)" This reverts commit 984ea07.
…lastic#70502)" (elastic#71271) This reverts commit 984ea07.
#65035
The kibana assets installed by the Ingest Manager could conflict with ones with the same ids installed by Beats. This change will keep separate versions by modifying the ids of the assets in the Ingest Manager, as well as the references to ids in Dashboard assets, before installing
Changes
id
of each installed kibana asset with the package nameid
of each asset the asset references (in the asset'sreferences
property)dashboard
,visualization
,search
, andmap
are modifiedTest
epm-package
and see it references the correct modified ids (eg http://localhost:5601/ssg/api/saved_objects/_find?fields=installed&type=epm-packages)- install a package and repeat