[pre-req] Convert Page Manager, Page Preview, DOM Preview #70370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintandrewhall
added
review
Team:Presentation
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
crob611
approved these changes
Jul 20, 2020
|
|
||
| export const Link: FC<Props & EuiLinkProps> = ( | ||
| { onClick, target, name, params, children, ...linkArgs }, | ||
| { router } |
There was a problem hiding this comment.
I added a RouterContextProvider and started stubbing out a type for the router as well. You could switch to using useContext or at least use the type and add any aditional properties used here to it.
There was a problem hiding this comment.
@crob611 Could you perhaps push a change for my branch? Not quite following...
add UseContext to get router
💚 Build SucceededBuild metricsasync chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
clintandrewhall
added a commit
to clintandrewhall/kibana
that referenced
this pull request
Jul 21, 2020
) Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Corey Robertson <[email protected]>
clintandrewhall
added a commit
that referenced
this pull request
Jul 21, 2020
…) (#72709) Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Corey Robertson <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Corey Robertson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR converts the Page Manager, Page Preview, DOM Preview and Link components to Typescript. It also removes
recompose, adds missingi18n, fixes an issue where therefmay not be defined.This PR originally had Storybook stories (and I still have them on my PoC branch), but they depend on a Storybook Redux implementation that hasn't been approved/merged yet. I'll be tackling changes to #69357 next, and will use the Storybook examples I wrote as a test.