Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable indexing for graph and timelion fields #70291

Closed

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Jun 30, 2020

Related to #43673

This PR disables indexing for fields within the graph-workspace and timelion-sheet saved object types:

graph-workspace:

Keep as indexed field:

  • description
  • title

Don't index:

  • kibanaSavedObjectMeta.searchSourceJSON
  • numLinks
  • numVertices
  • wsState
  • version

timelion-sheet

Keep as indexed field:

  • description
  • title

Don't index:

  • version
  • hits
  • kibanaSavedObjectMeta.searchSourceJSON
  • timelion_chart_height
  • timelion_columns
  • timelion_interval
  • timelion_other_interval
  • timelion_rows
  • timelion_sheet

TODO

  • Figure out whether unindexed fields should be text or keyword

@flash1293 flash1293 added Feature:Timelion Timelion app and visualization Feature:Graph Graph application feature v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jun 30, 2020
@flash1293
Copy link
Contributor Author

@spalger This is the PR discussed via chat. It would be really cool if we could avoid changing the mappings in all these places. Is there a way to get rid of the redundancy?

@flash1293
Copy link
Contributor Author

Closing this for now, we will revisit the problem later

@flash1293 flash1293 closed this Jul 1, 2020
@kibanamachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Graph Graph application feature Feature:Timelion Timelion app and visualization release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants