Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate capabilities check for Stack Management #69437

Merged

Conversation

legrego
Copy link
Member

@legrego legrego commented Jun 17, 2020

Summary

Currently, each management item secured by Feature Controls is responsible for disabling itself if its corresponding management UI Capability is disabled.

This PR removes the per-app logic in favor of a centralized approach, to reduce the chance of incorrect or missing checks.

Required by #67791

Also resolves #57377 (Flaky test runner for verification: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/546/)

@legrego legrego force-pushed the management/consolidate-capabilities-check branch from 212bc6b to 5f262de Compare June 23, 2020 19:04
@@ -24,6 +24,6 @@ export const capabilitiesProvider = () => ({
visualize: true,
console: true,
advanced_settings: true,
index_patterns: true,
indexPatterns: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: The NP migration for index pattern management changed the capability from index_patterns to indexPatterns, so this PR updates all references as appropriate.

@legrego legrego added Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:Security/Feature Controls Platform Security - Spaces & Role Mgmt feature controls release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.9.0 v8.0.0 labels Jun 24, 2020
@legrego legrego marked this pull request as ready for review June 24, 2020 11:39
@legrego legrego requested review from a team as code owners June 24, 2020 11:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for renames in som and features plugins

@legrego legrego requested review from azasypkin and mattkime June 25, 2020 22:44
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@azasypkin
Copy link
Member

@elasticmachine merge upstream

Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legrego
Copy link
Member Author

legrego commented Jun 29, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego merged commit 28b7092 into elastic:master Jun 29, 2020
@legrego legrego deleted the management/consolidate-capabilities-check branch June 29, 2020 15:43
legrego added a commit to legrego/kibana that referenced this pull request Jun 29, 2020
Co-authored-by: Elastic Machine <[email protected]>
# Conflicts:
#	x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_security.ts
legrego added a commit that referenced this pull request Jun 29, 2020
Bamieh pushed a commit to Bamieh/kibana that referenced this pull request Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:Security/Feature Controls Platform Security - Spaces & Role Mgmt feature controls release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.9.0 v8.0.0
Projects
None yet
6 participants