Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Use asPercent to format breakdown chart #69384

Merged
merged 12 commits into from
Jun 23, 2020
Merged

[APM] Use asPercent to format breakdown chart #69384

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cb387b1
[APM] Use asPercent to format breakdown chart
dgieselaar Jun 17, 2020
908ee24
Merge branch 'master' of github.com:elastic/kibana into use-aspercent…
dgieselaar Jun 18, 2020
4c9baa8
Merge branch 'master' of github.com:elastic/kibana into use-aspercent…
dgieselaar Jun 18, 2020
09a2af4
Use asPercent for y-ticks
dgieselaar Jun 18, 2020
7334d91
Merge branch 'master' of github.com:elastic/kibana into use-aspercent…
dgieselaar Jun 18, 2020
4c77592
Merge branch 'master' into use-aspercent-io-infra
elasticmachine Jun 18, 2020
aab8061
Merge branch 'use-aspercent-io-infra' of github.com:dgieselaar/kibana…
dgieselaar Jun 18, 2020
b54a91d
Merge branch 'master' into use-aspercent-io-infra
elasticmachine Jun 22, 2020
fbd1441
Update x-pack/plugins/apm/public/utils/formatters/__test__/formatters…
dgieselaar Jun 23, 2020
71e6338
Merge branch 'master' of github.com:elastic/kibana into use-aspercent…
dgieselaar Jun 23, 2020
2d79710
Merge branch 'use-aspercent-io-infra' of github.com:dgieselaar/kibana…
dgieselaar Jun 23, 2020
b8d654e
Clarify asPercent behaviour with comments
dgieselaar Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...plugins/apm/public/components/shared/TransactionBreakdown/TransactionBreakdownKpiList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
EuiIcon,
} from '@elastic/eui';
import styled from 'styled-components';
import { FORMATTERS, InfraFormatterType } from '../../../../../infra/public';
import { asPercent } from '../../../utils/formatters';

interface TransactionBreakdownKpi {
name: string;
Expand Down Expand Up @@ -65,9 +65,7 @@ const TransactionBreakdownKpiList: React.FC<Props> = ({ kpis }) => {
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiTitle size="s">
<span>
{FORMATTERS[InfraFormatterType.percent](kpi.percentage)}
</span>
<span>{asPercent(kpi.percentage, 1)}</span>
</EuiTitle>
</EuiFlexItem>
</EuiFlexGroup>
Expand Down