-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Endpoint] add policy data to Host list UI #69202
Changes from 5 commits
3d916d5
39d29d4
d5be032
9a1f17c
af11a72
1605736
c0bdfea
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,7 +45,7 @@ export const policyDetailsMiddlewareFactory: ImmutableMiddlewareFactory<PolicyDe | |
|
||
// Until we get the Default configuration into the Endpoint package so that the datasource has | ||
// the expected data structure, we will add it here manually. | ||
if (!policyItem.inputs.length) { | ||
if (policyItem && !policyItem.inputs.length) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. checks for unit tests There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh... I see why this is needed. Case There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. that's correct |
||
policyItem.inputs = [ | ||
{ | ||
type: 'endpoint', | ||
|
@@ -69,7 +69,7 @@ export const policyDetailsMiddlewareFactory: ImmutableMiddlewareFactory<PolicyDe | |
|
||
// Agent summary is secondary data, so its ok for it to come after the details | ||
// page is populated with the main content | ||
if (policyItem.config_id) { | ||
if (policyItem && policyItem.config_id) { | ||
const { results } = await sendGetFleetAgentStatusForConfig(http, policyItem.config_id); | ||
dispatch({ | ||
type: 'serverReturnedPolicyDetailsAgentSummaryData', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spacing between the ITs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spaces added for readability