[Endpoint] use rbush to only render to DOM resolver nodes that are in view #68957

kqualters-elastic · 2020-06-11T20:31:16Z

Summary

This pr uses the rbush library to spatially index process nodes and lines within resolver. This is mostly implemented in 2 new selectors, indexedProcessNodePositionsAndEdgeLineSegments which calculates the bounding box for each process node and edge line segment and bulk inserts them into the tree, and visibleProcessNodePositionsAndEdgeLineSegments, which uses the current size of the resolver element and the current coordinates of the camera to render any items that are in the users view. This pr also adds a prop to the process event dot component to show if the process is terminated or still running.
Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

[ x ] Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

…n the DOM

elasticmachine · 2020-06-11T20:31:46Z

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

bkimmel · 2020-06-12T00:46:34Z

x-pack/plugins/security_solution/public/resolver/store/selectors.ts

+    const processesToIndex: IndexedProcessNode[] = [];
+    const edgeLineSegmentsToIndex: IndexedEdgeLineSegment[] = [];
+    for (const [processEvent, position] of positions) {
+      const transformedPosition = applyMatrix3(position, dataSelectors.isometricTransformMatrix);


ℹ️ This is entirely for your amusement and not really a serious a suggestion of any kind, but I thought you would enjoy it: https://gist.github.com/bkimmel/054eb12d9f13ce8bece83d31de20a333

bkimmel · 2020-06-12T00:48:59Z

x-pack/plugins/security_solution/public/resolver/store/selectors.ts

+    const indexedProcessTree = indexedProcessTreeFactory(
+      dataSelectors.graphableProcesses(state.data)
+    );
+    const processNodeViewWidth = 360;


🔴 Let's find some way to share these with the node, maybe export from here and import there.

x-pack/plugins/security_solution/public/resolver/models/process_event.ts

x-pack/plugins/security_solution/public/resolver/store/data/selectors.ts

+  function (results: DataState['results']) {
+    return new Set(
+      results.filter(isTerminatedProcess).map((terminatedEvent) => {
+        if (event.isLegacyEvent(terminatedEvent)) {


oatkiller · 2020-06-12T14:31:45Z

x-pack/plugins/security_solution/public/resolver/store/data/selectors.ts

@@ -60,7 +64,7 @@ export function hasError(state: DataState) {
 * We can multiply both of these matrices to get the final transformation below.
 */
 /* prettier-ignore */
-const isometricTransformMatrix: Matrix3 = [
+export const isometricTransformMatrix: Matrix3 = [


TODO, why is this exported. what else needs to know about the graph layout logic?

@kqualters-elastic can export be removed?

oatkiller · 2020-06-12T14:40:16Z

x-pack/plugins/security_solution/public/resolver/store/selectors.ts

+      };
+      processesToIndex.push(indexedEvent);
+    }
+    for (const edgeLineSegment of edgeLineSegments) {


It seems like most of the logic in this function is duplicated in processNodePositionsAndEdgeLineSegments.
Maybe instead, processNodePositionsAndEdgeLineSegments should return a function that takes an AABB and returns a the matching nodes and edge line segments. Then visibleProcessNodePositionsAndEdgeLineSegments (in this file) can get the AABB like it already does, and call processNodePositionsAndEdgeLineSegments.

Reasoninig:

Only selectors/data will need to know about the graph layout. This is good because the graph layout will change, and possibly end up being dynamic (in the future.)

No code duplication. This code in data/selectors seems to be duplicated here

oatkiller · 2020-06-12T14:42:18Z

x-pack/plugins/security_solution/public/resolver/store/selectors.ts

@@ -122,3 +132,93 @@ function composeSelectors<OuterState, InnerState, ReturnValue>(
 ): (state: OuterState) => ReturnValue {
  return (state) => secondSelector(selector(state));
 }
+
+const spatiallyIndexedEntities = createSelector(


Since this only needs stuff from the data selectors, I think this should be moved to the data selectors. And processNodePositionsAndEdgeLineSegments can probably be made private. Nothing outside of data needs to be exposed to the underlying structure of the graph. The interface can just be

(query: AABB) => Entities[]

oatkiller · 2020-06-12T14:45:25Z

x-pack/plugins/security_solution/public/resolver/store/selectors.ts

+      maxX,
+      maxY,
+    });
+    const visibleProcessNodePositions = visibleEntities.filter(


Why not return the the entire array and let the react code deal with it. in react

visibleEntities.map(entity => { if (entity.type === 'edge') { // components } else { // different components } })

Based on past PR feedback I've gotten, I think the indication here would be to keep it as it is:
#64121 (comment)

bkimmel · 2020-06-15T14:02:31Z

x-pack/plugins/security_solution/public/resolver/store/selectors.ts

+);
+
+export const visibleProcessNodePositionsAndEdgeLineSegments = createSelector(
+  spatiallyIndexedEntities,


❔ I think we talked about this before, but we might need to think about selecting in the "active" and "selected" nodes from the UI (they may or may not be the same) and also possibly the ones "adjacent" to them as designated by the processAdjacency (sp?) selector. The reason is, I'm not sure how it would play out to have those things point (via aria-flowto and other mechanics) to nodes that "don't exist".

Would it be possible/good to make this like spatiallyIndexedAndActiveUIEntities?

Even though this is kind of a big issue, I'm marking it with a ❔ because I don't think it should stand in the way of merging this PR (and we have an issue on the board to deal with a11y stuff for 7.9 that we could cover this under. I'd ask that if you decide not to look into this, you add a comment to ( https://github.com/elastic/endpoint-app-team/issues/289 ) just so we know to track it.

I'd note that in most cases this shouldn't add any more nodes to render. The active one should always be centered and when you're zoomed out enough, at least the up,left, and right ones should already be visible. Sometimes the selected one might be outside the viewbox (after we implement more a11y fixes) so you could be looking at maybe a worst case of 5 (selected + 4 directions) + 5 (active + maybe 4 directions) == 10 extras.

bkimmel · 2020-06-15T14:12:47Z

x-pack/plugins/security_solution/public/resolver/view/index.tsx

                  adjacentNodeMap={adjacentNodeMap}
-                  relatedEvents={relatedEvents.get(processEvent)}
+                  isProcessTerminated={terminatedProcesses.has(entity_id)}


ℹ️ very 🆒

bkimmel · 2020-06-15T14:15:55Z

x-pack/plugins/security_solution/public/resolver/view/process_event_dot.tsx

@@ -340,7 +349,9 @@ const ProcessEventDotComponents = React.memo(
          })
        | null;
    } = React.createRef();
-    const { cubeSymbol, labelBackground, descriptionText } = nodeAssets[nodeType(event)];
+    const { cubeSymbol, labelBackground, descriptionText } = nodeAssets[
+      nodeType(isProcessTerminated, isProcessOrigin)


ℹ️ nice

bkimmel · 2020-06-15T14:16:39Z

x-pack/plugins/security_solution/public/resolver/view/index.tsx

                  adjacentNodeMap={adjacentNodeMap}
-                  relatedEvents={relatedEvents.get(processEvent)}
+                  isProcessTerminated={terminatedProcesses.has(entity_id)}
+                  isProcessOrigin={false}


❔ Where/how does it get the kind where isProcessOrigin={true} ?

bkimmel

I have a few questions, but nothing that should stand in the way of merging this great work.

oatkiller · 2020-06-15T15:28:10Z

x-pack/plugins/security_solution/public/resolver/store/data/selectors.ts

+    return new Set(
+      results.filter(isTerminatedProcess).map((terminatedEvent) => {
+        if (event.isLegacyEvent(terminatedEvent)) {
+          return terminatedEvent.endgame.unique_pid;


Maybe this should use entityId here: https://github.com/elastic/kibana/blob/master/x-pack/plugins/security_solution/common/endpoint/models/event.ts#L42

or https://github.com/elastic/kibana/blob/master/x-pack/plugins/security_solution/public/resolver/models/process_event.ts#L73

…unction that takes optional bounding box

michaelolo24 · 2020-06-23T16:43:16Z

x-pack/plugins/security_solution/public/resolver/view/index.tsx

+              },
+              index
+            ) => (
+              <EdgeLine


Looks like the metadata for the elapsed time was removed on the rebase probably

thanks, did not intend to do that will add back.

oatkiller · 2020-06-17T15:22:56Z

x-pack/plugins/security_solution/public/resolver/store/data/selectors.ts

@@ -60,7 +64,7 @@ export function hasError(state: DataState) {
 * We can multiply both of these matrices to get the final transformation below.
 */
 /* prettier-ignore */
-const isometricTransformMatrix: Matrix3 = [
+export const isometricTransformMatrix: Matrix3 = [


@kqualters-elastic can export be removed?

oatkiller · 2020-06-17T15:23:18Z

x-pack/plugins/security_solution/public/resolver/store/data/selectors.ts

@@ -119,7 +146,7 @@ export const graphableProcesses = createSelector(
 *                   H
 *
 */
-function widthsOfProcessSubtrees(indexedProcessTree: IndexedProcessTree): ProcessWidths {
+export function widthsOfProcessSubtrees(indexedProcessTree: IndexedProcessTree): ProcessWidths {


@kqualters-elastic can export be removed?

oatkiller · 2020-06-17T15:23:37Z

x-pack/plugins/security_solution/public/resolver/store/data/selectors.ts

@@ -150,7 +177,7 @@ function widthsOfProcessSubtrees(indexedProcessTree: IndexedProcessTree): Proces
  return widths;
 }

-function processEdgeLineSegments(
+export function processEdgeLineSegments(


@kqualters-elastic can export be removed?

oatkiller · 2020-06-23T16:42:53Z

x-pack/plugins/security_solution/public/resolver/store/data/selectors.ts

@@ -330,7 +358,7 @@ function* levelOrderWithWidths(
  }
 }

-function processPositions(
+export function processPositions(


can export be removed?

oatkiller · 2020-06-23T16:46:16Z

x-pack/plugins/security_solution/public/resolver/store/data/selectors.ts

+        processNodePositions: visibleProcessNodePositions,
+        connectingEdgeLineSegments,
+      };
+    }, isEqual);


Suggestion:
In models/vector2.ts add:

export function isEqual([x1, y1]: Vector2, [x2, y2]: Vector2): boolean { return x1 === x2 && y1 === y2 }

In 'models/aabb.ts` add:

import * as vector2 from './vector2'; export function isEqual(a: AABB, b: AABB): boolean { return vector2.isEqual(a.minimum, b.minimum) && vector2.isEqual(a.maximum, b.maximum); }

Then replace isEqual with aabb.isEqual.

oatkiller · 2020-06-23T16:49:22Z

x-pack/plugins/security_solution/public/resolver/view/index.tsx

+          {processNodePositions.map(({ entity, position }, index) => {
+            const adjacentNodeMap = processToAdjacencyMap.get(entity);
+            const {
+              process: { entity_id },


please use the entityID method here instead

oatkiller · 2020-06-23T17:09:47Z

x-pack/plugins/security_solution/public/resolver/store/visible_entities.test.ts

@@ -0,0 +1,145 @@
+/*


can we add animation tests to this?

oatkiller · 2020-06-23T17:42:09Z

x-pack/plugins/security_solution/public/resolver/store/selectors.ts

+export const visibleProcessNodePositionsAndEdgeLineSegments = createSelector(
+  indexedProcessNodesAndEdgeLineSegments,
+  currentBoundingBox,
+  function (
+    /* eslint-disable no-shadow */
+    indexedProcessNodesAndEdgeLineSegments,
+    currentBoundingBox
+    /* eslint-enable no-shadow */
+  ) {
+    return indexedProcessNodesAndEdgeLineSegments(currentBoundingBox);
+  }
+);


Suggested change

export const visibleProcessNodePositionsAndEdgeLineSegments = createSelector(

indexedProcessNodesAndEdgeLineSegments,

currentBoundingBox,

function (

/* eslint-disable no-shadow */

indexedProcessNodesAndEdgeLineSegments,

currentBoundingBox

/* eslint-enable no-shadow */

) {

return indexedProcessNodesAndEdgeLineSegments(currentBoundingBox);

}

);

export const visibleProcessNodePositionsAndEdgeLineSegments = createSelector(

indexedProcessNodesAndEdgeLineSegments,

boundingBox,

function (

/* eslint-disable no-shadow */

indexedProcessNodesAndEdgeLineSegments,

boundingBox

/* eslint-enable no-shadow */

) {

return (time: number) => indexedProcessNodesAndEdgeLineSegments(boundingBox(time));

}

);

bkimmel · 2020-06-24T18:32:55Z

x-pack/plugins/security_solution/public/resolver/store/data/visible_entities.test.ts

+      store.dispatch(action);
+      store.dispatch(cameraAction);
+    });
+    it('the visibleProcessNodePositions list should include all lines', () => {


❔ I think you intended list should include all lines to be list should include all _processNodePositions

bkimmel · 2020-06-24T18:36:47Z

x-pack/plugins/security_solution/public/resolver/view/process_event_dot.tsx

@@ -704,3 +717,22 @@ export const ProcessEventDot = styled(ProcessEventDotComponents)`
    color: white;
  }
 `;
+
+const processTypeToCube: Record<ResolverProcessType, keyof NodeStyleMap> = {


❔ This and nodeType below got moved to /view/assets on master. Did you intend to duplicate them here?

bkimmel

Couple more questions after recent changes, but my thumb stands.

bkimmel · 2020-06-24T18:38:57Z

x-pack/plugins/security_solution/public/resolver/lib/aabb.ts

+import { AABB } from '../types';
+
+/**
+ * Return a boolean indicating if 2 vector objects are equal.


❔ Some explanation of what AABB represents in the comments could be of help to a reader.

So far i've tried to document the type:

kibana/x-pack/plugins/security_solution/public/resolver/types.ts

Line 162 in 700f53d

export interface AABB {

This way, you can browse the types file and see what every concept we model is.
Also, your editor can show you those comments on hover usually:
e.g. in mine:

oatkiller · 2020-06-24T19:06:02Z

x-pack/plugins/security_solution/public/resolver/store/data/selectors.ts

+    const processNodeViewWidth = 720;
+    const processNodeViewHeight = 240;
+    const lineSegmentPadding = 30;


Suggested change

const processNodeViewWidth = 720;

const processNodeViewHeight = 240;

const lineSegmentPadding = 30;

// Make sure these numbers are big enough to cover the process nodes at all zoom levels.

// NB: the process nodes don't extend equally in all directions from their center point.

const processNodeViewWidth = 720;

const processNodeViewHeight = 240;

const lineSegmentPadding = 30;

oatkiller · 2020-06-24T19:09:12Z

x-pack/plugins/security_solution/public/resolver/store/data/visible_entities.test.ts

+    it('the visibleProcessNodePositions list should only include 2 nodes', () => {
+      const { processNodePositions } = visibleProcessNodePositionsAndEdgeLineSegments(
+        store.getState()
+      )(Date.now());


If you don't an animation running, you can just use 0. that eliminates the code smell of side effects

oatkiller · 2020-06-24T19:09:22Z

x-pack/plugins/security_solution/public/resolver/store/data/visible_entities.test.ts

+    it('the visibleProcessNodePositions list should only include 2 nodes', () => {
+      const { processNodePositions } = visibleProcessNodePositionsAndEdgeLineSegments(
+        store.getState()
+      )(Date.now());


Suggested change

)(Date.now());

)(0);

oatkiller · 2020-06-24T19:09:31Z

x-pack/plugins/security_solution/public/resolver/store/data/visible_entities.test.ts

+    it('the visibleEdgeLineSegments list should only include 1 lines', () => {
+      const { connectingEdgeLineSegments } = visibleProcessNodePositionsAndEdgeLineSegments(
+        store.getState()
+      )(Date.now());


Suggested change

)(Date.now());

)(0);

oatkiller · 2020-06-24T19:10:25Z

x-pack/plugins/security_solution/public/resolver/store/data/visible_entities.test.ts

+      store.dispatch(action);
+      store.dispatch(cameraAction);
+    });
+    it('the visibleProcessNodePositions list should include all lines', () => {


TODO, kq to do something better

oatkiller · 2020-06-24T19:10:35Z

x-pack/plugins/security_solution/public/resolver/store/data/visible_entities.test.ts

+    it('the visibleProcessNodePositions list should include all lines', () => {
+      const { processNodePositions } = visibleProcessNodePositionsAndEdgeLineSegments(
+        store.getState()
+      )(Date.now());


Suggested change

)(Date.now());

)(0);

oatkiller · 2020-06-24T19:11:01Z

x-pack/plugins/security_solution/public/resolver/store/data/visible_entities.test.ts

+    });
+    store = createStore(resolverReducer, undefined);
+  });
+  describe('when rendering a large tree with a small viewport', () => {


Suggested change

describe('when rendering a large tree with a small viewport', () => {

describe('when rendering a tree with 2 events and with a small viewport', () => {

oatkiller · 2020-06-24T19:12:07Z

x-pack/plugins/security_solution/public/resolver/store/data/visible_entities.test.ts

+      )(Date.now());
+      expect(processNodePositions.length).toEqual(2);
+    });
+    it('the visibleEdgeLineSegments list should only include 1 lines', () => {


Suggested change

it('the visibleEdgeLineSegments list should only include 1 lines', () => {

it('the visibleEdgeLineSegments list should only include one edge line', () => {

oatkiller · 2020-06-24T19:12:40Z

x-pack/plugins/security_solution/public/resolver/store/data/visible_entities.test.ts

+      expect(connectingEdgeLineSegments.length).toEqual(1);
+    });
+  });
+  describe('when rendering a large tree with a large viewport', () => {


Suggested change

describe('when rendering a large tree with a large viewport', () => {

describe('when rendering a tree with seven events and with a large viewport', () => {

oatkiller · 2020-06-24T19:14:35Z

x-pack/plugins/security_solution/public/resolver/store/selectors.ts

+  dataSelectors.visibleProcessNodePositionsAndEdgeLineSegments
+);
+
+export const visibleProcessNodePositionsAndEdgeLineSegments = createSelector(


Suggested change

export const visibleProcessNodePositionsAndEdgeLineSegments = createSelector(

/**

* Return the visible edge lines and process nodes based on the camera position at `time`.

* The bounding box represents what the camera can see. The camera position is a function of time because it can be animated. So in order to get the currently visible entities, we need

to pass in time.

*/

export const visibleProcessNodePositionsAndEdgeLineSegments = createSelector(

oatkiller · 2020-06-24T19:15:10Z

x-pack/plugins/security_solution/public/resolver/types.ts

@@ -142,6 +142,33 @@ export type CameraState = {
    }
 );

+export type IndexedEntity = IndexedEdgeLineSegment | IndexedProcessNode;


Suggested change

export type IndexedEntity = IndexedEdgeLineSegment | IndexedProcessNode;

/**

* Wrappers around our internal types that make them compatible with `rbush`.

*/

export type IndexedEntity = IndexedEdgeLineSegment | IndexedProcessNode;

oatkiller · 2020-06-24T19:15:27Z

x-pack/plugins/security_solution/public/resolver/types.ts

+export interface IndexedProcessNode extends BBox {
+  type: 'processNode';
+  entity: ResolverEvent;
+  position: Vector2;


Suggested change

position: Vector2;

oatkiller · 2020-06-24T19:20:08Z

x-pack/plugins/security_solution/public/resolver/store/data/selectors.ts

+          maxX,
+          maxY,
+        });
+        const visibleProcessNodePositions = entities.filter(


TODO, map these back to the non-indexed versions. This encapsulates the internal indexed structure. This is good because we don't actually need that structure, rbush can be configured to work w/ our AABB type.

oatkiller · 2020-06-24T19:22:32Z

x-pack/plugins/security_solution/public/resolver/view/index.tsx

+            ) => (
+              <EdgeLine
+                edgeLineMetadata={metadata}
+                key={index}


Because rbush might return these entities in a non-stable order, we should use a stable key. This will help react reconcile old and new components. Since this runs every frame.... :)

oatkiller · 2020-06-24T19:25:09Z

x-pack/plugins/security_solution/public/resolver/view/panel.tsx

@@ -51,6 +51,7 @@ const PanelContent = memo(function PanelContent() {
  const urlSearch = history.location.search;
  const dispatch = useResolverDispatch();

+  const { timestamp } = useContext(SideEffectContext);


solid change

oatkiller · 2020-06-24T19:26:53Z

x-pack/plugins/security_solution/public/resolver/view/process_event_dot.tsx

@@ -364,14 +376,15 @@ const ProcessEventDotComponents = React.memo(
        | null;
    } = React.createRef();
    const { colorMap, nodeAssets } = useResolverTheme();
+    const processType = nodeType(isProcessTerminated, isProcessOrigin);


TODO, delete old nodeType from assets

oatkiller

fired

kibanamachine · 2020-06-26T00:24:08Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 81c7383

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
securitySolution	777	+1	776

History

💔 Build #56532 failed a135d31
💔 Build #56031 failed 41070a4
💔 Build #56027 failed be0ea37
💔 Build #55600 failed c265c0a
💔 Build #54592 failed c2d27f6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…are in view (#68957) (#70072) * [Endpoint] use rbush to only render resolver nodes that are in view in the DOM * Add related events code back * Change processNodePositionsAndEdgeLineSegments selector to return a function that takes optional bounding box * Refactor selectors to not break original, and not run as often * Memoize rtree search selector, fix tests * Update node styles to use style hook, update jest tests * Fix type change issue in jest test Co-authored-by: Elastic Machine <[email protected]>

[Endpoint] use rbush to only render resolver nodes that are in view i…

5513e4d

…n the DOM

kqualters-elastic requested review from a team as code owners June 11, 2020 20:31

kqualters-elastic added the Feature:Endpoint Elastic Endpoint feature label Jun 11, 2020

kqualters-elastic added Feature:Resolver Security Solution Resolver feature release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0 labels Jun 11, 2020

bkimmel reviewed Jun 12, 2020

View reviewed changes

x-pack/plugins/security_solution/public/resolver/models/process_event.ts Show resolved Hide resolved

kqualters-elastic added 2 commits June 12, 2020 02:15

Add related events code back

5a49e18

Merge branch 'master' into spatial-index-resolver-nodes

793814d

james-elastic approved these changes Jun 12, 2020

View reviewed changes

oatkiller suggested changes Jun 12, 2020

View reviewed changes

bkimmel reviewed Jun 15, 2020

View reviewed changes

bkimmel approved these changes Jun 15, 2020

View reviewed changes

oatkiller reviewed Jun 15, 2020

View reviewed changes

Merge branch 'master' into spatial-index-resolver-nodes

3e7a642

kqualters-elastic marked this pull request as draft June 17, 2020 07:22

kqualters-elastic added 3 commits June 17, 2020 03:24

Change processNodePositionsAndEdgeLineSegments selector to return a f…

c2d27f6

…unction that takes optional bounding box

Merge branch 'master' into spatial-index-resolver-nodes

5a2feae

Refactor selectors to not break original, and not run as often

c265c0a

michaelolo24 reviewed Jun 23, 2020

View reviewed changes

oatkiller suggested changes Jun 23, 2020

View reviewed changes

oatkiller reviewed Jun 23, 2020

View reviewed changes

bkimmel reviewed Jun 24, 2020

View reviewed changes

bkimmel approved these changes Jun 24, 2020

View reviewed changes

bkimmel reviewed Jun 24, 2020

View reviewed changes

oatkiller reviewed Jun 24, 2020

View reviewed changes

oatkiller suggested changes Jun 24, 2020

View reviewed changes

kqualters-elastic added 3 commits June 25, 2020 17:56

Update node styles to use style hook, update jest tests

38350c8

Merge branch 'master' into spatial-index-resolver-nodes

a135d31

Fix type change issue in jest test

81c7383

oatkiller approved these changes Jun 25, 2020

View reviewed changes

kqualters-elastic merged commit 9ebf41c into elastic:master Jun 26, 2020

kqualters-elastic deleted the spatial-index-resolver-nodes branch June 26, 2020 13:42

kqualters-elastic mentioned this pull request Jun 26, 2020

[7.x] [Endpoint] use rbush to only render to DOM resolver nodes that are in view (#68957) #70072

Merged

	describe('when rendering a large tree with a small viewport', () => {
	describe('when rendering a tree with 2 events and with a small viewport', () => {

	it('the visibleEdgeLineSegments list should only include 1 lines', () => {
	it('the visibleEdgeLineSegments list should only include one edge line', () => {

	describe('when rendering a large tree with a large viewport', () => {
	describe('when rendering a tree with seven events and with a large viewport', () => {

-export const visibleProcessNodePositionsAndEdgeLineSegments = createSelector(
+/**
+ * Return the visible edge lines and process nodes based on the camera position at `time`.
+ * The bounding box represents what the camera can see. The camera position is a function of time because it can be animated. So in order to get the currently visible entities, we need
+ to pass in time.
+ */
+export const visibleProcessNodePositionsAndEdgeLineSegments = createSelector(

[Endpoint] use rbush to only render to DOM resolver nodes that are in view #68957

[Endpoint] use rbush to only render to DOM resolver nodes that are in view #68957

Conversation

kqualters-elastic commented Jun 11, 2020 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Jun 11, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bkimmel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bkimmel Jun 24, 2020 • edited Loading

Choose a reason for hiding this comment

bkimmel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oatkiller Jun 24, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oatkiller left a comment

Choose a reason for hiding this comment

kibanamachine commented Jun 26, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

History

kqualters-elastic commented Jun 11, 2020 •

edited

Loading

bkimmel Jun 24, 2020 •

edited

Loading

oatkiller Jun 24, 2020 •

edited

Loading