Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] Replace var assignments with let in ui tests #6865

Merged
merged 1 commit into from
Apr 13, 2016

Conversation

epixa
Copy link
Contributor

@epixa epixa commented Apr 12, 2016

This change was applied to any .js files under __tests__ directories in
the ui module.

This was an automatic replacement from var to let for any variable
declaration that doubles as the initial assignment. Ultimately we want
most of these to be converted to const, but this commit is so large that
it warrants breaking each step of automation up into its own commit.

For example:

var foo = 'bar'; becomes let foo = 'var';

This was accomplished by replacing:
find: var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)=
replace: let $1$2=

This change was applied to any .js files under __tests__ directories in
the ui module.

This was an automatic replacement from var to let for any variable
declaration that doubles as the initial assignment. Ultimately we want
most of these to be converted to const, but this commit is so large that
it warrants breaking each step of automation up into its own commit.

For example:

var foo = 'bar'; becomes let foo = 'var';

This was accomplished by replacing:
find: var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)=
replace: let $1$2=
@epixa
Copy link
Contributor Author

epixa commented Apr 12, 2016

This is just a little too big to show in a single diff on github, but it's only touching __tests__ files, and you can see from the build whether those tests are running successfully. I'll break it up into separate PRs if requested, though.

@epixa epixa added the review label Apr 12, 2016
@epixa epixa assigned panda01 and unassigned epixa Apr 12, 2016
@spalger
Copy link
Contributor

spalger commented Apr 12, 2016

I am using the following command to view the entire change set locally

# install diff-so-fancy if you haven't already
brew install diff-so-fancy

git show HEAD --patch --color | diff-so-fancy | less -R

@epixa
Copy link
Contributor Author

epixa commented Apr 12, 2016

You're so fancy.

@spalger
Copy link
Contributor

spalger commented Apr 12, 2016

LGTM

@panda01
Copy link
Contributor

panda01 commented Apr 13, 2016

Ah i just read the description a bit more... LGTM!

@panda01 panda01 merged commit 721eb2d into elastic:master Apr 13, 2016
elastic-jasper added a commit that referenced this pull request Apr 13, 2016
---------

**Commit 1:**
[internal] Replace var assignments with let in ui tests

This change was applied to any .js files under __tests__ directories in
the ui module.

This was an automatic replacement from var to let for any variable
declaration that doubles as the initial assignment. Ultimately we want
most of these to be converted to const, but this commit is so large that
it warrants breaking each step of automation up into its own commit.

For example:

var foo = 'bar'; becomes let foo = 'var';

This was accomplished by replacing:
find: var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)=
replace: let $1$2=

* Original sha: 863228d
* Authored by Court Ewing <[email protected]> on 2016-04-12T15:30:18Z
elastic-jasper added a commit that referenced this pull request Apr 13, 2016
---------

**Commit 1:**
[internal] Replace var assignments with let in ui tests

This change was applied to any .js files under __tests__ directories in
the ui module.

This was an automatic replacement from var to let for any variable
declaration that doubles as the initial assignment. Ultimately we want
most of these to be converted to const, but this commit is so large that
it warrants breaking each step of automation up into its own commit.

For example:

var foo = 'bar'; becomes let foo = 'var';

This was accomplished by replacing:
find: var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)=
replace: let $1$2=

* Original sha: 863228d
* Authored by Court Ewing <[email protected]> on 2016-04-12T15:30:18Z
@epixa epixa deleted the uiletconst branch April 13, 2016 14:40
epixa added a commit that referenced this pull request Apr 13, 2016
---------

**Commit 1:**
[internal] Replace var assignments with let in ui tests

This change was applied to any .js files under __tests__ directories in
the ui module.

This was an automatic replacement from var to let for any variable
declaration that doubles as the initial assignment. Ultimately we want
most of these to be converted to const, but this commit is so large that
it warrants breaking each step of automation up into its own commit.

For example:

var foo = 'bar'; becomes let foo = 'var';

This was accomplished by replacing:
find: var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)=
replace: let $1$2=

* Original sha: 863228d
* Authored by Court Ewing <[email protected]> on 2016-04-12T15:30:18Z
elastic-jasper added a commit that referenced this pull request Apr 13, 2016
---------

**Commit 1:**
[internal] Replace var assignments with let in ui tests

This change was applied to any .js files under `__tests__` directories in
the ui module.

This was an automatic replacement from var to let for any variable
declaration that doubles as the initial assignment. Ultimately we want
most of these to be converted to const, but this commit is so large that
it warrants breaking each step of automation up into its own commit.

For example:

var foo = 'bar'; becomes let foo = 'var';

This was accomplished by replacing:
find: var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)=
replace: let $1$2=

* Original sha: 863228d
* Authored by Court Ewing <[email protected]> on 2016-04-12T15:30:18Z
epixa added a commit that referenced this pull request Apr 13, 2016
epixa added a commit that referenced this pull request Apr 13, 2016
@epixa epixa added v4.5.2 and removed v4.5.1 labels May 14, 2016
@epixa epixa added the v4.5.4 label Jul 21, 2016
@epixa epixa removed the v4.5.2 label Jul 21, 2016
Ikuni17 pushed a commit that referenced this pull request Jul 6, 2023
`[email protected]` ⏩ `83.0.0`

⚠️ The biggest change in this PR by far is the `EuiButtonEmpty` Emotion
conversion, which changes the DOM structure of the button slightly as
well as several CSS classes around it.

EUI has attempted to convert any custom EuiButtonEmpty CSS overrides
where possible, but would super appreciate it if CODEOWNERS checked
their touched files. If anything other than a snapshot or test was
touched, please double check the display of your button(s) and confirm
everything still looks shipshape. Feel free to ping us for advice if
not.

---

## [`83.0.0`](https://github.com/elastic/eui/tree/v83.0.0)

**Bug fixes**

- Fixed `EuiPaginationButton` styling affected by `EuiButtonEmpty`'s
Emotion conversion ([#6893](elastic/eui#6893))

**Breaking changes**

- Removed `isPlaceholder` prop from `EuiPaginationButton`
([#6893](elastic/eui#6893))

## [`82.2.1`](https://github.com/elastic/eui/tree/v82.2.1)

- Updated supported Node engine versions to allow Node 16, 18 and >=20
([#6884](elastic/eui#6884))

## [`82.2.0`](https://github.com/elastic/eui/tree/v82.2.0)

- Updated EUI's SVG icons library to use latest SVGO v3 optimization
([#6843](elastic/eui#6843))
- Added success color `EuiNotificationBadge`
([#6864](elastic/eui#6864))
- Added `badgeColor` prop to `EuiFilterButton`
([#6864](elastic/eui#6864))
- Updated `EuiBadge` to use CSS-in-JS for named colors instead of inline
styles. Custom colors will still use inline styles.
([#6864](elastic/eui#6864))

**CSS-in-JS conversions**

- Converted `EuiButtonGroup` and `EuiButtonGroupButton` to Emotion
([#6841](elastic/eui#6841))
- Converted `EuiButtonIcon` to Emotion
([#6844](elastic/eui#6844))
- Converted `EuiButtonEmpty` to Emotion
([#6863](elastic/eui#6863))
- Converted `EuiCollapsibleNav` and `EuiCollapsibleNavGroup` to Emotion
([#6865](elastic/eui#6865))
- Removed Sass variables `$euiCollapsibleNavGroupLightBackgroundColor`,
`$euiCollapsibleNavGroupDarkBackgroundColor`, and
`$euiCollapsibleNavGroupDarkHighContrastColor`
([#6865](elastic/eui#6865))

---------

Co-authored-by: Cee Chen <[email protected]>
Co-authored-by: Jeramy Soucy <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants