-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[internal] Replace var assignments with let in ui tests #6865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change was applied to any .js files under __tests__ directories in the ui module. This was an automatic replacement from var to let for any variable declaration that doubles as the initial assignment. Ultimately we want most of these to be converted to const, but this commit is so large that it warrants breaking each step of automation up into its own commit. For example: var foo = 'bar'; becomes let foo = 'var'; This was accomplished by replacing: find: var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)= replace: let $1$2=
This is just a little too big to show in a single diff on github, but it's only touching |
I am using the following command to view the entire change set locally # install diff-so-fancy if you haven't already
brew install diff-so-fancy
git show HEAD --patch --color | diff-so-fancy | less -R |
You're so fancy. |
LGTM |
Ah i just read the description a bit more... LGTM! |
This was referenced Apr 13, 2016
elastic-jasper
added a commit
that referenced
this pull request
Apr 13, 2016
--------- **Commit 1:** [internal] Replace var assignments with let in ui tests This change was applied to any .js files under __tests__ directories in the ui module. This was an automatic replacement from var to let for any variable declaration that doubles as the initial assignment. Ultimately we want most of these to be converted to const, but this commit is so large that it warrants breaking each step of automation up into its own commit. For example: var foo = 'bar'; becomes let foo = 'var'; This was accomplished by replacing: find: var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)= replace: let $1$2= * Original sha: 863228d * Authored by Court Ewing <[email protected]> on 2016-04-12T15:30:18Z
elastic-jasper
added a commit
that referenced
this pull request
Apr 13, 2016
--------- **Commit 1:** [internal] Replace var assignments with let in ui tests This change was applied to any .js files under __tests__ directories in the ui module. This was an automatic replacement from var to let for any variable declaration that doubles as the initial assignment. Ultimately we want most of these to be converted to const, but this commit is so large that it warrants breaking each step of automation up into its own commit. For example: var foo = 'bar'; becomes let foo = 'var'; This was accomplished by replacing: find: var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)= replace: let $1$2= * Original sha: 863228d * Authored by Court Ewing <[email protected]> on 2016-04-12T15:30:18Z
epixa
added a commit
that referenced
this pull request
Apr 13, 2016
--------- **Commit 1:** [internal] Replace var assignments with let in ui tests This change was applied to any .js files under __tests__ directories in the ui module. This was an automatic replacement from var to let for any variable declaration that doubles as the initial assignment. Ultimately we want most of these to be converted to const, but this commit is so large that it warrants breaking each step of automation up into its own commit. For example: var foo = 'bar'; becomes let foo = 'var'; This was accomplished by replacing: find: var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)= replace: let $1$2= * Original sha: 863228d * Authored by Court Ewing <[email protected]> on 2016-04-12T15:30:18Z
elastic-jasper
added a commit
that referenced
this pull request
Apr 13, 2016
--------- **Commit 1:** [internal] Replace var assignments with let in ui tests This change was applied to any .js files under `__tests__` directories in the ui module. This was an automatic replacement from var to let for any variable declaration that doubles as the initial assignment. Ultimately we want most of these to be converted to const, but this commit is so large that it warrants breaking each step of automation up into its own commit. For example: var foo = 'bar'; becomes let foo = 'var'; This was accomplished by replacing: find: var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)= replace: let $1$2= * Original sha: 863228d * Authored by Court Ewing <[email protected]> on 2016-04-12T15:30:18Z
Ikuni17
pushed a commit
that referenced
this pull request
Jul 6, 2023
`[email protected]` ⏩ `83.0.0`⚠️ The biggest change in this PR by far is the `EuiButtonEmpty` Emotion conversion, which changes the DOM structure of the button slightly as well as several CSS classes around it. EUI has attempted to convert any custom EuiButtonEmpty CSS overrides where possible, but would super appreciate it if CODEOWNERS checked their touched files. If anything other than a snapshot or test was touched, please double check the display of your button(s) and confirm everything still looks shipshape. Feel free to ping us for advice if not. --- ## [`83.0.0`](https://github.com/elastic/eui/tree/v83.0.0) **Bug fixes** - Fixed `EuiPaginationButton` styling affected by `EuiButtonEmpty`'s Emotion conversion ([#6893](elastic/eui#6893)) **Breaking changes** - Removed `isPlaceholder` prop from `EuiPaginationButton` ([#6893](elastic/eui#6893)) ## [`82.2.1`](https://github.com/elastic/eui/tree/v82.2.1) - Updated supported Node engine versions to allow Node 16, 18 and >=20 ([#6884](elastic/eui#6884)) ## [`82.2.0`](https://github.com/elastic/eui/tree/v82.2.0) - Updated EUI's SVG icons library to use latest SVGO v3 optimization ([#6843](elastic/eui#6843)) - Added success color `EuiNotificationBadge` ([#6864](elastic/eui#6864)) - Added `badgeColor` prop to `EuiFilterButton` ([#6864](elastic/eui#6864)) - Updated `EuiBadge` to use CSS-in-JS for named colors instead of inline styles. Custom colors will still use inline styles. ([#6864](elastic/eui#6864)) **CSS-in-JS conversions** - Converted `EuiButtonGroup` and `EuiButtonGroupButton` to Emotion ([#6841](elastic/eui#6841)) - Converted `EuiButtonIcon` to Emotion ([#6844](elastic/eui#6844)) - Converted `EuiButtonEmpty` to Emotion ([#6863](elastic/eui#6863)) - Converted `EuiCollapsibleNav` and `EuiCollapsibleNavGroup` to Emotion ([#6865](elastic/eui#6865)) - Removed Sass variables `$euiCollapsibleNavGroupLightBackgroundColor`, `$euiCollapsibleNavGroupDarkBackgroundColor`, and `$euiCollapsibleNavGroupDarkHighContrastColor` ([#6865](elastic/eui#6865)) --------- Co-authored-by: Cee Chen <[email protected]> Co-authored-by: Jeramy Soucy <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was applied to any .js files under
__tests__
directories inthe ui module.
This was an automatic replacement from var to let for any variable
declaration that doubles as the initial assignment. Ultimately we want
most of these to be converted to const, but this commit is so large that
it warrants breaking each step of automation up into its own commit.
For example:
var foo = 'bar';
becomeslet foo = 'var';
This was accomplished by replacing:
find:
var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)=
replace:
let $1$2=