-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Endpoint] Using the stats provided by the backend for resolver UI #68577
Merged
jonathan-buttner
merged 10 commits into
elastic:master
from
jonathan-buttner:resolver-stats-ui
Jun 12, 2020
Merged
[Endpoint] Using the stats provided by the backend for resolver UI #68577
jonathan-buttner
merged 10 commits into
elastic:master
from
jonathan-buttner:resolver-stats-ui
Jun 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
Feature:Endpoint
Elastic Endpoint feature
release_note:skip
Skip the PR/issue when compiling release notes
Team:Endpoint Data Visibility
Team managing the endpoint resolver
v7.9.0
v8.0.0
labels
Jun 12, 2020
jonathan-buttner
changed the title
[skip-ci][WIP] Using the stats provided by the backend for resolver UI
[Endpoint] Using the stats provided by the backend for resolver UI
Jun 12, 2020
Pinging @elastic/endpoint-app-team (Feature:Endpoint) |
Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility) |
jonathan-buttner
requested review from
oatkiller,
kqualters-elastic and
michaelolo24
June 12, 2020 16:17
@elasticmachine merge upstream |
x-pack/plugins/security_solution/public/resolver/store/middleware.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/resolver/store/middleware.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/resolver/store/data/selectors.ts
Show resolved
Hide resolved
…a into resolver-stats-ui
oatkiller
approved these changes
Jun 12, 2020
michaelolo24
approved these changes
Jun 12, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jonathan-buttner
added a commit
that referenced
this pull request
Jun 13, 2020
…68577) (#69070) * Removing a lot of the code to request related events and create the maps * Correctly displaying stats * Removing tests * Addressing todos * Fixing test * Fixing camera test Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 15, 2020
* master: (91 commits) [Search][BUG] Call wrong search strategy recursively in async search (elastic#69116) [Observability] Create context container to enable Observability plugin registry function (elastic#68642) Rename space id for disabled index pattern test (elastic#68990) skip flaky suite (elastic#63339) Resolver Light Theme And Kibana Integration (elastic#67859) [kbn/dev-utils] expose public tooling_log module (elastic#68868) index pattern(s) take dependencies as object (elastic#69055) include ci-stats metrics in pr comment (elastic#68563) Bump webpack packages (elastic#68716) [Uptime] Fixed metric query broken because of missing mapping (elastic#68999) Added cloud as an optional dependency (elastic#69050) Fixed all external links (elastic#68614) [DOCS] Reorganizes doc nav to match new Kibana nav (elastic#69069) [Endpoint] Using the stats provided by the backend for resolver UI (elastic#68577) [DOCS] Removees 8.0 from Upgrade Assistant docs (elastic#69067) [ML] Fix cloud deployment ID check (elastic#68695) [DOCS] Move metrics app content to metrics monitoring guide (elastic#69033) Add ingest manager topic to docs (elastic#68980) [SECURITY SOLUTION] EMT-401: add policy data to metadata and fix tests (elastic#68582) [DOCS] Fixes POST request for saved objects (elastic#69036) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 15, 2020
* master: (60 commits) Re-enable mistakenly skipped tests. (elastic#69123) [Search][BUG] Call wrong search strategy recursively in async search (elastic#69116) [Observability] Create context container to enable Observability plugin registry function (elastic#68642) Rename space id for disabled index pattern test (elastic#68990) skip flaky suite (elastic#63339) Resolver Light Theme And Kibana Integration (elastic#67859) [kbn/dev-utils] expose public tooling_log module (elastic#68868) index pattern(s) take dependencies as object (elastic#69055) include ci-stats metrics in pr comment (elastic#68563) Bump webpack packages (elastic#68716) [Uptime] Fixed metric query broken because of missing mapping (elastic#68999) Added cloud as an optional dependency (elastic#69050) Fixed all external links (elastic#68614) [DOCS] Reorganizes doc nav to match new Kibana nav (elastic#69069) [Endpoint] Using the stats provided by the backend for resolver UI (elastic#68577) [DOCS] Removees 8.0 from Upgrade Assistant docs (elastic#69067) [ML] Fix cloud deployment ID check (elastic#68695) [DOCS] Move metrics app content to metrics monitoring guide (elastic#69033) Add ingest manager topic to docs (elastic#68980) [SECURITY SOLUTION] EMT-401: add policy data to metadata and fix tests (elastic#68582) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Endpoint
Elastic Endpoint feature
release_note:skip
Skip the PR/issue when compiling release notes
Team:Endpoint Data Visibility
Team managing the endpoint resolver
v7.9.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages the stats for related events and alerts provided by the backend for usage in the UI. It removes a lot of the functionality in the UI that was requesting all the events and calculating the stats when the user clicked the drop down:
Drop down
This PR does not open the drop down by default.
When no related events exist for a node
When related events exist for a node