Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability] Adding key property to avoid react warning #68491

Merged
merged 1 commit into from
Jun 8, 2020
Merged

[Observability] Adding key property to avoid react warning #68491

merged 1 commit into from
Jun 8, 2020

Conversation

cauemarcondes
Copy link
Contributor

No description provided.

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 Feature:Observability Landing labels Jun 8, 2020
@cauemarcondes cauemarcondes requested a review from shahzad31 June 8, 2020 09:13
@cauemarcondes cauemarcondes requested a review from a team as a code owner June 8, 2020 09:13
@cauemarcondes cauemarcondes requested a review from a team June 8, 2020 09:13
@cauemarcondes cauemarcondes requested review from a team as code owners June 8, 2020 09:13
shahzad31
shahzad31 approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/canvas/custom_elements·ts.Canvas app custom elements adds the custom element to the workpad when prompted

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 5 times on tracked branches: https://github.com/elastic/kibana/issues/63339

[00:00:00]       │
[00:01:22]         └-: Canvas app
[00:01:22]           └-> "before all" hook
[00:02:13]           └-: custom elements
[00:02:13]             └-> "before all" hook
[00:02:13]             └-> "before all" hook
[00:02:13]               │ info [logstash_functional] Loading "mappings.json"
[00:02:13]               │ info [logstash_functional] Loading "data.json.gz"
[00:02:13]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.22"
[00:02:13]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.20"
[00:02:13]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.21"
[00:02:15]               │ info [canvas/default] Loading "mappings.json"
[00:02:15]               │ info [canvas/default] Loading "data.json.gz"
[00:02:15]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1591607661019505127] [.kibana_2/4En0CJfaTNuoEkLa7uiXlg] deleting index
[00:02:15]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1591607661019505127] [.kibana_1/uq0eF-TSTUmCrWjrfdjJRw] deleting index
[00:02:15]               │ info [canvas/default] Deleted existing index [".kibana_2",".kibana_1"]
[00:02:15]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1591607661019505127] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:02:15]               │ info [canvas/default] Created index ".kibana_1"
[00:02:15]               │ debg [canvas/default] ".kibana_1" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:02:15]               │ info [canvas/default] Indexed 3 docs into ".kibana_1"
[00:02:15]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1591607661019505127] [.kibana_1/1AnF2ZfwQhmhvhi3KZ8FPQ] update_mapping [_doc]
[00:02:15]               │ debg Migrating saved objects
[00:02:16]               │ proc [kibana]   log   [09:50:14.252] [info][savedobjects-service] Creating index .kibana_2.
[00:02:16]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1591607661019505127] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:02:16]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1591607661019505127] updating number_of_replicas to [0] for indices [.kibana_2]
[00:02:16]               │ proc [kibana]   log   [09:50:14.362] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:02:16]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1591607661019505127] [.kibana_2/D6-6oKiAQjaS_2Pi070Mkw] update_mapping [_doc]
[00:02:16]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1591607661019505127] [.kibana_2/D6-6oKiAQjaS_2Pi070Mkw] update_mapping [_doc]
[00:02:16]               │ proc [kibana]   log   [09:50:14.533] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:02:16]               │ proc [kibana]   log   [09:50:14.687] [info][savedobjects-service] Finished in 438ms.
[00:02:16]               │ debg navigating to canvas url: http://localhost:6131/app/canvas#/
[00:02:16]               │ debg navigate to: http://localhost:6131/app/canvas#/
[00:02:17]               │ debg browser[INFO] http://localhost:6131/app/canvas?_t=1591609814705#/ 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:17]               │
[00:02:17]               │ debg browser[INFO] http://localhost:6131/bundles/app/core/bootstrap.js 11:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:17]               │ debg ... sleep(700) start
[00:02:18]               │ debg ... sleep(700) end
[00:02:18]               │ debg returned from get, calling refresh
[00:02:20]               │ debg browser[INFO] http://localhost:6131/33646/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 380:106115 "INFO: 2020-06-08T09:50:16Z
[00:02:20]               │        Adding connection to http://localhost:6131/elasticsearch
[00:02:20]               │
[00:02:20]               │      "
[00:02:20]               │ERROR browser[SEVERE] http://localhost:6131/33646/bundles/core/core.entry.js 75:173111 TypeError: Failed to fetch
[00:02:20]               │          at Fetch._callee3$ (http://localhost:6131/33646/bundles/core/core.entry.js:26:69024)
[00:02:20]               │          at l (http://localhost:6131/33646/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:288:974701)
[00:02:20]               │          at Generator._invoke (http://localhost:6131/33646/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:288:974454)
[00:02:20]               │          at Generator.forEach.e.<computed> [as throw] (http://localhost:6131/33646/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:288:975058)
[00:02:20]               │          at fetch_asyncGeneratorStep (http://localhost:6131/33646/bundles/core/core.entry.js:26:63428)
[00:02:20]               │          at _throw (http://localhost:6131/33646/bundles/core/core.entry.js:26:63836)
[00:02:20]               │ debg browser[INFO] http://localhost:6131/app/canvas?_t=1591609814705#/ 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:20]               │
[00:02:20]               │ debg browser[INFO] http://localhost:6131/bundles/app/core/bootstrap.js 11:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:20]               │ debg browser[INFO] http://localhost:6131/33646/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 380:106115 "INFO: 2020-06-08T09:50:17Z
[00:02:20]               │        Adding connection to http://localhost:6131/elasticsearch
[00:02:20]               │
[00:02:20]               │      "
[00:02:20]               │ debg currentUrl = http://localhost:6131/app/canvas#/
[00:02:20]               │          appUrl = http://localhost:6131/app/canvas#/
[00:02:20]               │ debg TestSubjects.find(kibanaChrome)
[00:02:20]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:02:20]               │ debg ... sleep(501) start
[00:02:21]               │ debg ... sleep(501) end
[00:02:21]               │ debg in navigateTo url = http://localhost:6131/app/canvas#/
[00:02:21]               │ debg TestSubjects.exists(statusPageContainer)
[00:02:21]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:02:23]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:02:24]               │ debg navigating to canvas url: http://localhost:6131/app/canvas#/workpad/workpad-1705f884-6224-47de-ba49-ca224fe6ec31/page/1
[00:02:24]               │ debg navigate to: http://localhost:6131/app/canvas#/workpad/workpad-1705f884-6224-47de-ba49-ca224fe6ec31/page/1
[00:02:24]               │ debg browser[INFO] http://localhost:6131/app/canvas?_t=1591609821856#/workpad/workpad-1705f884-6224-47de-ba49-ca224fe6ec31/page/1 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:24]               │
[00:02:24]               │ debg browser[INFO] http://localhost:6131/bundles/app/core/bootstrap.js 11:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:24]               │ debg ... sleep(700) start
[00:02:25]               │ debg ... sleep(700) end
[00:02:25]               │ debg returned from get, calling refresh
[00:02:27]               │ debg browser[INFO] http://localhost:6131/33646/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 380:106115 "INFO: 2020-06-08T09:50:23Z
[00:02:27]               │        Adding connection to http://localhost:6131/elasticsearch
[00:02:27]               │
[00:02:27]               │      "
[00:02:27]               │ERROR browser[SEVERE] http://localhost:6131/33646/bundles/core/core.entry.js 75:173111 TypeError: Failed to fetch
[00:02:27]               │ debg browser[INFO] http://localhost:6131/app/canvas?_t=1591609821856#/workpad/workpad-1705f884-6224-47de-ba49-ca224fe6ec31/page/1 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:27]               │
[00:02:27]               │ debg browser[INFO] http://localhost:6131/bundles/app/core/bootstrap.js 11:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:27]               │ debg browser[INFO] http://localhost:6131/33646/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 380:106115 "INFO: 2020-06-08T09:50:25Z
[00:02:27]               │        Adding connection to http://localhost:6131/elasticsearch
[00:02:27]               │
[00:02:27]               │      "
[00:02:27]               │ debg currentUrl = http://localhost:6131/app/canvas#/workpad/workpad-1705f884-6224-47de-ba49-ca224fe6ec31/page/1
[00:02:27]               │          appUrl = http://localhost:6131/app/canvas#/workpad/workpad-1705f884-6224-47de-ba49-ca224fe6ec31/page/1
[00:02:27]               │ debg TestSubjects.find(kibanaChrome)
[00:02:27]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:02:27]               │ debg ... sleep(501) start
[00:02:28]               │ debg ... sleep(501) end
[00:02:28]               │ debg in navigateTo url = http://localhost:6131/app/canvas#/workpad/workpad-1705f884-6224-47de-ba49-ca224fe6ec31/page/1
[00:02:28]               │ debg TestSubjects.exists(statusPageContainer)
[00:02:28]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:02:30]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:02:31]             └-> creates a custom element from an element when prompted
[00:02:31]               └-> "before each" hook: global before each
[00:02:31]               │ debg TestSubjects.click(canvasWorkpadPage > canvasWorkpadPageElementContent)
[00:02:31]               │ debg Find.clickByCssSelector('[data-test-subj="canvasWorkpadPage"] [data-test-subj="canvasWorkpadPageElementContent"]') with timeout=20000
[00:02:31]               │ debg Find.findByCssSelector('[data-test-subj="canvasWorkpadPage"] [data-test-subj="canvasWorkpadPageElementContent"]') with timeout=20000
[00:02:31]               │ debg TestSubjects.click(canvasWorkpadEditMenuButton)
[00:02:31]               │ debg Find.clickByCssSelector('[data-test-subj="canvasWorkpadEditMenuButton"]') with timeout=20000
[00:02:31]               │ debg Find.findByCssSelector('[data-test-subj="canvasWorkpadEditMenuButton"]') with timeout=20000
[00:02:31]               │ debg TestSubjects.click(canvasWorkpadEditMenu__saveElementButton)
[00:02:31]               │ debg Find.clickByCssSelector('[data-test-subj="canvasWorkpadEditMenu__saveElementButton"]') with timeout=20000
[00:02:31]               │ debg Find.findByCssSelector('[data-test-subj="canvasWorkpadEditMenu__saveElementButton"]') with timeout=20000
[00:02:31]               │ debg TestSubjects.setValue(canvasCustomElementForm-name, My New Element)
[00:02:31]               │ debg TestSubjects.click(canvasCustomElementForm-name)
[00:02:31]               │ debg Find.clickByCssSelector('[data-test-subj="canvasCustomElementForm-name"]') with timeout=10000
[00:02:31]               │ debg Find.findByCssSelector('[data-test-subj="canvasCustomElementForm-name"]') with timeout=10000
[00:02:32]               │ debg TestSubjects.setValue(canvasCustomElementForm-description, An excellent new element)
[00:02:32]               │ debg TestSubjects.click(canvasCustomElementForm-description)
[00:02:32]               │ debg Find.clickByCssSelector('[data-test-subj="canvasCustomElementForm-description"]') with timeout=10000
[00:02:32]               │ debg Find.findByCssSelector('[data-test-subj="canvasCustomElementForm-description"]') with timeout=10000
[00:02:32]               │ debg TestSubjects.click(canvasCustomElementForm-submit)
[00:02:32]               │ debg Find.clickByCssSelector('[data-test-subj="canvasCustomElementForm-submit"]') with timeout=10000
[00:02:32]               │ debg Find.findByCssSelector('[data-test-subj="canvasCustomElementForm-submit"]') with timeout=10000
[00:02:32]               │ debg TestSubjects.exists(canvasCustomElementCreate-success)
[00:02:32]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="canvasCustomElementCreate-success"]') with timeout=30000
[00:02:33]               └- ✓ pass  (2.3s) "Canvas app custom elements creates a custom element from an element when prompted"
[00:02:33]             └-> adds the custom element to the workpad when prompted
[00:02:33]               └-> "before each" hook: global before each
[00:02:33]               │ debg TestSubjects.click(add-element-button)
[00:02:33]               │ debg Find.clickByCssSelector('[data-test-subj="add-element-button"]') with timeout=10000
[00:02:33]               │ debg Find.findByCssSelector('[data-test-subj="add-element-button"]') with timeout=10000
[00:02:33]               │ debg TestSubjects.click(saved-elements-menu-option)
[00:02:33]               │ debg Find.clickByCssSelector('[data-test-subj="saved-elements-menu-option"]') with timeout=10000
[00:02:33]               │ debg Find.findByCssSelector('[data-test-subj="saved-elements-menu-option"]') with timeout=10000
[00:02:33]               │ debg Find.findByCssSelector('.canvasElementCard__wrapper') with timeout=10000
[00:02:34]               │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/Canvas app custom elements adds the custom element to the workpad when prompted.png"
[00:02:34]               │ info Current URL is: http://localhost:6131/app/canvas#/workpad/workpad-1705f884-6224-47de-ba49-ca224fe6ec31/page/1
[00:02:34]               │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/Canvas app custom elements adds the custom element to the workpad when prompted.html
[00:02:34]               └- ✖ fail: "Canvas app custom elements adds the custom element to the workpad when prompted"
[00:02:34]               │

Stack Trace

Error: expected '' to contain 'My New Element'
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.contain (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:442:10)
    at Context.it (test/functional/apps/canvas/custom_elements.ts:68:53)
    at process._tickCallback (internal/process/next_tick.js:68:7)

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 00cff3c into elastic:master Jun 8, 2020
@cauemarcondes cauemarcondes deleted the observability-warning branch June 8, 2020 11:03
@cauemarcondes cauemarcondes mentioned this pull request Jun 8, 2020
Merged
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Jun 8, 2020
@cauemarcondes
Adding key to avoid react warning (elastic#68491)
7f1bd46
cauemarcondes added a commit that referenced this pull request Jun 8, 2020
@cauemarcondes
Adding key to avoid react warning (#68491) (#68500)
65ec264
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 8, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
445710f 
* master:
  [ML] DFAnalytics results: ensure ml result fields are shown in data grid (elastic#68305)
  [security_solution] enable react-hooks/exhaustive-deps (elastic#68470)
  Closes elastic#66867 by adding missing, requried API params (elastic#68465)
  [Telemetry] collect number of visualization saved in the past 7, 30 and 90 days (elastic#67865)
  [Logs UI] View in context tweaks (elastic#67777)
  Kibana developer examples landing page (elastic#67049)
  Bump decompress package version (elastic#68386)
  fix elastic#66185 (elastic#66186)
  Bump pdfmake package version (elastic#68395)
  Unskip embeddables/adding_children suite (elastic#68111)
  Add embed mode options in the Share UI (elastic#58435)
  Adding key to avoid react warning (elastic#68491)
@LeeDr LeeDr added the Team:Observability Team label for Observability Team (for things that are handled across all of observability) label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Observability Team label for Observability Team (for things that are handled across all of observability) v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cauemarcondes @kibanamachine @dgieselaar @shahzad31 @LeeDr