Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

advanced_ui_actions 👉 ui_actions_enhanced #68258

Merged
merged 3 commits into from
Jun 5, 2020
Merged

advanced_ui_actions 👉 ui_actions_enhanced #68258

merged 3 commits into from
Jun 5, 2020

Conversation

streamich
Copy link
Contributor

@streamich streamich commented Jun 4, 2020 •
edited
Loading

Summary

Renames advanced_ui_actions plugin to ui_actions_ehnanced plugin. No other changes.

Partially addresses #59562

@streamich streamich changed the title chore: 🤖 rename advanced_ui_actions to ui_actions_enhanced advanced_ui_actions 👉 ui_actions_enhanced Jun 4, 2020
@streamich streamich mentioned this pull request Jun 4, 2020
Closed
3 tasks
@streamich streamich added Feature:UIActions UI actions. These are client side only, not related to the server side actions.. release_note:skip Skip the PR/issue when compiling release notes review Team:AppArch v7.9.0 labels Jun 4, 2020
@streamich streamich marked this pull request as ready for review June 4, 2020 14:39
@streamich streamich requested a review from a team June 4, 2020 14:39
@streamich streamich requested review from a team as code owners June 4, 2020 14:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

cchaos
cchaos approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple SASS file move, 👍

@botelastic botelastic bot added the Feature:Drilldowns Embeddable panel Drilldowns label Jun 4, 2020
@streamich
Copy link
Contributor Author

@cchaos wow, that was fast! thanks!

@kertal kertal self-requested a review June 5, 2020 08:14
kertal
kertal approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KibanaApp Code LGTM, tested dashboard drilldowns in Safari, Chrome, Firefox, MacOs 10.14.6

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit 99a6435 into elastic:master Jun 5, 2020
@streamich streamich mentioned this pull request Jun 5, 2020
Merged
streamich added a commit that referenced this pull request Jun 5, 2020
@streamich
advanced_ui_actions 👉 ui_actions_enhanced (#68258) (#68364)
2238279 
* chore: 🤖 rename advanced_ui_actions to ui_actions_enhanced

* chore: 🤖 rename exported interface to "enhanced"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

@jbudz jbudz jbudz approved these changes

@cchaos cchaos cchaos approved these changes

@kertal kertal kertal approved these changes

Assignees
No one assigned
Labels
Feature:Drilldowns Embeddable panel Drilldowns Feature:UIActions UI actions. These are client side only, not related to the server side actions.. release_note:skip Skip the PR/issue when compiling release notes review v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@streamich @elasticmachine @kibanamachine @kertal @cchaos @jbudz @Dosant