[RUM] Added Rum tab and filters #68086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
added
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
sorenlouv
reviewed
Jun 4, 2020
sorenlouv
reviewed
Jun 4, 2020
| } from '../../server/lib/helpers/setup_request'; | ||
| import { PROCESSOR_EVENT } from '../elasticsearch_fieldnames'; | ||
| // eslint-disable-next-line @kbn/eslint/no-restricted-paths | ||
| import { rangeFilter } from '../../server/lib/helpers/range_filter'; |
There was a problem hiding this comment.
I know you didn't introduce this but it just occurs to me that we should never import server code into common (the imports above are fine since it's only types which will disappear at runtime).
Would you mind moving rangeFilter.ts into commons, if it's not too difficult? If your editor supports refactorings it should be able to update all the import statements for you.
There was a problem hiding this comment.
addressed in commit aaf0240
jalvz
approved these changes
Jun 4, 2020
|
Pinging @elastic/apm-ui (Team:apm) |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
closing in favour of #68778 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #67588
Resolves #67608
Added Rum filters and tab to add dashboard/overview page