[Uptime] Edit uptime alerts #68005

justinkambic · 2020-06-02T18:56:12Z

Summary

Allows users to edit alerts they've previously created in the Uptime UI.

Something to note, old alerts will still work after this change, even though the underlying params have changed. I've added this callout to indicate to a user why some of their parameters aren't showing up:

Testing

There are a number of cases this PR seeks to cover, and the code is re-used in several different contexts, so it's important to thoroughly smoke test each case.

Creating an alert in Uptime

Create an alert from the Uptime UI with no filters or search pre-selected
Create an alert from Uptime with filters/search pre-selected. The values you were using in the app should auto-populate. The app won't stay in sync with the filters in the background today.

Creating an alert in the Management view

Create an alert and ensure filter values are populated.

Editing an alert in the Management view

Edit the alert, ensure that filters populate and that when you save the alert and re-edit, the values continue to appear.

Editing old alerts

Checkout 884704d or earlier and create an alert, then load this patch. Ensure that the alert you created can be edited, and continues to work properly after you save it.
You should see an "old alert" call out notifying you that some fields will not auto-populate.
Check that the "old alert" call out no longer appears if you open the alert after saving.

In all cases, add and remove filter values and searches to validate that these components behave as desired.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

…registration.

…erts-ahead

shahzad31

LGTM in testing alerts !!

justinkambic · 2020-06-05T22:47:08Z

@shahzad31 sorry to put you through another review, but I discovered another case where this wasn't behaving the way we want. I've committed significant code since your approval so we should verify that as well.

kibanamachine · 2020-06-08T18:34:36Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 09bf4b3

History

💚 Build #52257 succeeded 1e9928c
💚 Build #52204 succeeded 518410d
💔 Build #52197 failed b7053b8
💔 Build #52177 failed 9eb7de4
💔 Build #52167 failed 647d74f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

shahzad31

LGTM !!

* Extract store creation to plugin start, add redux providers to alert registration. * Update unit test. * Move alert registration to `setup` function. * Allow external editing of uptime client alert types. * Move alert initialization back to `start`. * Clean up interfaces for alert types. * Add code that will work for settings link even outside uptime app. * Create new atomic params type for status alerts. * Update executor params typing to support both alert params types. * Update snapshot for alert factory function. * Fix broken types and refresh snapshots. * Allow edits of filters for monitor alerts. * Support default parameter value for numTimes. * Support default parameter values for timerange. * Modify kuery bar to work for alert edits, fix some filter issues. * Clean up tests and fix types. * Fix types and add a test. * Add callout and validation handling for old alerts while editing. * Add a test for updated validation function. * Define window for overview filters fetch action. * Revert store initialization. * Make monitor counter function while editing alerts. * Refresh snapshot. * Move snapshot count in monitor status alert to callout. * Add new state for selected filters. * Add basic functional tests for uptime alert flyouts. * Fix broken types. * Update unit tests with mock provider. * Remove unneeded params from hook. * Add more unit tests. * Reducing functional test flakiness. * Alert flyout controls update url only within Uptime app. * Extract context interaction to container component, update snapshots. * Add missing parameter to test file. * Remove flaky functional test. Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Shahzad <[email protected]>

* Extract store creation to plugin start, add redux providers to alert registration. * Update unit test. * Move alert registration to `setup` function. * Allow external editing of uptime client alert types. * Move alert initialization back to `start`. * Clean up interfaces for alert types. * Add code that will work for settings link even outside uptime app. * Create new atomic params type for status alerts. * Update executor params typing to support both alert params types. * Update snapshot for alert factory function. * Fix broken types and refresh snapshots. * Allow edits of filters for monitor alerts. * Support default parameter value for numTimes. * Support default parameter values for timerange. * Modify kuery bar to work for alert edits, fix some filter issues. * Clean up tests and fix types. * Fix types and add a test. * Add callout and validation handling for old alerts while editing. * Add a test for updated validation function. * Define window for overview filters fetch action. * Revert store initialization. * Make monitor counter function while editing alerts. * Refresh snapshot. * Move snapshot count in monitor status alert to callout. * Add new state for selected filters. * Add basic functional tests for uptime alert flyouts. * Fix broken types. * Update unit tests with mock provider. * Remove unneeded params from hook. * Add more unit tests. * Reducing functional test flakiness. * Alert flyout controls update url only within Uptime app. * Extract context interaction to container component, update snapshots. * Add missing parameter to test file. * Remove flaky functional test. Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Shahzad <[email protected]> # Conflicts: # x-pack/plugins/uptime/public/lib/alert_types/monitor_status.tsx

* Extract store creation to plugin start, add redux providers to alert registration. * Update unit test. * Move alert registration to `setup` function. * Allow external editing of uptime client alert types. * Move alert initialization back to `start`. * Clean up interfaces for alert types. * Add code that will work for settings link even outside uptime app. * Create new atomic params type for status alerts. * Update executor params typing to support both alert params types. * Update snapshot for alert factory function. * Fix broken types and refresh snapshots. * Allow edits of filters for monitor alerts. * Support default parameter value for numTimes. * Support default parameter values for timerange. * Modify kuery bar to work for alert edits, fix some filter issues. * Clean up tests and fix types. * Fix types and add a test. * Add callout and validation handling for old alerts while editing. * Add a test for updated validation function. * Define window for overview filters fetch action. * Revert store initialization. * Make monitor counter function while editing alerts. * Refresh snapshot. * Move snapshot count in monitor status alert to callout. * Add new state for selected filters. * Add basic functional tests for uptime alert flyouts. * Fix broken types. * Update unit tests with mock provider. * Remove unneeded params from hook. * Add more unit tests. * Reducing functional test flakiness. * Alert flyout controls update url only within Uptime app. * Extract context interaction to container component, update snapshots. * Add missing parameter to test file. * Remove flaky functional test. Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Shahzad <[email protected]> # Conflicts: # x-pack/plugins/uptime/public/lib/alert_types/monitor_status.tsx Co-authored-by: Elastic Machine <[email protected]>

justinkambic · 2020-06-09T20:42:26Z

Backported to:

7.8/7.8.0 524dc2a
[7.8] [Uptime] Edit uptime alerts (#68005) #68560
7.x/7.9.0 f23ec71
[7.x] [Uptime] Edit uptime alerts (#68005) #68559

* Extract store creation to plugin start, add redux providers to alert registration. * Update unit test. * Move alert registration to `setup` function. * Allow external editing of uptime client alert types. * Move alert initialization back to `start`. * Clean up interfaces for alert types. * Add code that will work for settings link even outside uptime app. * Create new atomic params type for status alerts. * Update executor params typing to support both alert params types. * Update snapshot for alert factory function. * Fix broken types and refresh snapshots. * Allow edits of filters for monitor alerts. * Support default parameter value for numTimes. * Support default parameter values for timerange. * Modify kuery bar to work for alert edits, fix some filter issues. * Clean up tests and fix types. * Fix types and add a test. * Add callout and validation handling for old alerts while editing. * Add a test for updated validation function. * Define window for overview filters fetch action. * Revert store initialization. * Make monitor counter function while editing alerts. * Refresh snapshot. * Move snapshot count in monitor status alert to callout. * Add new state for selected filters. * Add basic functional tests for uptime alert flyouts. * Fix broken types. * Update unit tests with mock provider. * Remove unneeded params from hook. * Add more unit tests. * Reducing functional test flakiness. * Alert flyout controls update url only within Uptime app. * Extract context interaction to container component, update snapshots. * Add missing parameter to test file. * Remove flaky functional test. Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Shahzad <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Shahzad <[email protected]>

justinkambic added 19 commits May 14, 2020 11:20

Extract store creation to plugin start, add redux providers to alert …

c094dd9

…registration.

Update unit test.

6bb5519

Move alert registration to setup function.

e5a1eb3

Allow external editing of uptime client alert types.

03ec299

Move alert initialization back to start.

bf16f6a

Clean up interfaces for alert types.

c2ad6d0

Add code that will work for settings link even outside uptime app.

f8e3c7e

Merge branch 'master' into uptime_edit-alerts

4ced92e

Create new atomic params type for status alerts.

47fe9cc

Update executor params typing to support both alert params types.

f5cf3b5

Update snapshot for alert factory function.

e414180

Fix broken types and refresh snapshots.

68dec30

Merge branch 'master' into uptime_edit-alerts

4c64d12

Merge branch 'uptime_monitor-status-alert-params' into uptime_edit-al…

13594b7

…erts-ahead

Allow edits of filters for monitor alerts.

ccea1f0

Support default parameter value for numTimes.

4caaeca

Support default parameter values for timerange.

93739f5

Modify kuery bar to work for alert edits, fix some filter issues.

c93037e

Clean up tests and fix types.

87df991

justinkambic added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v7.9.0 labels Jun 2, 2020

justinkambic self-assigned this Jun 2, 2020

botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jun 2, 2020

justinkambic added 2 commits June 2, 2020 21:40

Merge branch 'master' into uptime_edit-alerts-ahead

7ad31fc

Fix types and add a test.

af77c7a

justinkambic marked this pull request as ready for review June 3, 2020 13:55

justinkambic requested a review from a team as a code owner June 3, 2020 13:55

shahzad31 approved these changes Jun 5, 2020

View reviewed changes

justinkambic added 3 commits June 5, 2020 17:05

Add basic functional tests for uptime alert flyouts.

9eb7de4

Fix broken types.

63bf9ec

Update unit tests with mock provider.

b6c5e04

Merge branch 'master' into uptime_edit-alerts-ahead

b7053b8

justinkambic requested a review from shahzad31 June 5, 2020 22:48

justinkambic added 11 commits June 5, 2020 19:13

Remove unneeded params from hook.

518410d

Merge branch 'master' into uptime_edit-alerts-ahead

a5e0571

Add more unit tests.

ba2b18e

Reducing functional test flakiness.

290905e

Merge branch 'master' into uptime_edit-alerts-ahead

1e9928c

Merge branch 'master' into uptime_edit-alerts-ahead

589f0f8

Alert flyout controls update url only within Uptime app.

b761ea4

Extract context interaction to container component, update snapshots.

ce725fb

Merge branch 'master' into uptime_edit-alerts-ahead

c1e6344

Add missing parameter to test file.

0eea5fd

Remove flaky functional test.

09bf4b3

shahzad31 approved these changes Jun 8, 2020

View reviewed changes

justinkambic merged commit 858523e into elastic:master Jun 8, 2020

justinkambic mentioned this pull request Jun 8, 2020

[7.x] [Uptime] Edit uptime alerts (#68005) #68559

Merged

justinkambic mentioned this pull request Jun 8, 2020

[7.8] [Uptime] Edit uptime alerts (#68005) #68560

Merged

justinkambic deleted the uptime_edit-alerts-ahead branch June 9, 2020 20:43

justinkambic mentioned this pull request Jun 11, 2020

Register UI alert types before app mount event elastic/uptime#201

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Uptime] Edit uptime alerts #68005

[Uptime] Edit uptime alerts #68005

justinkambic commented Jun 2, 2020 •

edited

Loading

shahzad31 left a comment

justinkambic commented Jun 5, 2020

kibanamachine commented Jun 8, 2020

shahzad31 left a comment

justinkambic commented Jun 9, 2020 •

edited

Loading

[Uptime] Edit uptime alerts #68005

[Uptime] Edit uptime alerts #68005

Conversation

justinkambic commented Jun 2, 2020 • edited Loading

Summary

Testing

Creating an alert in Uptime

Creating an alert in the Management view

Editing an alert in the Management view

Editing old alerts

Checklist

For maintainers

shahzad31 left a comment

Choose a reason for hiding this comment

justinkambic commented Jun 5, 2020

kibanamachine commented Jun 8, 2020

💚 Build Succeeded

History

shahzad31 left a comment

Choose a reason for hiding this comment

justinkambic commented Jun 9, 2020 • edited Loading

justinkambic commented Jun 2, 2020 •

edited

Loading

justinkambic commented Jun 9, 2020 •

edited

Loading