Deprecate kibana.defaultAppId setting #67635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
kertal
approved these changes
May 29, 2020
|
As a follow up, should we go ahead and merge a PR that removes this feature from the master branch? |
|
@joshdover I would like to postpone that for a while because it's referenced in a bunch of files and I want to avoid conflicts in backports. |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Jun 3, 2020
flash1293
added a commit
that referenced
this pull request
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #54088
The
kibana.defaultAppIdsetting is deprecated and will be removed with 8.0. The space-awaredefaultRouteadvanced setting should be used instead.This PR introduces a warning in the console if the setting is used, removes it from one unrelated place in the docs where it is used as an example and adds a deprecation warning to the docs.