Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Could not locate that index-pattern" recreate link is not working #67280

Merged

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented May 25, 2020

Summary

Fixes #67003

This is the link which we are fixing ⬇
Screenshot 2020-05-19 at 15 13 24

I added a functional test, because we've recently fixed this link and it regressed again #62427

@mattkime, I bumped into this particular issue, but I am not sure if there more cross app linking regressions caused by #63443 / #65026

Checklist

Delete any items that are not applicable to this PR.

@Dosant Dosant changed the title try fix, check if ci fails Fix "Could not locate that index-pattern" recreate link is not working May 26, 2020
@Dosant Dosant added bug Fixes for quality problems that affect the customer experience regression release_note:skip Skip the PR/issue when compiling release notes Team:AppArch v7.9.0 v8.0.0 labels May 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@Dosant Dosant marked this pull request as ready for review May 26, 2020 10:23
@Dosant Dosant requested review from a team as code owners May 26, 2020 10:23
@Dosant Dosant requested a review from mattkime May 26, 2020 13:30
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 1 suggestion about the test

test/functional/apps/dashboard/dashboard_error_handling.ts Outdated Show resolved Hide resolved
@Dosant Dosant requested a review from dmlemeshko May 27, 2020 10:39
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally

@Dosant Dosant merged commit 13138c0 into elastic:master May 27, 2020
Dosant added a commit to Dosant/kibana that referenced this pull request May 27, 2020
elastic#67280)

added a functional test, because we've recently fixed this link and it regressed again
Dosant added a commit that referenced this pull request May 27, 2020
#67280) (#67472)

added a functional test, because we've recently fixed this link and it regressed again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience regression release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embeddable "Could not locate that index-pattern" recreate link is not working
5 participants