Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Platform Migration]: Management - Implement NP API #66781

Merged
merged 129 commits into from
Jun 3, 2020
Merged
Show file tree
Hide file tree
Changes from 89 commits
Commits
Show all changes
129 commits
Select commit Hold shift + click to select a range
3740707
[New Platform Migration]: Management - Implement NP API
alexwizp May 13, 2020
1d42f83
Merge branch 'master' into management-routing
mattkime May 18, 2020
f2980b8
Merge branch 'master' into management-routing
mattkime May 19, 2020
0a3a79f
partial progress on a number of management sections
mattkime May 19, 2020
ad66a12
Merge remote-tracking branch 'upstream/master' into management-routing
alexwizp May 19, 2020
1c2062b
Merge branch 'master' into management-routing
mattkime May 19, 2020
0a96008
fix passing history
mattkime May 19, 2020
5a8d563
Merge branch 'master' into management-routing
mattkime May 19, 2020
44f2c7f
Merge branch 'management-routing' of github.com:alexwizp/kibana into …
mattkime May 19, 2020
3f0f2e4
Fixed types
VladLasitsa May 19, 2020
12d6ac2
Fixed routing for Ingest Node Pipelines
VladLasitsa May 19, 2020
500a682
Merge branch 'management-routing' of github.com:alexwizp/kibana into …
mattkime May 19, 2020
8890dc8
introduce and use react router wrapped eui components
mattkime May 19, 2020
dbfe0e4
react router utils
mattkime May 19, 2020
13bf37c
work in progress => hashRouter to router
mattkime May 20, 2020
67c95aa
Merge branch 'master' into management-routing
mattkime May 20, 2020
beaaa70
more partial progress
mattkime May 20, 2020
a729bce
remove console.log
mattkime May 20, 2020
30189d6
Merge remote-tracking branch 'upstream/master' into management-routing
alexwizp May 20, 2020
0bacead
use reactRouterNavigate for management_sidebar
alexwizp May 20, 2020
e570f0f
Breadcrumbs will need to make use of the reactRouterNavigate function
alexwizp May 20, 2020
b95a10a
[triggersActions] app. Hash Router -> Router
alexwizp May 20, 2020
17b49cc
Replace /app/kibana#/management urls to /app/management
alexwizp May 20, 2020
52d17f0
Merge remote-tracking branch 'upstream/master' into management-routing
alexwizp May 20, 2020
a1c51d7
remove ui/public/management
alexwizp May 20, 2020
ec4cde3
fix some links to management apps
alexwizp May 20, 2020
fdd4ae1
Merge branch 'management-routing' of github.com:alexwizp/kibana into …
mattkime May 20, 2020
de5f17f
Merge branch 'master' into management-routing
mattkime May 20, 2020
a36359a
fix management url for functional tests
alexwizp May 20, 2020
817f458
add data-test-subj for EuiSideNavItem
alexwizp May 20, 2020
edc75a0
partial progress
mattkime May 20, 2020
660e1a1
Merge branch 'management-routing' of github.com:alexwizp/kibana into …
mattkime May 20, 2020
9cccf1c
fix some of ts issues
alexwizp May 21, 2020
5cff1a8
Fixed breadcrumbs for data index management
VladLasitsa May 21, 2020
bda4b31
[kibana/spaces] section
alexwizp May 21, 2020
d49c9f9
fix functional test
alexwizp May 21, 2020
c04d0b1
[role_management] fix Breadcrumbs
alexwizp May 21, 2020
57cfa83
[api_keys] fix Breadcrumbs and Navigation
alexwizp May 21, 2020
2eea223
Merge remote-tracking branch 'upstream/master' into management-routing
alexwizp May 21, 2020
470eed8
Fixed routing for remote cluster
VladLasitsa May 21, 2020
c3ee794
[role_mapping] Partial progress
alexwizp May 21, 2020
8bae450
Merge remote-tracking branch 'upstream/master' into management-routing
alexwizp May 22, 2020
b83afb5
Merge remote-tracking branch 'upstream/master' into management-routing
alexwizp May 22, 2020
e3fedb0
Merge remote-tracking branch 'upstream/master' into management-routing
alexwizp May 22, 2020
6f3d7ce
[users] partial progress
alexwizp May 22, 2020
0125637
[watcher] partial progress
alexwizp May 22, 2020
7fd1c2c
Merge remote-tracking branch 'upstream/master' into management-routing
alexwizp May 22, 2020
3d147a8
fix eslint issues
alexwizp May 22, 2020
821984e
[snapshot_restore] partial progress
alexwizp May 22, 2020
9c9f2d2
[rollup_jobs] partial progress
alexwizp May 22, 2020
09cd254
Fixed routing for cross cluster replications (partial progress). Enha…
VladLasitsa May 22, 2020
5dd58fe
Perf optimization: fix extra re-rendering
alexwizp May 22, 2020
61c113c
fix TS errors
alexwizp May 22, 2020
02bd880
x-pack fix config for functional tests
alexwizp May 22, 2020
7ade6a9
Fixed routing for index lifecycle management
VladLasitsa May 22, 2020
1b92827
fix some broken CI tests
alexwizp May 23, 2020
40f7560
fix PR comment
alexwizp May 23, 2020
ce54146
[snapshot_restore] move onClick into reactRouterNavigate
alexwizp May 23, 2020
240c0f6
fix some jest
alexwizp May 24, 2020
296a3f4
fix some functional tests
alexwizp May 24, 2020
c1f2f20
fix functiona test: management scripted fields testing regression fo…
alexwizp May 25, 2020
21391a5
fix some functional tests
alexwizp May 25, 2020
c8d3d77
[licence_management] partial progress
alexwizp May 25, 2020
c16471d
Merge remote-tracking branch 'upstream/master' into management-routing
alexwizp May 25, 2020
bf1ffd2
Merge remote-tracking branch 'upstream/master' into management-routing
alexwizp May 25, 2020
0c7b966
Fixed x-pack jest tests
VladLasitsa May 25, 2020
e470a47
[saved_object_management] partial progress
alexwizp May 25, 2020
8299e03
Fixed some tests
VladLasitsa May 25, 2020
d4ee163
fix functional test: should add new role myroleEast
alexwizp May 25, 2020
7ed4271
Reverted part of changes for ml
VladLasitsa May 25, 2020
86795ad
[transforms] partial progress
alexwizp May 25, 2020
7c584f3
Merge remote-tracking branch 'upstream/master' into management-routing
alexwizp May 25, 2020
3c1c19f
fix TS errors
alexwizp May 25, 2020
1d2878e
fix functional: redirects to Kibana home
alexwizp May 25, 2020
0b3cd49
add support of Backward compatibility
alexwizp May 26, 2020
1fe7fec
Merge remote-tracking branch 'upstream/master' into management-routing
alexwizp May 26, 2020
4d164e5
fix functional: Saved objects management feature controls saved objec…
alexwizp May 26, 2020
219cd55
fix PR comment
alexwizp May 26, 2020
d5a9731
fix TS issues
alexwizp May 26, 2020
cf96584
Fixed x-pack jest tests
VladLasitsa May 26, 2020
9d0c162
fix oss JEST
alexwizp May 26, 2020
96ec2a9
Fixed functional test
VladLasitsa May 26, 2020
de9be15
fix functional test
alexwizp May 26, 2020
5f86b5e
Merge remote-tracking branch 'upstream/master' into management-routing
alexwizp May 26, 2020
c0d6210
fix PR comment
alexwizp May 26, 2020
15cb522
Merge remote-tracking branch 'upstream/master' into management-routing
alexwizp May 27, 2020
95fc7d3
Merge remote-tracking branch 'upstream/master' into management-routing
alexwizp May 27, 2020
ac265f5
Fixed i18n
VladLasitsa May 27, 2020
81613a0
Merge remote-tracking branch 'upstream/master' into management-routing
alexwizp May 27, 2020
22634b2
fix typo
alexwizp May 28, 2020
08aff80
Merge remote-tracking branch 'upstream/master' into management-routing
alexwizp May 28, 2020
fe060ab
fix Styles
alexwizp May 28, 2020
325d357
Merge remote-tracking branch 'upstream/master' into management-routing
alexwizp May 28, 2020
ce4454b
Fixed paths for cross_cluster_replication
VladLasitsa May 28, 2020
5bccbc7
fix wrong link
alexwizp May 28, 2020
2085c6b
Fixed jest
VladLasitsa May 28, 2020
1eb1998
Merge branch 'master' into management-routing
elasticmachine May 29, 2020
2e86461
Fixed some comments
VladLasitsa May 29, 2020
89e8432
fix sorting
alexwizp May 29, 2020
e9e0456
fix type check
alexwizp May 29, 2020
14c9e5f
fixed x-pack jest
VladLasitsa May 29, 2020
e9182da
fixed x-pack jest
VladLasitsa May 29, 2020
4f7eb18
reverted using of parentHistory
VladLasitsa May 29, 2020
9f85728
Add debugging toasts to CCR.
cjcenizal May 29, 2020
933d765
Comment out non-CCR functional tests.
cjcenizal May 29, 2020
7fcec23
Fix typo.
cjcenizal May 29, 2020
e496bb0
Uncomment non-CCR functional tests.
cjcenizal May 29, 2020
3390711
Enable CCR.
cjcenizal May 31, 2020
ed525ad
Merge remote-tracking branch 'upstream/master' into management-routing
alexwizp May 31, 2020
2c83f8c
fix CI
alexwizp May 31, 2020
cb65612
Add comment to explain why CCR is enabled by default and move config …
cjcenizal May 31, 2020
d5fd104
Merge branch 'master' into management-routing
elasticmachine Jun 1, 2020
b042c8c
Merge branch 'master' into management-routing
alexwizp Jun 1, 2020
2efa4db
revert some changes in APM
alexwizp Jun 1, 2020
b8f7dc9
Merge branch 'master' into management-routing
elasticmachine Jun 2, 2020
66f795f
add space between index pattern name and tags
alexwizp Jun 2, 2020
fe61855
Merge remote-tracking branch 'upstream/master' into management-routing
alexwizp Jun 2, 2020
6e49fe3
Merge remote-tracking branch 'upstream/master' into management-routing
alexwizp Jun 2, 2020
6f1f560
fix function test
alexwizp Jun 2, 2020
7129133
Update x-pack/plugins/security/public/management/management_urls.ts
alexwizp Jun 3, 2020
88c584d
Update x-pack/plugins/security/public/management/api_keys/api_keys_ma…
alexwizp Jun 3, 2020
5730176
Update x-pack/plugins/spaces/public/management/spaces_management_app.tsx
alexwizp Jun 3, 2020
6ee39a8
Update x-pack/plugins/security/public/management/roles/roles_manageme…
alexwizp Jun 3, 2020
88b168d
Update x-pack/plugins/security/public/management/users/users_manageme…
alexwizp Jun 3, 2020
09f8ce6
Update x-pack/plugins/security/public/management/management_urls.ts
alexwizp Jun 3, 2020
0f6774f
Update x-pack/plugins/security/public/management/management_urls.ts
alexwizp Jun 3, 2020
2d37347
[security] getUrlForApp -> navigateToApp
alexwizp Jun 3, 2020
56b22d7
Merge remote-tracking branch 'upstream/master' into management-routing
alexwizp Jun 3, 2020
155c65f
[mp] fix Uncaught (in promise) undefined
alexwizp Jun 3, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion src/core/server/ui_settings/saved_objects/ui_settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export const uiSettingsType: SavedObjectsType = {
importableAndExportable: true,
getInAppUrl() {
return {
path: `/app/kibana#/management/kibana/settings`,
path: `/app/management/kibana/settings`,
uiCapabilitiesPath: 'advancedSettings.show',
};
},
Expand Down
17 changes: 2 additions & 15 deletions src/legacy/core_plugins/kibana/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ import { exportApi } from './server/routes/api/export';
import { getUiSettingDefaults } from './server/ui_setting_defaults';
import { registerCspCollector } from './server/lib/csp_usage_collector';
import { injectVars } from './inject_vars';
import { i18n } from '@kbn/i18n';
import { DEFAULT_APP_CATEGORIES } from '../../../../src/core/server';

import { kbnBaseUrl } from '../../../plugins/kibana_legacy/server';

const mkdirAsync = promisify(Fs.mkdir);
Expand All @@ -53,19 +52,7 @@ export default function (kibana) {
main: 'plugins/kibana/kibana',
},
styleSheetPaths: resolve(__dirname, 'public/index.scss'),
links: [
{
id: 'kibana:stack_management',
title: i18n.translate('kbn.managementTitle', {
defaultMessage: 'Stack Management',
}),
order: 9003,
url: `${kbnBaseUrl}#/management`,
euiIconType: 'managementApp',
linkToLastSubUrl: false,
category: DEFAULT_APP_CATEGORIES.management,
},
],
links: [],

injectDefaultVars(server, options) {
const mapConfig = server.config().get('map');
Expand Down
83 changes: 0 additions & 83 deletions src/legacy/core_plugins/kibana/public/.eslintrc.js

This file was deleted.

Empty file.
7 changes: 6 additions & 1 deletion src/legacy/core_plugins/kibana/public/kibana.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,22 @@ import 'uiExports/shareContextMenuExtensions';
import 'uiExports/interpreter';

import 'ui/autoload/all';
import './management';

import { localApplicationService } from './local_application_service';

npSetup.plugins.kibanaLegacy.registerLegacyAppAlias('doc', 'discover', { keepPrefix: true });
npSetup.plugins.kibanaLegacy.registerLegacyAppAlias('context', 'discover', { keepPrefix: true });

npSetup.plugins.kibanaLegacy.forwardApp('management', 'management', (path) => {
return path.replace('/management', '');
});

Comment on lines +47 to +50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this legacy app to the kibana_legacy plugin in KP? That way the redirects don't require a second full-page refresh. Could be done in a follow up.

\cc @flash1293

localApplicationService.attachToAngular(routes);

routes.enable();

const { config } = npSetup.plugins.kibanaLegacy;

routes.otherwise({
redirectTo: `/${config.defaultAppId || 'discover'}`,
});

This file was deleted.

4 changes: 0 additions & 4 deletions src/legacy/core_plugins/kibana/public/management/app.html

This file was deleted.

166 changes: 0 additions & 166 deletions src/legacy/core_plugins/kibana/public/management/index.js

This file was deleted.

Loading