-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Index Management] Support Hidden Indices #66422
[Index Management] Support Hidden Indices #66422
Conversation
Tests probably have broken
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
Also remove unused translations
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested locally and works as expected. Great job @jloleysens !
The only thing left is to find out if my concerns about performance with the GET /<indices>
API on big clusters is founded.
@@ -33,12 +33,12 @@ export const tableState = handleActions( | |||
currentPage: 0, | |||
}; | |||
}, | |||
[showSystemIndicesChanged](state, action) { | |||
const { showSystemIndices } = action.payload; | |||
[showHiddenIndicesChanged](state, action) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this also feel like you're reading the docs? 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂 quite!
}, | ||
}); | ||
|
||
if (!Object.keys(indices).length) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we know that the GET /<indices>
is slower than the _cat/indices
, we might better then fetch first the cat indices and exit early from there. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spoke to @danhermann about this, he mentioned that both _cat/indices
and /<indices>
would suffer a performance hit on clusters with many indices + shards but that there is a new endpoint that will support this being built #64858 we can use that will be released soon. We can review after it is available - perhaps we will need to remove some values we have in the table at the moment.
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* First iteration of supporting hidden indices in indices table Tests probably have broken * Remove unused code * Fix logic when calling get index endpoint with empty array Also remove unused translations * More terse! Co-authored-by: Elastic Machine <[email protected]>
…ent/add-support-in-url-for-hidden-toggle * 'master' of github.com:elastic/kibana: (34 commits) [SIEM][CASE] Fix bug when connector is deleted. (elastic#65876) [SIEM][CASE] Improve layout (elastic#66232) [Index Management] Support Hidden Indices (elastic#66422) Add Login Selector functional tests. (elastic#65705) Lens drilldowns (elastic#65675) [ML] Custom template for apiDoc markdown (elastic#66567) Don't bootstrap core type emits (elastic#66377) [Dashboard] Improve loading error handling (elastic#66372) [APM] Minor style fixes for the node strokes (elastic#66574) [Ingest Manager] Fix create data source from integration (elastic#66626) [Metrics UI] Fix default metric alert interval for new conditions (elastic#66610) [Metrics UI] Fix alignment and allow clearing metric value (elastic#66589) Don't return package name for non-package data streams (elastic#66606) [Ingest Manager] Consolidate routing and add breadcrumbs to all pages (elastic#66475) [Docs/Reporting] Have the docs about granular timeout match Cloud docs (elastic#66267) Don't automatically add license header to code inside plugins dir. (elastic#66601) [APM] Don't trigger map layout if no elements (elastic#66625) [Logs UI] Validate ML job setup time ranges (elastic#66426) Fix pagination bugs in CCR and Remote Clusters (elastic#65931) Add cloud icon for supported settings and embed single-sourced getting started (elastic#65610) ... # Conflicts: # x-pack/plugins/index_management/public/application/sections/home/index_list/index_table/index_table.js # x-pack/plugins/index_management/server/lib/fetch_indices.ts
* First iteration of supporting hidden indices in indices table Tests probably have broken * Remove unused code * Fix logic when calling get index endpoint with empty array Also remove unused translations * More terse! Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Summary
Fix #56532
Adds support for showing hidden indices in Index Management which replaces the notion of system indices in the UI.
How to test
See the linked issue for more details, but essentially:
It would be good to test any other logic that perhaps uses the fetch_indices logic, but because our external contract has not changed this should not affect any enrich consumers.
Checklist
Delete any items that are not applicable to this PR.
For maintainers