Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix vertical overflow on Single Metric Viewer page #66413

Merged
merged 2 commits into from
May 13, 2020
Merged

[ML] Fix vertical overflow on Single Metric Viewer page #66413

merged 2 commits into from
May 13, 2020

Conversation

darnautov
Copy link
Contributor

Summary

  • Fix double vertical page overflow that caused 2 scrollbars appeared on the Single Metric Viewer page.
  • Fix tiny chart tooltip overlap by a scrollbar.

Before:

image

After:
image

@darnautov darnautov requested review from a team as code owners May 13, 2020 13:59
@darnautov darnautov self-assigned this May 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

alvarezmelissa87
alvarezmelissa87 approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@darnautov darnautov merged commit 69d4199 into elastic:master May 13, 2020
@darnautov darnautov deleted the ML-fix-scrollbar branch May 13, 2020 16:16
@darnautov darnautov mentioned this pull request May 13, 2020
Merged
darnautov added a commit to darnautov/kibana that referenced this pull request May 13, 2020
@darnautov
[ML] Fix vertical overflow on Single Metric Viewer page (elastic#66413)
c3ffea3 
* [ML] fix page overflow

* [ML] fix tooltip overflow
@darnautov darnautov mentioned this pull request May 13, 2020
Merged
darnautov added a commit to darnautov/kibana that referenced this pull request May 13, 2020
@darnautov
[ML] Fix vertical overflow on Single Metric Viewer page (elastic#66413)
3243204 
* [ML] fix page overflow

* [ML] fix tooltip overflow
darnautov added a commit that referenced this pull request May 13, 2020
@darnautov
[ML] Fix vertical overflow on Single Metric Viewer page (#66413) (#66436
91aadb7 
)

* [ML] fix page overflow

* [ML] fix tooltip overflow
darnautov added a commit that referenced this pull request May 14, 2020
@darnautov
[ML] Fix vertical overflow on Single Metric Viewer page (#66413) (#66437
892eea0 
)

* [ML] fix page overflow

* [ML] fix tooltip overflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees

@darnautov darnautov

Labels
:ml release_note:fix v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@darnautov @elasticmachine @kibanamachine @alvarezmelissa87 @peteharverson