Report page load asset size #66224

dmlemeshko · 2020-05-12T13:56:22Z

Summary

Using puppeteer and CDP client to get size of each resource loaded during app navigation.

Since the goal is to determine which assets are always loaded regardless of the application, we load several apps across Kibana. We only report the assets that appear on in all the apps, ignoring the app-specific ones.

Only a few requests contain "content-length" header, we cannot use puppeteer-only approach with request interception. We use CDP event listeners as an alternative.

Still response in CDP has encodedDataLength and we can get it via puppeteer.
Turned out, there is a DevTools bug that encodedDataLength includes headers size, so I'm using approach suggested here

Update: It turned out that the proper way to get size is to sum data length chunks for the same request-id.

Start Kibana/ES: x-pack: node scripts/functional_tests_server.js --config test/page_load_metrics/config.ts

Capture and print out metrics (local run): node scripts/page_load_metrics.js --kibana-url=http://localhost:5620

#65524

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

…le-sizes

src/dev/performance/ingest_metrics.ts

package.json

scripts/performance_tests.js

src/dev/performance/ingest_metrics.ts

src/dev/performance/navigation.ts

src/dev/performance/ingest_metrics.ts

Co-authored-by: Spencer <[email protected]>

…le-sizes

…ana into ftr/report-all-file-sizes

packages/kbn-test/src/page_load_metrics/capture_page_load_metrics.ts

spalger · 2020-05-29T00:16:01Z

@elasticmachine merge upstream

…ics.ts Co-authored-by: Spencer <[email protected]>

…ana into ftr/report-all-file-sizes

…le-sizes

spalger · 2020-06-04T21:45:43Z

packages/kbn-test/src/page_load_metrics/navigation.ts

+export interface NavigationOptions {
+  headless: boolean;
+  appConfig: { url: string; username: string; password: string };
+  screenshotsDir?: string;


Can we please require this option and only define the default in the CLI?

Done in fec3c4e

spalger · 2020-06-04T21:47:17Z

packages/kbn-test/src/page_load_metrics/navigation.ts

+  dataLength: number;
+}
+
+function joinPath(pathA: string, pathB: string) {


The issue with Url.resolve() is that it resets the path if the second segment starts with a /, it's not really a join equivalent.

spalger · 2020-06-04T21:48:10Z

x-pack/test/page_load_metrics/config.ts

+    esArchiver: {
+      directory: resolve(__dirname, 'es_archives'),
+    },


We should define screenshots.directory here too.

dmlemeshko · 2020-06-05T12:57:17Z

@spalger I found the reason for flakiness:
Navigating to http://localhost:5620/app/maps actually may have 2 results:
new map page: http://localhost:5620/app/maps#/map?_g=(filters:!(),refreshInterval:(pause:!f,value:0),time:(from:now-15m,to:now))&_a=(filters:!(),query:(language:kuery,query:''))
landing page: http://localhost:5620/app/maps#/?_g=()

The 2nd result happens rarely, but I was able to get it locally running the same script. I updated the locator in d6ee29b to be the common between those 2 pages.

spalger · 2020-06-05T14:28:45Z

@spalger I found the reason for flakiness:
Navigating to http://localhost:5620/app/maps actually may have 2 results:
new map page: http://localhost:5620/app/maps#/map?_g=(filters:!(),refreshInterval:(pause:!f,value:0),time:(from:now-15m,to:now))&_a=(filters:!(),query:(language:kuery,query:''))
landing page: http://localhost:5620/app/maps#/?_g=()

The 2nd result happens rarely, but I was able to get it locally running the same script. I updated the locator in d6ee29b to be the common between those 2 pages.

@elastic/kibana-gis Is this expected behavior?

kibanamachine · 2020-06-05T14:30:15Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: d6ee29b

History

💚 Build #51881 succeeded a19828f
💔 Build #51845 failed ecdb569
💔 Build #51816 failed 6cfa219
💔 Build #51759 failed 3007539
💚 Build #51665 succeeded f440143

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nreese · 2020-06-05T14:36:51Z

@elastic/kibana-gis Is this expected behavior?

Yes. the route http://localhost:5620/app/maps resolves to maps listing page when one or more maps saved object exists. The route http://localhost:5620/app/maps routes to a new map when there are no maps saved objects. The thinking was, why send users to an empty listing page that then requires them to click "New map". Why not just directly send them to a new map.

* performance_tests: draft version * update cli runner and script * ingest metrics * save asset type for plugins * Update src/dev/performance/ingest_metrics.ts Co-authored-by: Spencer <[email protected]> * follow review comments * fix size calc, add FTR config, move src to kbn/test * fix import, remove unused interface * Update packages/kbn-test/src/page_load_metrics/capture_page_load_metrics.ts Co-authored-by: Spencer <[email protected]> * start chromium with no-sandbox * add logging * check page contains expected element, cut apps to 5 * fix locator & typo * Update packages/kbn-test/src/page_load_metrics/navigation.ts Co-authored-by: Spencer <[email protected]> * Update navigation.ts * Update navigation.ts * bump puppeteer version * fix typo * update navigation script * update config file * update yarn.lock * fix * take screenshot on failure * update screenshot title * fix screenshot saving and error * invalid locator * Revert "invalid locator" This reverts commit 3007539. * run script in a loop 10 times * Revert "run script in a loop 10 times" This reverts commit 6cfa219. * path config value directly * fix screenshots directory setup * update maps locator, common for landing and new map Co-authored-by: Spencer <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Mikhail Shustov <[email protected]>

* performance_tests: draft version * update cli runner and script * ingest metrics * save asset type for plugins * Update src/dev/performance/ingest_metrics.ts Co-authored-by: Spencer <[email protected]> * follow review comments * fix size calc, add FTR config, move src to kbn/test * fix import, remove unused interface * Update packages/kbn-test/src/page_load_metrics/capture_page_load_metrics.ts Co-authored-by: Spencer <[email protected]> * start chromium with no-sandbox * add logging * check page contains expected element, cut apps to 5 * fix locator & typo * Update packages/kbn-test/src/page_load_metrics/navigation.ts Co-authored-by: Spencer <[email protected]> * Update navigation.ts * Update navigation.ts * bump puppeteer version * fix typo * update navigation script * update config file * update yarn.lock * fix * take screenshot on failure * update screenshot title * fix screenshot saving and error * invalid locator * Revert "invalid locator" This reverts commit 3007539. * run script in a loop 10 times * Revert "run script in a loop 10 times" This reverts commit 6cfa219. * path config value directly * fix screenshots directory setup * update maps locator, common for landing and new map Co-authored-by: Spencer <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Mikhail Shustov <[email protected]> # Conflicts: # Jenkinsfile

* performance_tests: draft version * update cli runner and script * ingest metrics * save asset type for plugins * Update src/dev/performance/ingest_metrics.ts Co-authored-by: Spencer <[email protected]> * follow review comments * fix size calc, add FTR config, move src to kbn/test * fix import, remove unused interface * Update packages/kbn-test/src/page_load_metrics/capture_page_load_metrics.ts Co-authored-by: Spencer <[email protected]> * start chromium with no-sandbox * add logging * check page contains expected element, cut apps to 5 * fix locator & typo * Update packages/kbn-test/src/page_load_metrics/navigation.ts Co-authored-by: Spencer <[email protected]> * Update navigation.ts * Update navigation.ts * bump puppeteer version * fix typo * update navigation script * update config file * update yarn.lock * fix * take screenshot on failure * update screenshot title * fix screenshot saving and error * invalid locator * Revert "invalid locator" This reverts commit 3007539. * run script in a loop 10 times * Revert "run script in a loop 10 times" This reverts commit 6cfa219. * path config value directly * fix screenshots directory setup * update maps locator, common for landing and new map Co-authored-by: Spencer <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Mikhail Shustov <[email protected]> Co-authored-by: Spencer <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Mikhail Shustov <[email protected]>

* Report page load asset size (#66224) * performance_tests: draft version * update cli runner and script * ingest metrics * save asset type for plugins * Update src/dev/performance/ingest_metrics.ts Co-authored-by: Spencer <[email protected]> * follow review comments * fix size calc, add FTR config, move src to kbn/test * fix import, remove unused interface * Update packages/kbn-test/src/page_load_metrics/capture_page_load_metrics.ts Co-authored-by: Spencer <[email protected]> * start chromium with no-sandbox * add logging * check page contains expected element, cut apps to 5 * fix locator & typo * Update packages/kbn-test/src/page_load_metrics/navigation.ts Co-authored-by: Spencer <[email protected]> * Update navigation.ts * Update navigation.ts * bump puppeteer version * fix typo * update navigation script * update config file * update yarn.lock * fix * take screenshot on failure * update screenshot title * fix screenshot saving and error * invalid locator * Revert "invalid locator" This reverts commit 3007539. * run script in a loop 10 times * Revert "run script in a loop 10 times" This reverts commit 6cfa219. * path config value directly * fix screenshots directory setup * update maps locator, common for landing and new map Co-authored-by: Spencer <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Mikhail Shustov <[email protected]> # Conflicts: # Jenkinsfile * [page_load_metrics] fix path for discover * fix url formatting * fix screenshot title

dmlemeshko · 2020-06-06T07:31:48Z

7.x 8e50e59
7.8 b6d6889

* master: (57 commits) Add app arch team as owner of datemath package (elastic#66880) [Observability] Landing page for Observability (elastic#67467) [SIEM] Fix timeline buildGlobalQuery (elastic#68320) Optimize saved objects getScopedClient and HTTP API (elastic#68221) [Maps] Fix mb-style interpolate style rule (elastic#68413) update script to always download node (elastic#68421) [SECURITY SOLEIL] Fix selection of event type when no siem index signal created (elastic#68291) [DOCS] Adds note about configuring File Data Visualizer (elastic#68407) [DOCS] Adds link from remote clusters to index patterns (elastic#68406) [QA] slack notify on failure (elastic#68126) upgrade eslint-plugin-react-hooks from 2.3.0 to 4.0.4 (elastic#68295) moving to jira to a gold license (elastic#67178) [DOCS] Revises doc on adding data (elastic#68038) [APM] Add ThemeProvider to support dark mode (elastic#68242) Make welcome screen disabling first action in loginIfPrompted (elastic#68238) [QA] Code coverage: unskip tests, collect tests results, exclude bundles from report (elastic#64477) [ML] Functional tests - disable flaky regression and classification creation test [Alerting] change eventLog ILM requests to absolute URLs (elastic#68331) Report page load asset size (elastic#66224) [SIEM][CASE] Change SIEM to Security (elastic#68365) ...

This reverts commit 6f57fa0.

* Revert "Report page load asset size (#66224)" This reverts commit 6f57fa0. * [kbn/optimizer] report sizes of assets produced by optimizer * coalese the fast-glob versions we're using to prevent additional installs * update kbn/pm dist * Revert "update kbn/pm dist" This reverts commit 68e24f0. * Revert "coalese the fast-glob versions we're using to prevent additional installs" This reverts commit 4201fb6. * remove fast-glob, just recursivly call readdirSync() * update integration tests to use new chunk filename Co-authored-by: spalger <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

…#71319) * Revert "Report page load asset size (elastic#66224)" This reverts commit 6f57fa0. * [kbn/optimizer] report sizes of assets produced by optimizer * coalese the fast-glob versions we're using to prevent additional installs * update kbn/pm dist * Revert "update kbn/pm dist" This reverts commit 68e24f0. * Revert "coalese the fast-glob versions we're using to prevent additional installs" This reverts commit 4201fb6. * remove fast-glob, just recursivly call readdirSync() * update integration tests to use new chunk filename Co-authored-by: spalger <[email protected]> Co-authored-by: Elastic Machine <[email protected]> # Conflicts: # packages/kbn-optimizer/src/integration_tests/basic_optimization.test.ts # yarn.lock

performance_tests: draft version

37365bf

dmlemeshko changed the title ~~[skip ci ] report all file sizes loaded on Kibana page~~ [skip ci] report all file sizes loaded on Kibana page May 12, 2020

dmlemeshko added 5 commits May 14, 2020 16:25

Merge remote-tracking branch 'upstream/master' into ftr/report-all-fi…

bf24b82

…le-sizes

Merge remote-tracking branch 'upstream/master' into ftr/report-all-fi…

4b1a9e0

…le-sizes

update cli runner and script

ba5f384

ingest metrics

8e9f0b1

save asset type for plugins

d4e2f0c

dmlemeshko commented May 19, 2020

View reviewed changes

src/dev/performance/ingest_metrics.ts Outdated Show resolved Hide resolved

spalger reviewed May 19, 2020

View reviewed changes

src/dev/performance/ingest_metrics.ts Outdated Show resolved Hide resolved

dmlemeshko changed the title ~~[skip ci] report all file sizes loaded on Kibana page~~ report all file sizes loaded on Kibana page May 19, 2020

mshustov reviewed May 19, 2020

View reviewed changes

dmlemeshko and others added 6 commits May 19, 2020 19:17

Update src/dev/performance/ingest_metrics.ts

fc06477

Co-authored-by: Spencer <[email protected]>

Merge remote-tracking branch 'upstream/master' into ftr/report-all-fi…

6b9e68c

…le-sizes

follow review comments

1551910

Merge branch 'ftr/report-all-file-sizes' of github.com:dmlemeshko/kib…

816cb4b

…ana into ftr/report-all-file-sizes

fix size calc, add FTR config, move src to kbn/test

bebd189

fix import, remove unused interface

4aa25a6

spalger reviewed May 29, 2020

View reviewed changes

packages/kbn-test/src/page_load_metrics/capture_page_load_metrics.ts Outdated Show resolved Hide resolved

elasticmachine and others added 5 commits May 28, 2020 17:16

Merge branch 'master' into ftr/report-all-file-sizes

fb37a19

Update packages/kbn-test/src/page_load_metrics/capture_page_load_metr…

d9133d3

…ics.ts Co-authored-by: Spencer <[email protected]>

start chromium with no-sandbox

1d4cb34

Merge branch 'ftr/report-all-file-sizes' of github.com:dmlemeshko/kib…

cf8dd9c

…ana into ftr/report-all-file-sizes

add logging

f379b60

dmlemeshko added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels May 29, 2020

dmlemeshko requested review from spalger and mshustov May 29, 2020 07:31

dmlemeshko marked this pull request as ready for review May 29, 2020 07:31

dmlemeshko requested a review from a team as a code owner May 29, 2020 07:31

Merge branch 'ftr/report-all-file-sizes' of github.com:dmlemeshko/kib…

a6946e0

…ana into ftr/report-all-file-sizes

dmlemeshko requested a review from spalger June 4, 2020 17:37

dmlemeshko added 2 commits June 4, 2020 20:11

Merge remote-tracking branch 'upstream/master' into ftr/report-all-fi…

ddc5617

…le-sizes

path config value directly

a19828f

spalger suggested changes Jun 4, 2020

View reviewed changes

spalger removed the backport:skip This commit does not require backporting label Jun 4, 2020

dmlemeshko added 2 commits June 5, 2020 14:30

fix screenshots directory setup

fec3c4e

update maps locator, common for landing and new map

d6ee29b

dmlemeshko requested a review from spalger June 5, 2020 13:06

spalger approved these changes Jun 5, 2020

View reviewed changes

dmlemeshko merged commit 6f57fa0 into elastic:master Jun 5, 2020

dmlemeshko mentioned this pull request Jun 5, 2020

[7.x] Report page load asset size (#66224) #68383

Merged

dmlemeshko mentioned this pull request Jun 5, 2020

[7.8] Report page load asset size (#66224) #68387

Merged

spalger mentioned this pull request Jun 10, 2020

Kibana build and performance benchmarking #68798

Closed

7 tasks

spalger added a commit to spalger/kibana that referenced this pull request Jul 9, 2020

Revert "Report page load asset size (elastic#66224)"

cac0717

This reverts commit 6f57fa0.

This was referenced Jul 9, 2020

[kbn/optimizer] report sizes of assets produced by optimizer #71319

Merged

[operations] Track changes to important metrics in CI builds #65504

Closed

dmlemeshko deleted the ftr/report-all-file-sizes branch January 31, 2022 12:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Report page load asset size #66224

Report page load asset size #66224

dmlemeshko commented May 12, 2020 •

edited

Loading

spalger commented May 29, 2020

spalger Jun 4, 2020

dmlemeshko Jun 5, 2020

spalger Jun 4, 2020

spalger Jun 4, 2020

dmlemeshko commented Jun 5, 2020 •

edited

Loading

spalger commented Jun 5, 2020

kibanamachine commented Jun 5, 2020

nreese commented Jun 5, 2020 •

edited

Loading

dmlemeshko commented Jun 6, 2020

Report page load asset size #66224

Report page load asset size #66224

Conversation

dmlemeshko commented May 12, 2020 • edited Loading

Summary

Checklist

For maintainers

spalger commented May 29, 2020

spalger Jun 4, 2020

Choose a reason for hiding this comment

dmlemeshko Jun 5, 2020

Choose a reason for hiding this comment

spalger Jun 4, 2020

Choose a reason for hiding this comment

spalger Jun 4, 2020

Choose a reason for hiding this comment

dmlemeshko commented Jun 5, 2020 • edited Loading

spalger commented Jun 5, 2020

kibanamachine commented Jun 5, 2020

💚 Build Succeeded

History

nreese commented Jun 5, 2020 • edited Loading

dmlemeshko commented Jun 6, 2020

dmlemeshko commented May 12, 2020 •

edited

Loading

dmlemeshko commented Jun 5, 2020 •

edited

Loading

nreese commented Jun 5, 2020 •

edited

Loading