Remove Newsfeed leftovers from the Legacy codebase

src/plugins/newsfeed/public/components/flyout_list.tsx

@@ -33,7 +33,7 @@ import {
 } from '@elastic/eui';
 import { FormattedMessage } from '@kbn/i18n/react';
 import { NewsfeedContext } from './newsfeed_header_nav_button';
-import { NewsfeedItem } from '../../types';
+import { NewsfeedItem } from '../types';
 import { NewsEmptyPrompt } from './empty_news';
 import { NewsLoadingPrompt } from './loading_news';
 

src/plugins/newsfeed/public/components/newsfeed_header_nav_button.tsx

@@ -21,7 +21,7 @@ import React, { useState, Fragment, useEffect } from 'react';
 import * as Rx from 'rxjs';
 import { EuiHeaderSectionItemButton, EuiIcon, EuiNotificationBadge } from '@elastic/eui';
 import { NewsfeedFlyout } from './flyout_list';
-import { FetchResult } from '../../types';
+import { FetchResult } from '../types';
 
 export interface INewsfeedContext {
   setFlyoutVisible: React.Dispatch<React.SetStateAction<boolean>>;

src/plugins/newsfeed/public/lib/api.test.ts

@@ -26,7 +26,7 @@ import {
   NEWSFEED_HASH_SET_STORAGE_KEY,
   NEWSFEED_LAST_FETCH_STORAGE_KEY,
 } from '../../common/constants';
-import { ApiItem, NewsfeedItem, NewsfeedPluginBrowserConfig } from '../../types';
+import { ApiItem, NewsfeedItem, NewsfeedPluginBrowserConfig } from '../types';
 import { NewsfeedApiDriver, getApi } from './api';
 
 const localStorageGet = sinon.stub();

src/plugins/newsfeed/public/lib/api.ts

@@ -27,7 +27,7 @@ import {
   NEWSFEED_LAST_FETCH_STORAGE_KEY,
   NEWSFEED_HASH_SET_STORAGE_KEY,
 } from '../../common/constants';
-import { ApiItem, NewsfeedItem, FetchResult, NewsfeedPluginBrowserConfig } from '../../types';
+import { ApiItem, NewsfeedItem, FetchResult, NewsfeedPluginBrowserConfig } from '../types';
 
 type ApiConfig = NewsfeedPluginBrowserConfig['service'];
 
@@ -171,10 +171,10 @@ export function getApi(
   kibanaVersion: string
 ): Rx.Observable<void | FetchResult> {
   const userLanguage = i18n.getLocale();
-  const fetchInterval = config.fetchInterval;
+  const fetchInterval = config.fetchInterval.asMilliseconds();
   const driver = new NewsfeedApiDriver(kibanaVersion, userLanguage, fetchInterval);
 
-  return Rx.timer(0, config.mainInterval).pipe(
+  return Rx.timer(0, config.mainInterval.asMilliseconds()).pipe(
     filter(() => driver.shouldFetch()),
     mergeMap(() =>
       driver.fetchNewsfeedItems(http, config.service).pipe(

src/plugins/newsfeed/public/plugin.tsx

@@ -21,9 +21,10 @@ import * as Rx from 'rxjs';
 import { catchError, takeUntil } from 'rxjs/operators';
 import ReactDOM from 'react-dom';
 import React from 'react';
+import moment from 'moment';
 import { I18nProvider } from '@kbn/i18n/react';
 import { PluginInitializerContext, CoreSetup, CoreStart, Plugin } from 'src/core/public';
-import { NewsfeedPluginBrowserConfig } from '../types';
+import { NewsfeedPluginBrowserConfig } from './types';
 import { NewsfeedNavButton, NewsfeedApiFetchResult } from './components/newsfeed_header_nav_button';
 import { getApi } from './lib/api';
 
@@ -36,8 +37,14 @@ export class NewsfeedPublicPlugin implements Plugin<Setup, Start> {
   private readonly stop$ = new Rx.ReplaySubject(1);
 
   constructor(initializerContext: PluginInitializerContext<NewsfeedPluginBrowserConfig>) {
-    this.config = initializerContext.config.get();
     this.kibanaVersion = initializerContext.env.packageInfo.version;
+    const config = initializerContext.config.get();
+    this.config = Object.freeze({
+      ...config,
+      // We need wrap them in moment.duration because exposeToBrowser stringifies it.
+      mainInterval: moment.duration(config.mainInterval),
+      fetchInterval: moment.duration(config.fetchInterval),
+    });
   }
 
   public setup(core: CoreSetup): Setup {

src/plugins/newsfeed/types.ts → src/plugins/newsfeed/public/types.ts

@@ -17,16 +17,16 @@
  * under the License.
  */
 
-import { Moment } from 'moment';
+import { Duration, Moment } from 'moment';
 
 // Ideally, we may want to obtain the type from the configSchema and exposeToBrowser keys...
 export interface NewsfeedPluginBrowserConfig {
   service: {
     urlRoot: string;
     pathTemplate: string;
   };
-  mainInterval: number; // how often to check last updated time
-  fetchInterval: number; // how often to fetch remote service and set last updated
+  mainInterval: Duration; // how often to check last updated time
+  fetchInterval: Duration; // how often to fetch remote service and set last updated
 }
 
 export interface ApiItem {