Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Remove the legacy Ingest Manager plugin #65534

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

jfsiii
Copy link
Contributor

@jfsiii jfsiii commented May 6, 2020

The last thing we were using from it was configuring a static assets directory (which is only used for the EPM Integrations header graphic).

This is now provided by Platform and is not configurable.

This PR moves the header assets to the new directory & updates the toAssets helper

@jfsiii jfsiii added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 Team:Fleet Team label for Observability Data Collection Fleet team labels May 6, 2020
@jfsiii jfsiii requested a review from a team May 6, 2020 18:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@jfsiii
Copy link
Contributor Author

jfsiii commented May 6, 2020

I added the 7.8 label but I'm not sure if it should be backported. I'll add @joshdover who pinged me about this.

@jfsiii jfsiii requested a review from joshdover May 6, 2020 18:05
@joshdover
Copy link
Contributor

I added the 7.8 label but I'm not sure if it should be backported. I'll add @joshdover who pinged me about this.

I don't see any reason to backport. No sense in adding risk to that release since we're past FF

Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, did not test locally

Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, I'll update the label to 7.9 as I agree that we don't need to backport this to 7.8

@jen-huang jen-huang added v7.9.0 and removed v7.8.0 labels May 6, 2020
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see the last legacy bit be removed!

@jfsiii
Copy link
Contributor Author

jfsiii commented Jun 29, 2020

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

The last thing we were using from it was configuring a static assets directory (which is only use for the EPM Integrations header graphic).

This is now provided by platform and is not configurable https://github.com/elastic/kibana/blob/da28df5b154bd8223124b1814f5b350b842c309d/src/core/MIGRATION.md#L1344

Moved the header assets to the new directory & updated the `toAssets` helper
@jfsiii jfsiii force-pushed the remote-legacy-ingest-manager-plugin branch from cd28471 to 390c547 Compare July 6, 2020 17:42
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

  • 💚 Build #46057 succeeded cd284717b457105f2f016329fda0a8a6a47f3840

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jfsiii jfsiii merged commit ee06536 into elastic:master Jul 6, 2020
jfsiii pushed a commit that referenced this pull request Jul 7, 2020
The last thing we were using from it was configuring a static assets directory (which is only use for the EPM Integrations header graphic).

This is now provided by platform and is not configurable https://github.com/elastic/kibana/blob/da28df5b154bd8223124b1814f5b350b842c309d/src/core/MIGRATION.md#L1344

Moved the header assets to the new directory & updated the `toAssets` helper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants