-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest Manager] Remove the legacy Ingest Manager plugin #65534
[Ingest Manager] Remove the legacy Ingest Manager plugin #65534
Conversation
Pinging @elastic/ingest-management (Team:Ingest Management) |
I added the 7.8 label but I'm not sure if it should be backported. I'll add @joshdover who pinged me about this. |
I don't see any reason to backport. No sense in adding risk to that release since we're past FF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, did not test locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, I'll update the label to 7.9 as I agree that we don't need to backport this to 7.8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see the last legacy bit be removed!
@elasticmachine merge upstream |
merge conflict between base and head |
The last thing we were using from it was configuring a static assets directory (which is only use for the EPM Integrations header graphic). This is now provided by platform and is not configurable https://github.com/elastic/kibana/blob/da28df5b154bd8223124b1814f5b350b842c309d/src/core/MIGRATION.md#L1344 Moved the header assets to the new directory & updated the `toAssets` helper
cd28471
to
390c547
Compare
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
The last thing we were using from it was configuring a static assets directory (which is only use for the EPM Integrations header graphic). This is now provided by platform and is not configurable https://github.com/elastic/kibana/blob/da28df5b154bd8223124b1814f5b350b842c309d/src/core/MIGRATION.md#L1344 Moved the header assets to the new directory & updated the `toAssets` helper
The last thing we were using from it was configuring a static assets directory (which is only used for the EPM Integrations header graphic).
This is now provided by Platform and is not configurable.
This PR moves the header assets to the new directory & updates the
toAssets
helper