Kibana 5 Settings Redesign #6527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added breadcrumbs to the Settings and Visualize tabs.
|
| <ul> | ||
| <li ng-repeat="crumb in crumbs"> | ||
| <a ng-href="{{ makeUrl(crumb) }}">{{crumb}}</a> | ||
| <span ng-hide="$index === (crumbs.length - 1)"> / </span> |
|
Also, can you merge in feature/design so we can make sure the tests are passing? |
| import expect from 'expect.js'; | ||
|
|
||
| import kbnAngular from '../angular'; | ||
| import TabFakeStore from '../../__tests__/_TabFakeStore'; |
There was a problem hiding this comment.
Looks like this file is missing
There was a problem hiding this comment.
@panda01 That test file seems incomplete. Has this been updated on your branch? Should I merge in your updates?
|
@panda01 the tests have passed so its ready to be reviewed again. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesign for Settings Page.
Currently, this pull only lines up the navbar with the kibana logo in the sidebar.
As we continue to iterate on the Design for the Settings page, this pull request will need to be updated.