-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Consolidating shared types and util functions #65247
[ML] Consolidating shared types and util functions #65247
Conversation
@elasticmachine merge upstream |
user doesn't have permission to update head repository |
a2b8921
to
fe80f32
Compare
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⚡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I will follow up with a PR that cleans up the transform plugin in that regard too.
@elasticmachine merge upstream |
user doesn't have permission to update head repository |
1d7e9d0
to
dd4faea
Compare
Pinging @elastic/uptime (Team:uptime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uptime changes LGTM
@elasticmachine merge upstream |
user doesn't have permission to update head repository |
@elasticmachine merge upstream |
user doesn't have permission to update head repository |
@elasticmachine merge upstream |
user doesn't have permission to update head repository |
76f9380
to
cb0da81
Compare
@elasticmachine merge upstream |
user doesn't have permission to update head repository |
@elasticmachine merge upstream |
user doesn't have permission to update head repository |
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* [ML] Consolidating shared types and util functions * including formatter * adding missing includes * removing unused export * ignoring numeral type error Co-authored-by: Elastic Machine <[email protected]>
* master: [ML] Transforms: Fix API error message display for edit flyout. (elastic#65494) [SIEM][Detection Engine] Fixes import bug with non existent signals index (elastic#65595) [Lens] Use rules of hooks with linting (elastic#65593) [ML] Migrate server side Mocha tests to Jest. (elastic#65651) Fixes the client to setup SSL with the CA certificates for testing (elastic#65598) reduce uptime plugin initial bundle size (elastic#65257) [ML] Consolidating shared types and util functions (elastic#65247) [Drilldowns] Preserve state when selecting different action factory (elastic#65074) Migrate test plugins ⇒ NP (kbn_tp_embeddable_explorer) (elastic#64756) Move remaining home assets to the new platform (elastic#65053) Change the copy and the id from blacklist to block list for consistency (elastic#65419) [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522) [ML] Fix the limit control on the Anomaly explorer page (elastic#65459) [Mappings editor] Add component integration tests (elastic#63853) [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456) [Logs UI] Disable search bar when live stream is on. (elastic#65491)
…ponents * alerting/lazy-load-actions: align and style loading indicator [ML] Transforms: Fix API error message display for edit flyout. (elastic#65494) [SIEM][Detection Engine] Fixes import bug with non existent signals index (elastic#65595) [Lens] Use rules of hooks with linting (elastic#65593) [ML] Migrate server side Mocha tests to Jest. (elastic#65651) Fixes the client to setup SSL with the CA certificates for testing (elastic#65598) reduce uptime plugin initial bundle size (elastic#65257) [ML] Consolidating shared types and util functions (elastic#65247) [Drilldowns] Preserve state when selecting different action factory (elastic#65074) Migrate test plugins ⇒ NP (kbn_tp_embeddable_explorer) (elastic#64756) Move remaining home assets to the new platform (elastic#65053) Change the copy and the id from blacklist to block list for consistency (elastic#65419) [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522) [ML] Fix the limit control on the Anomaly explorer page (elastic#65459) [Mappings editor] Add component integration tests (elastic#63853) [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456) [Logs UI] Disable search bar when live stream is on. (elastic#65491)
* [ML] Consolidating shared types and util functions * including formatter * adding missing includes * removing unused export * ignoring numeral type error Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Moving all constants, types and util functions which are being used by other plugins to a single list exported from the entry point of the ML client side plugin.