Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [NP][Discover] Move discover into new platform (#63473) #65177

Merged
merged 3 commits into from
May 6, 2020

Conversation

sulemanof
Copy link
Contributor

Backports the following commits to 7.x:

sulemanof and others added 2 commits May 4, 2020 23:45
* Move discover into NP

* Convert doc_table tests to jest

* Move rows_headers to use jest

* Move fixed_scroll.test

* Clean up

* Revert jest changes

* Pass down deps into IndexPatternFieldList

* Fix conflicts

* Pass env vars

* Remove LegacyCoreStart

* Update generated doc

* Fix canvas type

* Fix i18n

* Improve stub_index_pattern code

* Add fieldFormats to mocked services

* Skip failing tests
- while still working on them, to find out if other tests fail in jenkins

* Unskip sidebar test

* Move mocha tests to legacy

- delete jest tests, can be converted later on

* Fix Scss imports
- Seems functional tests didn't build because of them?

* Remove another invalid SCSS import

* Pass deps as last argument

* Move field list into data start contract

* Move create field into data start contract, fix tests

* Update docs

* Fix duplicating fields

* Update snapshots in management

* Fix review comments

* Update docs

* Fix angular compilation

* Update docs

Co-authored-by: Matthias Wilhelm <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
# Conflicts:
#	.github/CODEOWNERS
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
# Conflicts:
#	docs/development/plugins/data/public/kibana-plugin-plugins-data-public.field._constructor_.md
#	docs/development/plugins/data/public/kibana-plugin-plugins-data-public.field.md
#	docs/development/plugins/data/public/kibana-plugin-plugins-data-public.md
#	src/legacy/ui/public/field_editor/field_editor.test.tsx
#	src/plugins/data/public/index.ts
#	src/plugins/data/public/public.api.md
#	x-pack/legacy/plugins/canvas/canvas_plugin_src/expression_types/embeddable_types.ts
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sulemanof sulemanof merged commit 630865f into elastic:7.x May 6, 2020
@sulemanof sulemanof deleted the backport/7.x/pr-63473 branch May 6, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants