Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index pattern management to Kibana platform #65026

Merged
Merged
Changes from 1 commit
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
35e4504
worrk in progress - mostly working
mattkime May 3, 2020
3c7c3ba
eslint fixes
mattkime May 3, 2020
701c88c
update i18n
mattkime May 4, 2020
f0f3ca5
comment cleanup, fix functional tests
mattkime May 4, 2020
f2cdad9
Merge branch 'master' into index_pattern_management_ui_kibana_platform
mattkime May 4, 2020
6141b7f
fix create index pattern functional test
mattkime May 4, 2020
a8685e9
fix import references
mattkime May 5, 2020
5ba8c3f
fix tests, minor cleanups
mattkime May 6, 2020
5ad50eb
Merge branch 'master' into index_pattern_management_ui_kibana_platform
mattkime May 6, 2020
bc96e16
fix url
mattkime May 6, 2020
8b3f39a
Merge branch 'master' into index_pattern_management_ui_kibana_platform
mattkime May 6, 2020
2932a5c
Merge branch 'master' into index_pattern_management_ui_kibana_platform
mattkime May 6, 2020
ad28f0e
fix test: management scripted fields should not allow saving of inva…
alexwizp May 6, 2020
5d8acd5
fix JEST, fix types
alexwizp May 6, 2020
f33576b
fixed X-Pack Chrome Functional tests / Group 2
VladLasitsa May 6, 2020
5f82b25
Fixed types
VladLasitsa May 6, 2020
6119a09
Fixed another one test from X-Pack Chrome Functional tests / Group 2
VladLasitsa May 6, 2020
1d3fc79
fix snapshots
alexwizp May 6, 2020
cea23ea
move getting indexPatterns to the comonents
VladLasitsa May 6, 2020
71b9ac1
fix ts issue
alexwizp May 6, 2020
d86949d
Merge remote-tracking branch 'upstream/master' into index_pattern_man…
alexwizp May 6, 2020
c55b877
fix JEST
alexwizp May 6, 2020
e5a129f
Merge branch 'master' into index_pattern_management_ui_kibana_platform
mattkime May 6, 2020
b39b43b
Merge branch 'index_pattern_management_ui_kibana_platform' of github.…
mattkime May 6, 2020
449cca9
cleanup
alexwizp May 7, 2020
16130e9
Merge remote-tracking branch 'upstream/master' into index_pattern_man…
alexwizp May 7, 2020
3100fab
add INDEX_PATTERN_MANAGEMENT_SECTION_PATH constant
alexwizp May 7, 2020
fd77101
Added breadcrumbs to each route
VladLasitsa May 7, 2020
9392f6c
replace href's to index pattern management section
alexwizp May 7, 2020
049ef17
Merge remote-tracking branch 'upstream/master' into index_pattern_man…
alexwizp May 7, 2020
7789d6f
rename helpers to services
VladLasitsa May 7, 2020
59ace74
fix issue in add_data
alexwizp May 7, 2020
8b537bd
moved scss
VladLasitsa May 7, 2020
9676eb7
Merge branch 'master' into index_pattern_management_ui_kibana_platform
mattkime May 8, 2020
b710fde
Added test for utils and fixed problem with flyout
VladLasitsa May 8, 2020
44fe9db
Merge branch 'index_pattern_management_ui_kibana_platform' of github.…
VladLasitsa May 8, 2020
0c6126e
added time field styles
VladLasitsa May 8, 2020
6467fbb
fix png references
alexwizp May 8, 2020
28b91df
Fixed docTitle behavior
VladLasitsa May 8, 2020
13df411
Merge branch 'master' into index_pattern_management_ui_kibana_platform
mattkime May 8, 2020
a61f236
Merge branch 'index_pattern_management_ui_kibana_platform' of github.…
mattkime May 8, 2020
06c62d6
Merge branch 'master' into index_pattern_management_ui_kibana_platform
elasticmachine May 11, 2020
575e06f
add field format editors to migration doc
mattkime May 11, 2020
551534a
fix plugin name
mattkime May 11, 2020
d906325
Merge branch 'master' into index_pattern_management_ui_kibana_platform
mattkime May 12, 2020
13178b0
Merge branch 'master' into index_pattern_management_ui_kibana_platform
mattkime May 12, 2020
a017d73
remove comments
mattkime May 12, 2020
f777be7
remove comments
mattkime May 12, 2020
8cd6c88
update snäpshöt
mattkime May 12, 2020
257cacd
Merge remote-tracking branch 'upstream/master' into index_pattern_man…
VladLasitsa May 13, 2020
d59ec70
Using history push instead of href
VladLasitsa May 13, 2020
3a2576e
Fixed tests and types
VladLasitsa May 13, 2020
4ce871e
fixed url
VladLasitsa May 13, 2020
d2564ac
fix i18n content
mattkime May 13, 2020
b235793
removed constant INDEX_PATTERN_MANAGEMENT_SECTION_PATH and fixed styles
VladLasitsa May 14, 2020
1884f0d
Fixed types
VladLasitsa May 14, 2020
00dc56a
Back styles into index
VladLasitsa May 14, 2020
4deb1b2
Merge remote-tracking branch 'upstream/master' into index_pattern_man…
alexwizp May 15, 2020
354cc16
Merge branch 'master' into index_pattern_management_ui_kibana_platform
mattkime May 15, 2020
f1f6680
fix scss
mattkime May 16, 2020
461069e
Merge branch 'master' into index_pattern_management_ui_kibana_platform
mattkime May 16, 2020
e78faf7
add url forwarding from old url setup
mattkime May 16, 2020
c959006
typescript fix
mattkime May 16, 2020
497638c
rename function, impoved snapshots
mattkime May 17, 2020
800965d
Merge branch 'master' into index_pattern_management_ui_kibana_platform
elasticmachine May 18, 2020
7edfc27
pass link to painless docs
mattkime May 19, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests, minor cleanups
mattkime committed May 6, 2020

Verified

This commit was signed with the committer’s verified signature.
commit 5ba8c3f91925ddd23dede7b85664ef38b5717e2c

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -18,9 +18,9 @@
*/

import { getIndices } from './get_indices';
import { IndexPatternCreationConfig } from '../../../../../../../../../plugins/index_pattern_management/public';
import { IndexPatternCreationConfig } from '../../../../../index_pattern_management/public';
// eslint-disable-next-line @kbn/eslint/no-restricted-paths
import { LegacyApiCaller } from '../../../../../../../../../plugins/data/public/search/legacy';
import { LegacyApiCaller } from '../../../../../data/public/search/legacy';

export const successfulResponse = {
hits: {
Original file line number Diff line number Diff line change
@@ -18,8 +18,8 @@
*/

import { get, sortBy } from 'lodash';
import { IndexPatternCreationConfig } from '../../../../../../../../../plugins/index_pattern_management/public';
import { DataPublicPluginStart } from '../../../../../../../../../plugins/data/public';
import { IndexPatternCreationConfig } from '../../../../../index_pattern_management/public';
import { DataPublicPluginStart } from '../../../../../data/public';
import { MatchedIndex } from '../types';

export async function getIndices(
Original file line number Diff line number Diff line change
@@ -39,7 +39,7 @@ interface CreateEditFieldProps extends RouteComponentProps {
fieldName?: string;
fieldFormatEditors: any;
services: {
UiSettings: IUiSettingsClient;
uiSettings: IUiSettingsClient;
docTitle: ChromeDocTitle;
http: HttpStart;
docLinksScriptedFields: DocLinksStart['links']['scriptedFields'];
@@ -103,15 +103,15 @@ export const CreateEditField = withRouter(
<EuiFlexItem>
<IndexHeader
indexPattern={indexPattern}
defaultIndex={services.UiSettings.get('defaultIndex')}
defaultIndex={services.uiSettings.get('defaultIndex')}
/>
</EuiFlexItem>
<EuiFlexItem>
<FieldEditor
indexPattern={indexPattern}
field={field}
helpers={{
alexwizp marked this conversation as resolved.
Show resolved Hide resolved
UiSettings: services.UiSettings,
uiSettings: services.uiSettings,
http: services.http,
fieldFormatEditors,
redirectAway,
Original file line number Diff line number Diff line change
@@ -37,7 +37,7 @@ export interface CreateEditFieldContainerProps
fieldFormatEditors: any;
getConfig: IUiSettingsClient;
services: {
UiSettings: IUiSettingsClient;
uiSettings: IUiSettingsClient;
notifications: NotificationsStart;
docTitle: ChromeDocTitle;
http: HttpStart;
@@ -63,7 +63,7 @@ const CreateEditFieldCont: React.FC<CreateEditFieldContainerProps> = ({ ...props
fieldName={props.match.params.fieldName}
fieldFormatEditors={props.fieldFormatEditors}
services={{
UiSettings: props.services.UiSettings,
uiSettings: props.services.uiSettings,
http: props.services.http,
docLinksScriptedFields: props.services.docLinksScriptedFields,
SearchBar: props.services.SearchBar,
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@
* under the License.
*/

import { IIndexPattern } from '../../../../../../../../../../plugins/data/public';
import { IIndexPattern } from '../../../../../../data/public';
import { getFieldFormat } from './get_field_format';

const indexPattern = ({
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@
*/

import { get } from 'lodash';
import { IIndexPattern } from '../../../../../../../../../../plugins/data/public';
import { IIndexPattern } from '../../../../../../data/public';

export function getFieldFormat(indexPattern?: IIndexPattern, fieldName?: string): string {
return indexPattern && fieldName

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -75,7 +75,11 @@ describe('ScriptedFieldsTable', () => {

test('should render normally', async () => {
const component = shallow<ScriptedFieldsTable>(
<ScriptedFieldsTable indexPattern={indexPattern} helpers={helpers} />
<ScriptedFieldsTable
indexPattern={indexPattern}
helpers={helpers}
painlessDocLink={'painlessDoc'}
/>
);

// Allow the componentWillMount code to execute
@@ -88,7 +92,11 @@ describe('ScriptedFieldsTable', () => {

test('should filter based on the query bar', async () => {
const component = shallow(
<ScriptedFieldsTable indexPattern={indexPattern} helpers={helpers} />
<ScriptedFieldsTable
indexPattern={indexPattern}
helpers={helpers}
painlessDocLink={'painlessDoc'}
/>
);

// Allow the componentWillMount code to execute
@@ -112,6 +120,7 @@ describe('ScriptedFieldsTable', () => {
{ name: 'Bad', lang: 'somethingElse', script: 'z++' },
],
})}
painlessDocLink={'painlessDoc'}
helpers={helpers}
/>
);
@@ -133,6 +142,7 @@ describe('ScriptedFieldsTable', () => {
indexPattern={getIndexPatternMock({
getScriptedFields: () => [],
})}
painlessDocLink={'painlessDoc'}
helpers={helpers}
/>
);
@@ -147,7 +157,11 @@ describe('ScriptedFieldsTable', () => {

test('should show a delete modal', async () => {
const component = shallow<ScriptedFieldsTable>(
<ScriptedFieldsTable indexPattern={indexPattern} helpers={helpers} />
<ScriptedFieldsTable
indexPattern={indexPattern}
helpers={helpers}
painlessDocLink={'painlessDoc'}
/>
);

await component.update(); // Fire `componentWillMount()`
@@ -167,6 +181,7 @@ describe('ScriptedFieldsTable', () => {
removeScriptedField,
}}
helpers={helpers}
painlessDocLink={'painlessDoc'}
/>
);

Loading