move core provier to NP. allows to run tests on every page #64929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
chore
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
|
@elasticmachine merge upstream |
mshustov
force-pushed
the
move-core-provider-to-NP
branch
from
eb5d2fb to
77d668c
Compare
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mshustov
commented
May 6, 2020
| "id": "core_provider_plugin", | ||
| "version": "0.0.1", | ||
| "kibanaVersion": "kibana", | ||
| "optionalPlugins": ["core_plugin_a", "core_plugin_b", "licensing"], |
There was a problem hiding this comment.
I don't see we reference any x-pack plugins here. They are used only if present in the codebase. In the future, we might automate the generation of the optional plugins list.
mshustov
commented
May 6, 2020
| @@ -146,9 +146,6 @@ export default async function({ readConfigFile }) { | |||
| uptime: { | |||
| pathname: '/app/uptime', | |||
| }, | |||
| apm: { | |||
| pathname: '/app/apm', | |||
| }, | |||
There was a problem hiding this comment.
the duplicate is declared below https://github.com/elastic/kibana/pull/64929/files#diff-6efcd30a7a7fdd7bdab17829239782bcR192
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
May 7, 2020
…4929) * move core provier to NP. allows to run tests on every page * remove no-base-path * pass whole KbnTestServer config * fix build path * another id * np * build kibana tests plugins. it is used in xpack tests Co-authored-by: Elastic Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 7, 2020
* master: (42 commits) fix SavedObjectMigrationMap type (elastic#65569) [Uptime] Improve cert flaky test (elastic#65458) [Uptime] Fix monitor list result runtime type, ip can be null (elastic#65532) [APM] Agent configuration: Bug makes it possible to create invalid configurations (elastic#65508) [APM] Remove link from active page in the breadcrumb (elastic#65473) [SIEM] Fixes test flakiness (elastic#65510) [ESLint] update @kbn/eslint/no-restricted-paths rule to allow imports mocks from folder (elastic#65471) Migrate test plugins ⇒ NP (kbn_tp_run_pipeline) (elastic#64780) move core provier to NP. allows to run tests on every page (elastic#64929) Extended alerting documentation with information about using Kibana keystore and action types for preconfigured connectors (elastic#65201) [functional tests] add some missing awaits (elastic#65566) Fixed create new connector from alert flyout form throw an error messages in external plugins. (elastic#65539) [SIEM] [Cases] External services not getting all comments bug fix (elastic#65307) Migrate Coordinate Maps to NP (elastic#64668) Updating Canvas location in nav (elastic#65519) [SIEM][Lists] Fixes up contracts to work outside of requests [Lens] Remove "inside only" option for treemap labels (elastic#65363) [Uptime] Add TLS alert functional test (elastic#65303) Fix z-index of kbnLoadingIndicator (elastic#65521) Fixed indice assertion to loop through expected keys (elastic#64684) ...
mshustov
added a commit
that referenced
this pull request
May 7, 2020
…65608) * move core provier to NP. allows to run tests on every page * remove no-base-path * pass whole KbnTestServer config * fix build path * another id * np * build kibana tests plugins. it is used in xpack tests Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 7, 2020
…ttional-flaky * upstream/master: (49 commits) Move remaining home assets to the new platform (elastic#65053) Change the copy and the id from blacklist to block list for consistency (elastic#65419) [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522) [ML] Fix the limit control on the Anomaly explorer page (elastic#65459) [Mappings editor] Add component integration tests (elastic#63853) [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456) [Logs UI] Disable search bar when live stream is on. (elastic#65491) fix SavedObjectMigrationMap type (elastic#65569) [Uptime] Improve cert flaky test (elastic#65458) [Uptime] Fix monitor list result runtime type, ip can be null (elastic#65532) [APM] Agent configuration: Bug makes it possible to create invalid configurations (elastic#65508) [APM] Remove link from active page in the breadcrumb (elastic#65473) [SIEM] Fixes test flakiness (elastic#65510) [ESLint] update @kbn/eslint/no-restricted-paths rule to allow imports mocks from folder (elastic#65471) Migrate test plugins ⇒ NP (kbn_tp_run_pipeline) (elastic#64780) move core provier to NP. allows to run tests on every page (elastic#64929) Extended alerting documentation with information about using Kibana keystore and action types for preconfigured connectors (elastic#65201) [functional tests] add some missing awaits (elastic#65566) Fixed create new connector from alert flyout form throw an error messages in external plugins. (elastic#65539) [SIEM] [Cases] External services not getting all comments bug fix (elastic#65307) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moves
core_provider_plugintest plugins to be loaded in NP.Blocker for #63443 since the licensing plugin tests are broken after the Kibana app migrated to KP.