Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed indice assertion to loop through expected keys #64684

Merged
merged 11 commits into from
May 6, 2020
Merged

Fixed indice assertion to loop through expected keys #64684

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8c1ff81
Changed assertion to loop through expected keys and confirm that they…
Apr 28, 2020
b60377c
Changed assertion to loop through expected keys and confirm that they…
Apr 28, 2020
d377c5b
Fixed typo in function.
Apr 28, 2020
1bf9258
Changed assertion per conversation.
Apr 29, 2020
317369d
Updated assertion on second test.
Apr 29, 2020
ade2ece
Fixed assertion for equality that's not strict.
Apr 30, 2020
1f3b975
Merge branch 'master' into Fixed_Indice_Assertion_To_Loop_Through_Exp…
elasticmachine Apr 30, 2020
8d32828
Added comment to code to explain why the arrays were sorted.
Apr 30, 2020
a540e0b
Merge branch 'Fixed_Indice_Assertion_To_Loop_Through_Expected_Keys' o…
Apr 30, 2020
d482ae1
Merge branch 'master' into Fixed_Indice_Assertion_To_Loop_Through_Exp…
elasticmachine May 3, 2020
72ffbaa
Merge branch 'master' into Fixed_Indice_Assertion_To_Loop_Through_Exp…
elasticmachine May 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions x-pack/test/api_integration/apis/management/index_management/indices.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,11 @@ export default function({ getService }) {
'ilm', // data enricher
'isRollupIndex', // data enricher
];
expect(Object.keys(body[0])).to.eql(expectedKeys);
// We need to sort the keys before comparing then, because race conditions
// can cause enrichers to register in non-deterministic order.
const sortedExpectedKeys = expectedKeys.sort();
const sortedReceivedKeys = Object.keys(body[0]).sort();
expect(sortedReceivedKeys).to.eql(sortedExpectedKeys);
});
});

Expand All @@ -225,7 +229,11 @@ export default function({ getService }) {
'ilm', // data enricher
'isRollupIndex', // data enricher
];
expect(Object.keys(body[0])).to.eql(expectedKeys);
// We need to sort the keys before comparing then, because race conditions
// can cause enrichers to register in non-deterministic order.
const sortedExpectedKeys = expectedKeys.sort();
const sortedReceivedKeys = Object.keys(body[0]).sort();
expect(sortedReceivedKeys).to.eql(sortedExpectedKeys);
expect(body.length > 1).to.be(true); // to contrast it with the next test
});
});
Expand Down