Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[share url] fixes buttons on share panel using dark theme #6465

Merged
merged 1 commit into from
Mar 8, 2016

Conversation

BigFunger
Copy link
Contributor

fixes #6270

adds btn and btn-default classes to the buttons on this page.

@BigFunger
Copy link
Contributor Author

Slight issue... I fixed this by adding the btn and btn-default classes to those buttons.
This changes the appearance of the buttons when the dark theme is not enabled, however it does make them look like the rest of the default buttons in the app with the exception of the search button in the nav bar. The navbar button has custom styling though. Thoughts?

Old Appearance

pasted_image_at_2016_03_08_12_45_pm

New Appearance

pasted_image_at_2016_03_08_12_46_pm

@BigFunger
Copy link
Contributor Author

@alt74 Your input would be valuable as well.

@spalger
Copy link
Contributor

spalger commented Mar 8, 2016

This is how buttons should look by default, based on the theme, and I'm fine with that. If we want standard buttons to look different we can have a larger discussions about changing btn-default

@spalger
Copy link
Contributor

spalger commented Mar 8, 2016

LGTM

@spalger spalger assigned BigFunger and unassigned spalger Mar 8, 2016
@spalger spalger added the v5.0.0 label Mar 8, 2016
@alt74
Copy link

alt74 commented Mar 8, 2016

buttons in "new appearance" screenshot look better to me compared to old. also, it feels more natural that the action button next to a field is clearly darker than the field.

BigFunger added a commit that referenced this pull request Mar 8, 2016
[share url] fixes buttons on share panel using dark theme
@BigFunger BigFunger merged commit a8b494d into elastic:master Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UrlShortener icon is hard to see when using the dark theme
4 participants